Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 433024 - media-tv/tvheadend-3.2 version bump
Summary: media-tv/tvheadend-3.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Leho Kraav (:macmaN @lkraav)
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2012-08-28 05:45 UTC by BT
Modified: 2012-10-27 06:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tvheadend-3.0 ebuild (tvheadend-3.0.ebuild,1.69 KB, text/plain)
2012-08-28 05:45 UTC, BT
Details
tvheadend-3.0 ebuild (tvheadend-3.0.ebuild,1.67 KB, text/plain)
2012-08-28 08:13 UTC, BT
Details
tvheadend-3.0 ebuild (tvheadend-3.0.ebuild,1.57 KB, text/plain)
2012-10-16 00:23 UTC, BT
Details
tvheadend-3.0 ebuild (tvheadend-3.0.ebuild,1.53 KB, text/plain)
2012-10-16 06:43 UTC, Sergey Popov
Details
tvheadend-3.0 ebuild (tvheadend-3.0.ebuild,1.62 KB, text/plain)
2012-10-16 08:29 UTC, Sergey Popov
Details
ebuild modified for 3.2 (tvheadend-3.2.ebuild,1.94 KB, application/octet-stream)
2012-10-25 12:11 UTC, Martin Bednar
Details
tvheadend-3.2.ebuild (tvheadend-3.2.ebuild,1.82 KB, text/plain)
2012-10-25 15:12 UTC, Martin Bednar
Details
tvheadend-3.2 ebuild (tvheadend-3.2.ebuild,1.65 KB, text/plain)
2012-10-27 00:42 UTC, BT
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BT 2012-08-28 05:45:41 UTC
Created attachment 322408 [details]
tvheadend-3.0 ebuild

The ebuild for 3.0 is based off my git ebuild from bug #288022. I've updated the homepage and src uri. The version number is set manually in src_prepare since upstream source only uses git for versioning.
Comment 1 Ben de Groot (RETIRED) gentoo-dev 2012-08-28 06:49:54 UTC
Please base any version bumps on the ebuild already in portage. You may also want to use vcs-snapshot eclass.
Comment 2 BT 2012-08-28 08:04:53 UTC
(In reply to comment #1)
> Please base any version bumps on the ebuild already in portage. You may also
> want to use vcs-snapshot eclass.

The git ebuild only differs from 2.12 to reflect the changes upstream made post 2.12 release. The 3.0 ebuild only adds what I mentioned in comment 1.

Thanks for the tip about vcs-snapshot eclass. The hash that is appended to the unpacked directory name is very annoying. I will post an updated ebuild.
Comment 3 BT 2012-08-28 08:13:22 UTC
Created attachment 322410 [details]
tvheadend-3.0 ebuild
Comment 4 BT 2012-10-16 00:23:34 UTC
Created attachment 326666 [details]
tvheadend-3.0 ebuild

Updated to include fixes for bugs #438426 and #438424.
Comment 5 Sergey Popov gentoo-dev 2012-10-16 06:43:14 UTC
Created attachment 326682 [details]
tvheadend-3.0 ebuild

Improved version of tvheadend ebuild:

- remove redundant mandir and datadir override;
- add initial prefix support;
- add missing zlib dependency, remove automagic on zlib, reorganize dependencies;
- simplify src_install, add DOCS variable.
Comment 6 BT 2012-10-16 07:48:58 UTC
(In reply to comment #5)
> - remove redundant mandir and datadir override;

Without the mandir override the manual gets installed directly in /usr/share/man and doesn't work for me.

I added the datadir override to prevent pollution of /usr/share. This was in response to comment 44 in bug #288022.
Comment 7 Sergey Popov gentoo-dev 2012-10-16 08:23:03 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > - remove redundant mandir and datadir override;
> 
> Without the mandir override the manual gets installed directly in
> /usr/share/man and doesn't work for me.
> 
> I added the datadir override to prevent pollution of /usr/share. This was in
> response to comment 44 in bug #288022.

Yep, it seems that you are right - configure script is broken and will not work as upstream says.
Comment 8 Sergey Popov gentoo-dev 2012-10-16 08:29:00 UTC
Created attachment 326684 [details]
tvheadend-3.0 ebuild

All needed paths are returned to src_configure stage, cause path construction in configure script is broken.

Also, please note, that mmx and sse configure flag handling broken and thus should be fixed(see configure script for details)
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2012-10-16 09:35:22 UTC
We may need a new proxy maintainer for this package. Leho Kraav hasn't responded to the last 2-3 tvheadend bugs.
Comment 10 Leho Kraav (:macmaN @lkraav) 2012-10-16 09:38:55 UTC
Yep, I can't keep up at all at the moment.
Comment 11 Markos Chandras (RETIRED) gentoo-dev 2012-10-16 09:44:05 UTC
(In reply to comment #10)
> Yep, I can't keep up at all at the moment.

No worries. Anyone interested to pick up this package? BT I see you are doing most of the work here so you seem to be a good candidate :)
Comment 12 BT 2012-10-16 10:04:19 UTC
(In reply to comment #11)
> No worries. Anyone interested to pick up this package? BT I see you are
> doing most of the work here so you seem to be a good candidate :)

Unfortunately I can't do it. Sorry.
Comment 13 Martin Bednar 2012-10-25 12:11:41 UTC
Created attachment 327386 [details]
ebuild modified for 3.2

I modified the 3.0 ebuild to work with 3.2, which has been released a few days ago. Will try to fix it up a bit more later.
Comment 14 BT 2012-10-25 13:01:08 UTC
(In reply to comment #13)

I have some feedback regarding the ebuild.

1. SRC_URI should be: https://github.com/downloads/${PN}/${PN}/${P}.tar.gz

2. You should explicitly disable dvbscan. When enabled the package will fetch the latest dvb-scan files during configure, which is against ebuild rules from what I understand.

3. The support/version script will now parse the debian/changelog file for the version number. However the version number is incorrectly set to 3.1.694 so we still need to set the version number manually.
Comment 15 Martin Bednar 2012-10-25 15:12:33 UTC
Created attachment 327402 [details]
tvheadend-3.2.ebuild

1. Done. I couldn't figure out the ${P}
2. Done.
3. Maybe done. Not sure if the fix is correct.
Comment 16 Sergey Popov gentoo-dev 2012-10-26 09:58:29 UTC
Comment on attachment 327402 [details]
tvheadend-3.2.ebuild

Little notice on SRC_URI - you should use "mirror://github/${PN}/${P}.tar.gz"
Comment 17 Sergey Popov gentoo-dev 2012-10-26 10:01:35 UTC
(In reply to comment #16)
> Comment on attachment 327402 [details]
> tvheadend-3.2.ebuild
> 
> Little notice on SRC_URI - you should use "mirror://github/${PN}/${P}.tar.gz"

Sorry, i mean "mirror://github/${PN}/${PN}/${P}.tar.gz"
Comment 18 BT 2012-10-26 10:40:06 UTC
You can also make zlib support optional since it can be controlled with configure now.
Comment 19 BT 2012-10-27 00:42:34 UTC
Created attachment 327508 [details]
tvheadend-3.2 ebuild

Minor update of 3.2 ebuild.

- Add zlib use flag.
- Simplify setting version number sed.
- Sync removing '-Werror' sed with 2.12 ebuild.
Comment 20 BT 2012-10-27 00:43:58 UTC
(In reply to comment #17)
> Sorry, i mean "mirror://github/${PN}/${PN}/${P}.tar.gz"

This doesn't seem to work for packages that are not in the tree.
Comment 21 Ben de Groot (RETIRED) gentoo-dev 2012-10-27 06:10:28 UTC
(In reply to comment #19)
> Created attachment 327508 [details]
> tvheadend-3.2 ebuild
> 
> Minor update of 3.2 ebuild.
> 
> - Add zlib use flag.
> - Simplify setting version number sed.
> - Sync removing '-Werror' sed with 2.12 ebuild.

I've committed this, with some minor edits. Please report if there are any problems.