431784 – x11-wm/openbox does not pass desktop-file-validate

Bug 431784 - x11-wm/openbox does not pass desktop-file-validate

Summary: x11-wm/openbox does not pass desktop-file-validate

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal minor (vote)
Assignee:	Markos Chandras (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-08-17 22:41 UTC by Julian Ospald
Modified:	2012-08-27 10:29 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Julian Ospald 2012-08-17 22:41:57 UTC

all versions

# desktop-file-validate /usr/share/applications/openbox.desktop
/usr/share/applications/openbox.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated

Comment 1 Markos Chandras (RETIRED) gentoo-dev

2012-08-25 08:54:34 UTC

Is there a chance you report this upstream with the proposed patch? Then I can fix the ebuild in portage as well

Comment 2 Markos Chandras (RETIRED) gentoo-dev

2012-08-25 09:34:55 UTC

Actually there are many other files that fail the validation as well

 * QA Notice: This package installs one or more .desktop files that do not
 * pass validation.
 * 
 * 	/usr/share/applications/openbox.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
 * 	/usr/share/gnome/wm-properties/openbox.desktop: error: file contains group "Window Manager", but groups extending the format should start with "X-"
 * 	/usr/share/gnome/wm-properties/openbox.desktop: error: file contains key "ConfigExec" in group "Desktop Entry", but keys extending the format should start with "X-"
 * 	/usr/share/xsessions/openbox-gnome.desktop: error: (will be fatal in the future): value "openbox.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
 * 	/usr/share/xsessions/openbox-gnome.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")
 * 	/usr/share/xsessions/openbox-gnome.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
 * 	/usr/share/xsessions/openbox-kde.desktop: error: (will be fatal in the future): value "openbox.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
 * 	/usr/share/xsessions/openbox-kde.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")
 * 	/usr/share/xsessions/openbox-kde.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
 * 	/usr/share/xsessions/openbox.desktop: error: (will be fatal in the future): value "openbox.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
 * 	/usr/share/xsessions/openbox.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")
 * 	/usr/share/xsessions/openbox.desktop: warning: key "Encoding" in group "Des

Comment 3 Markos Chandras (RETIRED) gentoo-dev

2012-08-27 10:29:41 UTC

Thanks. Fixed

+*openbox-3.5.0_p20111019-r2 (27 Aug 2012)
+
+  27 Aug 2012; Markos Chandras <hwoarang@gentoo.org>
+  +files/openbox-3.5.0-fix-desktop-files.patch,
+  +openbox-3.5.0_p20111019-r2.ebuild, -openbox-3.5.0_p20111019-r1.ebuild,
+  openbox-9999.ebuild:
+  fix desktop files according to fd.o desktop entry specifications. Thanks to
+  Julian Ospald <hasufell@gentoo.org>. Bug #431784
+