Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 429648 - app-admin/puppet-2.7.X misbehaves with eix >=0.25.2
Summary: app-admin/puppet-2.7.X misbehaves with eix >=0.25.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL: https://projects.puppetlabs.com/issue...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-03 14:25 UTC by Seraphim Mellos
Modified: 2012-09-10 15:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (should really be named r1) (puppet-2.7.18.ebuild,4.64 KB, text/plain)
2012-08-26 08:52 UTC, Matthew Thode ( prometheanfire )
Details
puppet-2.7.18-eix_fix.patch (puppet-2.7.18-eix_fix.patch,1.34 KB, patch)
2012-08-26 08:53 UTC, Matthew Thode ( prometheanfire )
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seraphim Mellos 2012-08-03 14:25:40 UTC
Puppet depends on eix in order to handle searches in portage but following a change in the eix cache file path, puppet incorrectly calls eix-udpate on every call to the `package {}` provider thinking eix has an outdated database. Depending on your puppet modules and the local storage, a signle puppet run may take ages to complete simply because it's calling eix-update twice for every package it is checking. 

I've verified that it affects all puppet versions >=2.7.13 (probably <= as well) if eix>=0.25.2 is installed.

The bug has been reported upstream [1] and a fix had been committed but apparently the fix won't be available before puppet-2.7.20. 

Any chance we can get this patch applied for existing puppet versions in portage until 2.7.20 is out? It is quite simple and should apply to all versions >=2.7.13 (maybe earlier versions as well but I haven't tested).

[1] https://projects.puppetlabs.com/issues/15665

Reproducible: Always

Steps to Reproduce:
1. emerge =eix-0.25.5 && eix-update
2. emerge =puppet-2.7.13
3. puppet apply --debug --execute 'package { "gentoolkit" : ensure   => latest, category => "app-portage"; }'
Actual Results:  
[...]
debug: Prefetching portage resources for package
debug: Puppet::Type::Package::ProviderPortage: Executing '/usr/bin/eix-update'       # 1st run
debug: Puppet::Type::Package::ProviderPortage: Executing '/usr/bin/eix --nocolor --pure-packages --stable --installed --format   [] []  '
debug: Puppet::Type::Package::ProviderPortage: Executing '/usr/bin/eix-update'       # 2nd run
debug: Puppet::Type::Package::ProviderPortage: Executing '/usr/bin/eix --nocolor --pure-packages --stable --format   [] []   --exact --category-name app-portage/gentoolkit'
[...]

Expected Results:  
No eix-updates should be run

Portage 2.1.11.9 (default/linux/x86/10.0, gcc-4.5.3, glibc-2.11.3, 3.3.0-gentoo i686)
=================================================================
System uname: Linux-3.3.0-gentoo-i686-Intel-R-_Core-TM-_i7_CPU_920_@_2.67GHz-with-gentoo-2.1
Timestamp of tree: Fri, 03 Aug 2012 13:35:01 +0000
app-shells/bash:          4.2_p10
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.1-r1, 3.1.3-r1
dev-util/cmake:           2.8.4-r1
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10
sys-apps/sandbox:         2.4
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.1-r1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.4.5, 4.5.3-r2
sys-devel/gcc-config:     1.5.1-r1
sys-devel/libtool:        2.4-r4
sys-devel/make:           3.82
sys-kernel/linux-headers: 2.6.36.1 (virtual/os-headers)
sys-libs/glibc:           2.11.3
Repositories: gentoo xen x-portage
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="* -@EULA PUEL skype-eula dlj-1.1 AdobeFlash-10.1 Nero-EULA-US"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=prescott -O2 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /var/lib/redmine/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /var/lib/redmine/config/locales /var/lib/redmine/config/settings.yml"
CXXFLAGS="-march=prescott -O2 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--jobs=8 --load-average=10.0"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -march=i686 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en el"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/xen /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl berkdb bzip2 cairo cli cracklib crypt cups cxx dbus dri fortran gdbm gpm iconv ipv6 jpeg modules mudflap ncurses nls nptl openmp pam pcre png pppd readline session ssl tcpd truetype unicode vim-syntax x86 zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en el" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nvidia nv" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LANG, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-08-04 00:43:44 UTC
Also:

$ grep DEPEND.*DEPEND *.ebuild
puppet-2.7.11.ebuild:DEPEND="${DEPEND}
puppet-2.7.11.ebuild:RDEPEND="${RDEPEND}
puppet-2.7.12.ebuild:DEPEND="${DEPEND}
puppet-2.7.12.ebuild:RDEPEND="${RDEPEND}
puppet-2.7.13.ebuild:DEPEND="${DEPEND}
puppet-2.7.13.ebuild:RDEPEND="${RDEPEND}
puppet-2.7.18.ebuild:DEPEND="${DEPEND}
puppet-2.7.18.ebuild:RDEPEND="${RDEPEND}
Comment 2 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-08-26 07:29:23 UTC
I can confirm this bug, have been wondering what was killing my VM-host...

gonna see if I can work out a patch
Comment 3 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-08-26 08:52:58 UTC
Created attachment 322234 [details]
new ebuild (should really be named r1)
Comment 4 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-08-26 08:53:34 UTC
Created attachment 322236 [details, diff]
puppet-2.7.18-eix_fix.patch
Comment 5 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-08-27 22:57:32 UTC
If the bug is not updated in 2 weeks I'm gonna commit under the assumption that it's good.   Also, I've been testing this on 12 servers, worksforme :D
Comment 6 Seraphim Mellos 2012-08-28 09:36:11 UTC
Is this going to be applied only to 2.7.18? All stable puppet versions in portage are currently affected by this issue. 

In any case, I also tested the patch against 2.7.11, 2.7.13 and 2.7.18 and found no issues.
Comment 7 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-08-28 17:57:39 UTC
patch applies with no modifications?
Comment 8 Sune Kloppenborg Jeppesen (RETIRED) gentoo-dev 2012-08-28 22:36:39 UTC
I've been testing 2.7.18-r1 on 9 servers with shared Eix ro cache over NFS and so far worksforme.
Comment 9 Seraphim Mellos 2012-08-29 08:19:00 UTC
(In reply to comment #7)
> patch applies with no modifications?

Yes, the patch applies to all versions mentioned without modification.
Comment 10 David Voge 2012-08-30 13:16:47 UTC
Please take into account this patch. Without this patch takes the work off of the catalog more than 1000% time.
Comment 11 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2012-09-10 15:39:16 UTC
fixed in puppet-2.7.18-r1 (in tree)