Bug 429298 – dev-lang/v8 on arm7a-hardfloat-linux-gnueabi - ERROR: Binary compiled with -mfloat-abi=hard but without -DUSE_EABI_HARDFLOAT

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Till Crueger 2012-08-01 07:37:12 UTC]

When merging v8 (required e.g. by chromium) the compilation is aborted with the error message:

ERROR: Binary compiled with -mfloat-abi=hard but without -DUSE_EABI_HARDFLOAT

[Comment 1 Till Crueger 2012-08-01 07:37:58 UTC]

Created attachment 319940 [details]
emerge --info

[Comment 2 Till Crueger 2012-08-01 07:38:26 UTC]

Created attachment 319942 [details]
Build log

[Comment 3 Till Crueger 2012-08-01 07:39:40 UTC]

Created attachment 319944 [details]
emerge -pqv

[Comment 4 Till Crueger 2012-08-01 07:40:09 UTC]

Created attachment 319946 [details]
Environment file

[Comment 5 Till Crueger 2012-08-01 12:07:31 UTC]

Created attachment 319974 [details, diff]
patch to v8 makefile to add access to -Dv8_use_arm_eabi_hardfloat option

This patch can be applied to the wrapper makefile around gyp in the v8 source tree to allow access to the -Dv8_use_arm_eabi_hardfloat option, which enables the hardfloat build for v8. This patch should be performed from the src_prepare ebuild function.

[Comment 6 Till Crueger 2012-08-01 12:10:00 UTC]

Created attachment 319978 [details, diff]
ebuild patch

Proposed patch to the ebuild to apply the makefile patch and enable building with the hardfp option.

STATUS: Compilation works. 13 of the around 8500 automatic test cases fail. Usability not yet confirmed.

[Comment 7 Paweł Hajdan, Jr. (RETIRED) 2012-08-14 06:31:52 UTC]

dev-lang/v8 is not even keyworded ~arm...

Please let chromium@ review any ebuild changes before committing them. Generally this should be fixed upstream.

[Comment 8 Steev Klimaszewski (RETIRED) 2012-08-15 13:03:28 UTC]

Hardfloat is now considered the default for ARM (at least armv7) so this patch is very handy.  If you need access to an ARM box to test on Pawel, let me know, I can give you access to a quad core 1ghz currently running hardened hardfloat.  It's current use is for blueness to do arch testing/keywording/stabling.  Getting chromium working on ARM would be nice as currently webkit-gtk won't build, it keeps trying to mmap 1109438208 bytes for an output file.  Firefox is in a similar situation.

[Comment 9 Paweł Hajdan, Jr. (RETIRED) 2012-08-17 14:09:43 UTC]

Please submit the v8 patch upstream and post the link here.

See <http://code.google.com/p/v8/wiki/Contributing> for more info.

After the code lands upstream, we can backport it for older v8 versions in portage.

[Comment 10 Mike Gilbert 2012-08-17 14:12:03 UTC]

(In reply to comment #9)

What are you actually after here? Auto-detection of hardfp in the v8 build system?

[Comment 11 Mike Gilbert 2012-08-17 14:22:03 UTC]

(In reply to comment #10)

Never mind, I missed the Makefile patch. :)

[Comment 12 Paweł Hajdan, Jr. (RETIRED) 2012-08-17 14:26:25 UTC]

(In reply to comment #10)
> What are you actually after here? Auto-detection of hardfp in the v8 build
> system?

Auto-detection would be non-trivial, see bug #401835 . My main point is to submit the Makefile patch upstream. It looks good to me.

[Comment 13 Paweł Hajdan, Jr. (RETIRED) 2012-08-29 17:30:18 UTC]

Fixed in CVS, thanks. Upstream review: http://codereview.chromium.org/10889026/