Bug 428714 – =dev-ruby/json-1.7.4 version bump request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Manuel Rüger (RETIRED) 2012-07-30 21:58:07 UTC]

latest in tree: 1.6.7

not seen as problematic on
http://wiki.gentoo.org/index.php?title=Project:Ruby/Pending_Bumps

Please add it to the tree

[Comment 1 Hans de Graaff 2012-07-31 05:50:39 UTC]

Note that we have an automated list of which gems have new versions, so there is usually no need to file bugs for gem version bumps. Having the manpower to get to them quickly is another matter :-/

In any case I've updated json in the tree.

[Comment 2 Manuel Rüger (RETIRED) 2012-07-31 08:47:39 UTC]

Thanks for the fast fix. :)

Just one simple question, because this looks strange (and also exists in previous versions):

RDEPEND="${RDEPEND}"
DEPEND="${DEPEND}
    dev-util/ragel"

Shouldn't this be just simply:

DEPEND="dev-util/ragel"  ?

[Comment 3 Diego Elio Pettenò (RETIRED) 2012-07-31 16:38:55 UTC]

No it shouldn't, because ruby_add_bdepend/ruby_add_rdepend use DEPEND as well.

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2012-08-01 04:53:02 UTC]

(In reply to comment #3)
> No it shouldn't, because ruby_add_bdepend/ruby_add_rdepend use DEPEND as
> well.

But ebuild calls ruby_add_bdepend() after setting DEPEND.

[Comment 5 Hans de Graaff 2012-08-01 05:24:13 UTC]

(In reply to comment #4)
> (In reply to comment #3)
> > No it shouldn't, because ruby_add_bdepend/ruby_add_rdepend use DEPEND as
> > well.
> 
> But ebuild calls ruby_add_bdepend() after setting DEPEND.

It also handles dependencies before that based on the ebuild environment, not just the once set explicitly in the ebuild.

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2012-08-01 05:54:12 UTC]

(In reply to comment #5)
> It also handles dependencies before that based on the ebuild environment,
> not just the once set explicitly in the ebuild.

You misunderstand how it works. ruby_add_bdepend() takes an argument, transforms it and appends to DEPEND:
    local dependency=$(_ruby_atoms_samelib "$1")              # Line 258
    DEPEND="${DEPEND} $dependency"                            # Line 260

dev-ruby/json/json-1.7.4.ebuild contains:
RDEPEND="${RDEPEND}"                                          # Line 24
DEPEND="${DEPEND}                                             # Line 25
    dev-util/ragel"                                           # Line 26
ruby_add_bdepend "dev-ruby/rake"                              # Line 28

During processing lines 24 and 25 in dev-ruby/json/json-1.7.4.ebuild, ${RDEPEND} and ${DEPEND} are empty.

[Comment 7 Arfrever Frehtes Taifersar Arahesis 2012-08-01 06:00:55 UTC]

You can apply the following patch and call `ebuild json-1.7.4.ebuild manifest`.

--- json-1.7.4.ebuild
+++ json-1.7.4.ebuild
@@ -21,9 +21,11 @@
 SLOT="0"
 IUSE=""
 
+declare -p DEPEND RDEPEND
 RDEPEND="${RDEPEND}"
 DEPEND="${DEPEND}
        dev-util/ragel"
+declare -p DEPEND RDEPEND
 
 ruby_add_bdepend "dev-ruby/rake"