Compile error during emerge. When I mask version 3.12.6, I get the same error with version 3.12.4. I assume it is something in my environment but I have no idea what. Reproducible: Always Steps to Reproduce: 1. emerge =net-print/hplip-3.12.4 2. 3. Actual Results: Compile error (see attached files) Expected Results: Emerging hplip without errors
littleboy ~ # emerge --info '=net-print/hplip-3.12.6' Portage 2.1.11.9 (default/linux/amd64/10.0/desktop, gcc-4.6.3, glibc-2.15-r2, 3.5.0-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-3.5.0-gentoo-x86_64-Intel-R-_Atom-TM-_CPU_N570_@_1.66GHz-with-gentoo-2.1 Timestamp of tree: Sun, 29 Jul 2012 13:15:01 +0000 app-shells/bash: 4.2_p37 dev-lang/python: 2.7.3-r2, 3.2.3-r1 dev-util/cmake: 2.8.8-r3 dev-util/pkgconfig: 0.27 sys-apps/baselayout: 2.1-r1 sys-apps/openrc: 0.10.5 sys-apps/sandbox: 2.6 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6, 1.12.2 sys-devel/binutils: 2.22.90 sys-devel/gcc: 4.6.3 sys-devel/gcc-config: 1.7.3 sys-devel/libtool: 2.4.2 sys-devel/make: 3.82-r3 sys-kernel/linux-headers: 3.5 (virtual/os-headers) sys-libs/glibc: 2.15-r2 Repositories: gentoo ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://mirrors.linuxant.fr/distfiles.gentoo.org/ http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ http://mirror.ovh.net/gentoo-distfiles/ http://gentoo.tiscali.nl/ http://ftp.snt.utwente.nl/pub/os/linux/gentoo" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j5" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam firefox flac fortran gdbm gif gpm gstreamer gtk iconv jpeg lcms libnotify lock mad mmx mng modules mp3 mp4 mpeg mudflap multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds pppd qt3support readline sdl session spell sse sse2 ssl startup-notification svg tcpd thunar tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xcb xml xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" SANE_BACKENDS="hp" USERLAND="GNU" VIDEO_CARDS="intel vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
littleboy ~ # emerge -pqv '=net-print/hplip-3.12.6' [ebuild N ] net-print/hplip-3.12.6 USE="X acl fax hpcups libnotify policykit scanner snmp -doc -hpijs -kde -minimal -parport -qt4 -static-ppds"
Created attachment 319730 [details] Build log
Created attachment 319732 [details] Environment file
Seems to be a problem with >=net-print/cups-1.6.0. See URL for upstream bug.
I can confirm that masking cups-1.6.0 solves the problem
(In reply to comment #6) > I can confirm that masking cups-1.6.0 solves the problem To help fixing this bug it would be great if anybody could test hplip-3.12.6 with the patch included upstream and test if it works with stable cups-1.5 and testing cups-1.6.
(In reply to comment #7) > (In reply to comment #6) > > I can confirm that masking cups-1.6.0 solves the problem > > To help fixing this bug it would be great if anybody could test hplip-3.12.6 > with the patch included upstream and test if it works with stable cups-1.5 > and testing cups-1.6. I can confirm that the upstream patch works with cups-1.6. But I had quite some trouble applying the patch because it seems like the hplip sources have DOS line breaks and portage's epatch doesn't like that even though the patch itself has DOS line breaks as well. So I ended up using edos2unix on the two files the patch is modifying and converted the patch itself to Unix line breaks, too. I just finished testing the patch with cups-1.5.3 and it compiles fine with that version. Printing seems to be okay as well. So I'd say give it a try.
(In reply to comment #8) > I can confirm that the upstream patch works with cups-1.6. > But I had quite some trouble applying the patch because it seems like the > hplip sources have DOS line breaks and portage's epatch doesn't like that > even though the patch itself has DOS line breaks as well. So I ended up > using edos2unix on the two files the patch is modifying and converted the > patch itself to Unix line breaks, too. Note that you only need this on the first file (prnt/cupsext/cupsext.c). The problem is that this file has CRLF line endings while the other file in the patch has LF line endings. So if you just use epatch (converts CRLF to LF) it'll fail on the first file, if you use epatch --binary (won't convert) it'll fail on the second file.
I have the same problem on my box. Here's my hplip : [ebuild R ] net-print/hplip-3.12.6 USE="X hpcups qt4 -acl* -doc -fax -hpijs -kde -libnotify -minimal -parport -policykit -scanner -snmp -static-ppds" 0 kB My cups : [ebuild R ] net-print/cups-1.6.1 USE="X acl dbus filters pam python ssl threads usb -avahi -debug -gnutls -java -kerberos (-selinux) -static-libs -systemd -xinetd -zeroconf" LINGUAS="-ca -es -ja" 0 kB prnt/cupsext/cupsext.c: In function 'getPrinters': prnt/cupsext/cupsext.c:336:12: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:337:12: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:381:30: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:381:64: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:383:41: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:384:28: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:393:41: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:395:22: error: dereferencing pointer to incomplete type prnt/cupsext/cupsext.c:395:22: error: dereferencing pointer to incomplete type .....
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > I can confirm that masking cups-1.6.0 solves the problem > > > > To help fixing this bug it would be great if anybody could test hplip-3.12.6 > > with the patch included upstream and test if it works with stable cups-1.5 > > and testing cups-1.6. > > I can confirm that the upstream patch works with cups-1.6. > But I had quite some trouble applying the patch because it seems like the > hplip sources have DOS line breaks and portage's epatch doesn't like that > even though the patch itself has DOS line breaks as well. So I ended up > using edos2unix on the two files the patch is modifying and converted the > patch itself to Unix line breaks, too. > > I just finished testing the patch with cups-1.5.3 and it compiles fine with > that version. Printing seems to be okay as well. So I'd say give it a try. Could someone describe (for us numpties) how to apply this patch, or post an ebuild that does the job? I have: - Copied the net-print/hplip dir to local overlay; - Added the patch to the /files dir - Done ebuild hplip-3.12.6.ebuild digest I don't see the patch listed with other patches being applied at the start of the build though - presumably this means it fails silently? If I understand the above, I could (as a temp. hack) call dos2unix in the ebuild, but not sure the syntax to do this. I'm keen to join the testing of this so would be very appreciative if someone can advise (others tuning in might be too).
(In reply to comment #11) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #6) > > > > I can confirm that masking cups-1.6.0 solves the problem > > > > > > To help fixing this bug it would be great if anybody could test hplip-3.12.6 > > > with the patch included upstream and test if it works with stable cups-1.5 > > > and testing cups-1.6. > > > > I can confirm that the upstream patch works with cups-1.6. > > But I had quite some trouble applying the patch because it seems like the > > hplip sources have DOS line breaks and portage's epatch doesn't like that > > even though the patch itself has DOS line breaks as well. So I ended up > > using edos2unix on the two files the patch is modifying and converted the > > patch itself to Unix line breaks, too. > > > > I just finished testing the patch with cups-1.5.3 and it compiles fine with > > that version. Printing seems to be okay as well. So I'd say give it a try. > > Could someone describe (for us numpties) how to apply this patch, or post an > ebuild that does the job? I have: > > - Copied the net-print/hplip dir to local overlay; > - Added the patch to the /files dir > - Done ebuild hplip-3.12.6.ebuild digest > > I don't see the patch listed with other patches being applied at the start > of the build though - presumably this means it fails silently? You need to edit the ebuild to include the patch. Otherwise, the ebuild behaves as it did before (since you made no changes to it).
The easy way to fix this is to cut all the stuff after the first diff out of the patch and put it into a second one.
Created attachment 320218 [details] hplip-3.12.6-ipp_accessors.patch This is just the first part of the upstream patch (the part that has the DOS line endings)
Created attachment 320220 [details] hplip-3.12.6-ipp_accessors2.patch This is the rest of the upstream patch (the parts that have unix line endings)
Created attachment 320222 [details] hplip-3.12.6.ebuild Ebuild that uses the two separated patches. The first one is done using "epatch --binary" I imagine the gentoo dev will choose better names for having these separated, but atm this is good enough for me. :)
Hey I am trying to use the patches provided to get 3.12.6 to build but for some reason cant get the patches to apply. I am using the split patches provided by the members below but i get this error: PATCH COMMAND: patch -p4 -g0 -E --no-backup-if-mismatch --binary < '/usr/local/portage/net-print/hplip/files/hplip-3.12.6-first.patch' ==================================== can't find file to patch at input line 4 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff -up hplip-3.12.6/prnt/cupsext/cupsext.c.ipp_accessors hplip-3.12.6/prnt/cupsext/cupsext.c |--- hplip-3.12.6/prnt/cupsext/cupsext.c.ipp_accessors 2012-06-18 12:41:19.000000000 +0200 |+++ hplip-3.12.6/prnt/cupsext/cupsext.c 2012-07-19 17:11:47.606524137 +0200 -------------------------- No file to patch. Skipping patch. 15 out of 15 hunks ignored patch program exited with status 1 for patch #1, notice I have changed the name of the patch but I rewrote my own ebuild to reflect the changes shown below but using my naming scheme. Does this matter? It never has before... I have done this before so I don't know what the problem is... I made sure to use --binary for the first one and not the second, but it fails one the first one anyway without looking at the second. So... yeah can someone help me?
Created attachment 320244 [details, diff] Reworked patch I have reworked the patch so it should now work without splitting and binary option from patch. Please test! @Chris Slycord: Thank you for your work, this made it a bit easier for me.
Created attachment 320246 [details, diff] Needed ebuild changes @Chris Slycord: Next time please attach a diff for ebuilds as well. This makes things more readable.
Created attachment 320262 [details] patch failure output I'm also not able to build hplip-3.12.6 (or samba-3.6.6 with use flag cups) since the update to cups-1.6.1 (I've skipped 1.6.0). I've tried to apply the latest patch, but it failed as per attachment.. Of course no .rej file thanks to the --no-backup-if-mismatch flag..
(In reply to comment #20) > Created attachment 320262 [details] > patch failure output > > I'm also not able to build hplip-3.12.6 (or samba-3.6.6 with use flag cups) > since the update to cups-1.6.1 (I've skipped 1.6.0). > > I've tried to apply the latest patch, but it failed as per attachment.. > Of course no .rej file thanks to the --no-backup-if-mismatch flag.. Hm, the patch works fine here. Using different line endings is really annoying and hplip used to change them back and forth. I have opened a bug upstream requesting the use of a consistent EOL marker.
(In reply to comment #12) > You need to edit the ebuild to include the patch. Otherwise, the ebuild > behaves as it did before (since you made no changes to it). I did look at the ebuild but patches weren't named individually there ... It looked as though all .patch files for that version in the /files dir would be applied automatically, but that's probably just my poor understanding of ebuilds :( Anyway, got there in the end with the new patch. Just had to freeze the build with Ctrl+Z at the right moment and apply the patch manually. Having done this, I can report that hplip builds successfully with the patch on x86 and amd64. (Whether it will now work, that's another matter...)
Seems something happened when downloading the patch. Re-downloaded it, and it worked.
So what's keeping this bug from getting fixed?
(In reply to comment #24) > So what's keeping this bug from getting fixed? Limited time! Will try to get the patched version into the tree this evening.
+ 08 Aug 2012; Daniel Pielmeier <billie@gentoo.org> hplip-3.12.6.ebuild: + Fix building with cups-1.6. Thanks to all involved in bug #428672. Done.
Wouldn't it make sense to updated the ebuild for the latest unmasked net-print/hplip to require cups <1.6 so that more people don't hit this, or if they do hit this because they have newer cups installed be notified of this known dependency by portage?
(In reply to comment #27) > Wouldn't it make sense to updated the ebuild for the latest unmasked > net-print/hplip to require cups <1.6 so that more people don't hit this, or > if they do hit this because they have newer cups installed be notified of > this known dependency by portage? Mixing stable and unstable has never been supported. If cups-1.6 becomes stable then a hplip version supporting it should become stable as well. Feel free to back-port the fix to a stable version of hplip and I will apply it.
