Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 427834 - dev-tex/luatex: please review prefix changes
Summary: dev-tex/luatex: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: TeX project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-07-24 02:54 UTC by Christoph Junghans (RETIRED)
Modified: 2012-07-25 00:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for luatex-0.70.1.ebuild (luatex-0.70.1.ebuild.patch,1.92 KB, patch)
2012-07-24 02:54 UTC, Christoph Junghans (RETIRED)
Details | Diff
patch for luatex-0.70.1.ebuild (luatex-0.70.1.ebuild.patch,1.97 KB, patch)
2012-07-24 14:58 UTC, Christoph Junghans (RETIRED)
Details | Diff
patch for luatex-0.70.1.ebuild (luatex-0.70.1.ebuild.patch,1.53 KB, text/plain)
2012-07-24 16:02 UTC, Christoph Junghans (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2012-07-24 02:54:19 UTC
Created attachment 319050 [details, diff]
patch for luatex-0.70.1.ebuild

EAPI bump, some trivial EPREFIX changes and some clean up.
Comment 1 Fabian Groffen gentoo-dev 2012-07-24 06:57:06 UTC
it currently doesn't build, I'd like to have that fixed before we push it back, since we don't know what that will change (although your bug #427814 hints it's trivial).
Comment 2 Alexis Ballier gentoo-dev 2012-07-24 12:34:30 UTC
--- luatex-0.70.1.ebuild.orig	2012-07-23 20:48:41.000000000 -0600
+++ luatex-0.70.1.ebuild	2012-07-23 20:49:27.000000000 -0600
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/dev-tex/luatex/luatex-0.70.1.ebuild,v 1.13 2012/07/09 13:15:20 aballier Exp $
 
-EAPI="2"
+EAPI=4
 
 inherit libtool eutils
 
-> ok

@@ -13,7 +13,7 @@
 
 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~amd64-fbsd ~x86-fbsd"
+KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~amd64-fbsd ~x86-fbsd ~x86-freebsd ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris"
 IUSE="doc"
 
 RDEPEND="dev-libs/zziplib
@@ -43,7 +43,6 @@
 
 	local myconf
 	myconf=""
-	#has_version '>=app-text/texlive-core-2009' && myconf="--with-system-kpathsea"
 
 	cd "${S}/texk/web2c"
 	econf \

-> ok

@@ -61,6 +60,7 @@
 		--without-mf-x-toolkit \
 		--without-x			\
 	    --with-system-kpathsea	\
+	    --with-kpathsea-includes="${EPREFIX}"/usr/include \
 	    --with-system-gd	\
 	    --with-system-libpng	\
 	    --with-system-teckit \

-> ok; maybe there exists a more global switch, but if it works for you as such

@@ -105,15 +105,9 @@
 }
 
 pkg_postinst() {
-	if ! has_version '>=dev-texlive/texlive-basic-2008' ; then
-		elog "Please note that this package does not install much files, mainly the"
-		elog "${PN} executable that will need other files in order to be useful.."
-		elog "Please consider installing a recent TeX distribution"
-		elog "like TeX Live 2008 to get the full power of ${PN}"
-	fi

-> wtf ? this message is here for a reason............


-	if [ "$ROOT" = "/" ] && [ -x /usr/bin/fmtutil-sys ] ; then
+	if [[ ${ROOT} = / && -x ${EPREFIX}/usr/bin/fmtutil-sys ]] ; then

-> use [ ] and proper quoting

-		/usr/bin/fmtutil-sys --all &> /dev/null
+		"${EPREFIX}"/usr/bin/fmtutil-sys --all &> /dev/null

-> ok
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2012-07-24 14:58:45 UTC
Created attachment 319088 [details, diff]
patch for luatex-0.70.1.ebuild

(In reply to comment #2)
> --- luatex-0.70.1.ebuild.orig	2012-07-23 20:48:41.000000000 -0600
> +++ luatex-0.70.1.ebuild	2012-07-23 20:49:27.000000000 -0600
...
> @@ -105,15 +105,9 @@
>  }
>  
>  pkg_postinst() {
> -	if ! has_version '>=dev-texlive/texlive-basic-2008' ; then
> -		elog "Please note that this package does not install much files, mainly
> the"
> -		elog "${PN} executable that will need other files in order to be useful.."
> -		elog "Please consider installing a recent TeX distribution"
> -		elog "like TeX Live 2008 to get the full power of ${PN}"
> -	fi
> 
> -> wtf ? this message is here for a reason............
My bad, I thought texlive-basic is pulled in as a dependency, which is not the case. Fixed.
> 
> 
> -	if [ "$ROOT" = "/" ] && [ -x /usr/bin/fmtutil-sys ] ; then
> +	if [[ ${ROOT} = / && -x ${EPREFIX}/usr/bin/fmtutil-sys ]] ; then
> 
> -> use [ ] and proper quoting
I tend to disagree, ebuilds are bash and [[ && ]] saves one subshell and in [[ ]] quotes are only needed for spaces outside of variables.
Comment 4 Fabian Groffen gentoo-dev 2012-07-24 15:00:56 UTC
I just synced and it seems to fix the compilation issue
Comment 5 Alexis Ballier gentoo-dev 2012-07-24 15:34:40 UTC
(In reply to comment #3)
> > 
> > 
> > -	if [ "$ROOT" = "/" ] && [ -x /usr/bin/fmtutil-sys ] ; then
> > +	if [[ ${ROOT} = / && -x ${EPREFIX}/usr/bin/fmtutil-sys ]] ; then
> > 
> > -> use [ ] and proper quoting
> I tend to disagree, ebuilds are bash and [[ && ]] saves one subshell and in
> [[ ]] quotes are only needed for spaces outside of variables.

you may disagree but that doesnt change the fact that i'll end up maintaining this, thus i get the right to chose the style.


PS: [ ] are builtins too...
Comment 6 Alexis Ballier gentoo-dev 2012-07-24 15:36:19 UTC
 pkg_postinst() {
-	if ! has_version '>=dev-texlive/texlive-basic-2008' ; then
+	if ! has_version 'dev-texlive/texlive-basic' ; then


-> the version requirement is here for a reason too...
Comment 7 Christoph Junghans (RETIRED) gentoo-dev 2012-07-24 16:02:28 UTC
Created attachment 319090 [details]
patch for luatex-0.70.1.ebuild

(In reply to comment #6)
>  pkg_postinst() {
> -	if ! has_version '>=dev-texlive/texlive-basic-2008' ; then
> +	if ! has_version 'dev-texlive/texlive-basic' ; then
> -> the version requirement is here for a reason too...
You have removed the 2008 version 8 months ago, but whatever.....

(In reply to comment #5)
> (In reply to comment #3)
> > > 
> > > 
> > > -	if [ "$ROOT" = "/" ] && [ -x /usr/bin/fmtutil-sys ] ; then
> > > +	if [[ ${ROOT} = / && -x ${EPREFIX}/usr/bin/fmtutil-sys ]] ; then
> > > 
> > > -> use [ ] and proper quoting
> > I tend to disagree, ebuilds are bash and [[ && ]] saves one subshell and in
> > [[ ]] quotes are only needed for spaces outside of variables.
> 
> you may disagree but that doesnt change the fact that i'll end up
> maintaining this, thus i get the right to chose the style.

I won't argue about style. Your wish is my order, master!
Comment 8 Alexis Ballier gentoo-dev 2012-07-24 16:09:11 UTC
(In reply to comment #7)
> Created attachment 319090 [details]
> patch for luatex-0.70.1.ebuild

this one is good, feel free to apply :)
Comment 9 Christoph Junghans (RETIRED) gentoo-dev 2012-07-25 00:37:32 UTC
Done.