Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 427170 - dev-db/redis-2.4.16 version bump
Summary: dev-db/redis-2.4.16 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on: 428722
Blocks:
  Show dependency tree
 
Reported: 2012-07-19 05:51 UTC by Johan Bergström
Modified: 2012-08-03 16:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bergström 2012-07-19 05:51:13 UTC
This bump requires us to jump to jemalloc 3.0.0. The following changes to the ebuild are needed (tested on amd64, x86):

--- /usr/portage/dev-db/redis/redis-2.4.14.ebuild	2012-06-04 17:01:06.000000000 +1000
+++ redis-2.4.15.ebuild	2012-07-19 15:50:05.140700633 +1000
@@ -18,7 +18,7 @@
 RDEPEND=""
 DEPEND=">=sys-devel/autoconf-2.63
 	tcmalloc? ( dev-util/google-perftools )
-	jemalloc? ( <dev-libs/jemalloc-3.0 )
+	jemalloc? ( >=dev-libs/jemalloc-3.0 )
 	test? ( dev-lang/tcl )
 	${RDEPEND}"
 REQUIRED_USE="tcmalloc? ( !jemalloc )
@@ -48,7 +48,7 @@
 	epatch "${FILESDIR}/redis-2.4.3-shared.patch"
 	epatch "${FILESDIR}/redis-2.4.4-tcmalloc.patch"
 	if use jemalloc ; then
-		sed -i -e "s/je_/j/" src/zmalloc.c
+		sed -i -e "s/je_/j/" src/zmalloc.c src/zmalloc.h
 	fi
 	# now we will rewrite present Makefiles
 	local makefiles=""
Comment 1 Johan Bergström 2012-08-02 11:59:16 UTC
New version:

* INFO command now shows slaves with the correct port number, assuming you
  use 2.4.16 or greater as slave as well. This makes Redis 2.4.16 compatible
  with Redis Sentinel. This fix required the introduction of a new internal
  command called REPLCONF, see commit b998ebe for more information.

Everything seems to work out fine. Lets do this.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-08-02 18:26:49 UTC
InCVS.
Comment 3 Harm Geerts 2012-08-03 12:46:46 UTC
USE=jemalloc redis-2.4.16 fails to build without the sed zmalloc.h change by Johan Bergström.

In addition the jemalloc dep should be increased to 3.0 as is noted in the changelog for 2.4.15

What's new in Redis 2.4.15
==========================

UPGRADE URGENCY: moderate if you use AOF, otherwise low.

* [BUGFIX] Jemalloc updated to 3.0.0. This fixes a possibly AOF rewrite issue.
           See https://github.com/antirez/redis/issues/504 for info.
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-08-03 16:48:25 UTC
InCVS.