Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 425342 - =media-libs/lensfun-0.2.6 with Prefix support
Summary: =media-libs/lensfun-0.2.6 with Prefix support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords: InVCS, PATCH
Depends on: 434086
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-07-08 15:56 UTC by Nicolas Pinto
Modified: 2012-09-21 16:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch (lensfun-0.2.5_p153-r2.ebuild.diff,667 bytes, patch)
2012-07-10 00:48 UTC, Nicolas Pinto
Details | Diff
patch for lensfun-0.2.6.ebuild (lensfun-0.2.6.ebuild.patch,734 bytes, patch)
2012-09-21 04:39 UTC, Christoph Junghans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Pinto 2012-07-08 15:56:13 UTC
"emerge =media-libs/lensfun-0.2.5_p153-r2" 

fails on Gentoo Prefix with:

 * QA Notice: the following files are outside of the prefix:
 * /usr
 * /usr/lib
 * /usr/lib/pkgconfig
 * /usr/lib/pkgconfig/lensfun.pc
 * ERROR: media-libs/lensfun-0.2.5_p153-r2 failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
 * 
 * Call stack:
 *   misc-functions.sh, line 1895:  Called install_qa_check
 *   misc-functions.sh, line  253:  Called install_qa_check_prefix
 *   misc-functions.sh, line  908:  Called die
 * The specific snippet of code:
 *                      die "Aborting due to QA concerns: there are files installed outside the prefix"
 * 
 * If you need support, post the output of 'emerge --info =media-libs/lensfun-0.2.5_p153-r2',
 * the complete build log and the output of 'emerge -pqv =media-libs/lensfun-0.2.5_p153-r2'.
 * This ebuild is from an overlay named 'sekyfsr': '/home/npinto/gentoo-prefix-bootstrap/mygentoo/sekyfsr-gentoo-overlay/'
 * The complete build log is located at '/home/npinto/gentoo/var/tmp/portage/media-libs/lensfun-0.2.5_p153-r2/temp/build.log'.
 * The ebuild environment file is located at '/home/npinto/gentoo/var/tmp/portage/media-libs/lensfun-0.2.5_p153-r2/temp/environment'.
 * Working directory: '/home/npinto/gentoo/var/tmp/portage/media-libs/lensfun-0.2.5_p153-r2/image'
 * S: '/home/npinto/gentoo/var/tmp/portage/media-libs/lensfun-0.2.5_p153-r2/work/lensfun-0.2.5_p153'
!!! post install failed; exiting.

The following patch fix the issue:

diff --git a/media-libs/lensfun/lensfun-0.2.5_p153-r2.ebuild b/media-libs/lensfun/lensfun-0.2.5_p153-r2.ebuild
index 67953d5..fd52f1d 100644
--- a/media-libs/lensfun/lensfun-0.2.5_p153-r2.ebuild
+++ b/media-libs/lensfun/lensfun-0.2.5_p153-r2.ebuild
@@ -32,8 +32,9 @@ pkg_setup() {
 src_configure() {
        mycmakeargs=(
                $(cmake-utils_use_build doc)
-               -DLIBDIR=$(get_libdir)
-               -DDOCDIR=/usr/share/doc/${P}
+               -DLIBDIR=${EPREFIX}/$(get_libdir)
+               -DDOCDIR=${EPREFIX}/usr/share/doc/${P}
+               -DCMAKE_INSTALL_LIBDIR=${EPREFIX}/${get_libdir}
        )
        cmake-utils_src_configure
 }


HTH
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-07-09 13:46:42 UTC
Please attach a patch. Also, include what keyword you tested. Thanks.
Comment 2 Nicolas Pinto 2012-07-10 00:48:58 UTC
Created attachment 317742 [details, diff]
patch
Comment 3 Nicolas Pinto 2012-07-10 00:49:25 UTC
Tested on ~amd64-linux.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-07-10 15:02:23 UTC
0.2.5_p153 is obsolete and shouldn't be used anymore in favour of 0.2.6
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-08-10 18:29:32 UTC
(In reply to comment #4)
> 0.2.5_p153 is obsolete and shouldn't be used anymore in favour of 0.2.6

The concept is the same, approve?
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2012-08-11 19:27:16 UTC
Comment on attachment 317742 [details, diff]
patch

- Missing "" quoting for ${EPREFIX}
- Using {} instead of () for get_libdir function, doesn't work
- After changing the {} to () it compiles but installs everything into / instead of /usr

So definate no-go for this patch, it wasn't even tested
Comment 7 Christoph Junghans (RETIRED) gentoo-dev 2012-09-13 17:08:48 UTC
(In reply to comment #6)
> Comment on attachment 317742 [details, diff] [details, diff]
> patch
> 
> - Missing "" quoting for ${EPREFIX}
> - Using {} instead of () for get_libdir function, doesn't work
> - After changing the {} to () it compiles but installs everything into /
> instead of /usr
> 
> So definate no-go for this patch, it wasn't even tested

The need to set CMAKE_INSTALL_LIBDIR is actually bug #434086, I will updated the patch as soon as this one is fixed.
Comment 8 Christoph Junghans (RETIRED) gentoo-dev 2012-09-21 04:39:02 UTC
Created attachment 324468 [details, diff]
patch for lensfun-0.2.6.ebuild

Only one trivial change left.
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2012-09-21 09:48:36 UTC
(In reply to comment #8)
> Created attachment 324468 [details, diff] [details, diff]
> patch for lensfun-0.2.6.ebuild
> 
> Only one trivial change left.

please apply it in tree (no revbump required)
Comment 10 Christoph Junghans (RETIRED) gentoo-dev 2012-09-21 16:19:35 UTC
Done, thanks.