Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 424563 - media-libs/libpgf-6.12.24 version bump (needed for future digikam 2.7)
Summary: media-libs/libpgf-6.12.24 version bump (needed for future digikam 2.7)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Graphics Project
URL: http://sourceforge.net/projects/libpg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-02 20:24 UTC by Francesco Riosa
Modified: 2012-07-09 20:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libpgf-6.12.24-fix-memory-stream.patch (libpgf-6.12.24-fix-memory-stream.patch,418 bytes, patch)
2012-07-06 13:18 UTC, Francesco Riosa
Details | Diff
libpgf-6.12.24.ebuild (libpgf-6.12.24.ebuild,978 bytes, text/plain)
2012-07-06 13:26 UTC, Francesco Riosa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Riosa 2012-07-02 20:24:39 UTC
as seen in https://plus.google.com/100127992760143250422/posts/9duBPpFL9ig
digikam has updated its internal copy of libpgf to 6.12.24, actually it (2.7) fail to build with the current stable libpgf-6.11.32.

Please notice that I've _not_ tested compatibility between newer libpgf and digikam 2.6, could do if requested.
Comment 1 Francesco Riosa 2012-07-02 22:37:38 UTC
As suspected there are problems between the new library and digikam 2.6 as confirmed by Gilles Caulier

WARNING... new libpgf 6.12.24 will not work with digiKam 2.6.0. There is a bug into libpgf. Look my patch here for digiKam core :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/91264c2a288d1a96d9235611e91278c7f27b1f75
Comment 2 Michael Palimaka (kensington) gentoo-dev 2012-07-03 12:26:26 UTC
CCing digikam maintainers in case they are not aware of this issue.
Comment 3 Francesco Riosa 2012-07-06 13:18:45 UTC
Created attachment 317426 [details, diff]
libpgf-6.12.24-fix-memory-stream.patch

modified patch, taken from:
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/11d6e550c8c47aa6faf506b2e4567d84ceaec838

Some of the changes were already included in the libpgf-6.12.24, so the patch is reduced. Or, like the version change .24 => .27 was not needed
Comment 4 Francesco Riosa 2012-07-06 13:26:24 UTC
Created attachment 317428 [details]
libpgf-6.12.24.ebuild

ebuild used, only differences are SRC_URI, and the addition of the patch.
it may be better to continue using a different source than "${PV}-latest/${P}-src.tar.gz", since this last one seem not stable (at least the -latest part)

I've not tested future digikam-2.7 yet but both stable 2.5 and ~2.6 work, showfoto can load and save pgf files and digikam can rebuild thumbnails of an album (which are pgf files stored in db)

inline the differences between the ebuilds

cheers,
Francesco


--- /g/portage/media-libs/libpgf/libpgf-6.11.32.ebuild  2011-12-07 23:09:18.000000000 +0100
+++ libpgf-6.12.24.ebuild       2012-07-06 13:38:18.261080600 +0200
@@ -3,11 +3,12 @@
 # $Header: /var/cvsroot/gentoo-x86/media-libs/libpgf/libpgf-6.11.32.ebuild,v 1.3 2011/12/07 22:09:18 hwoarang Exp $
 
 EAPI=4
-inherit autotools
+inherit eutils autotools
 
 DESCRIPTION="Library to load, handle and manipulate images in the PGF format"
 HOMEPAGE="http://www.libpgf.org/"
-SRC_URI="http://dev.gentoo.org/~dilfridge/distfiles/${P}.tar.bz2"
+#SRC_URI="http://dev.gentoo.org/~dilfridge/distfiles/${P}-src.tar.gz"
+SRC_URI="mirror://sourceforge/project/${PN}/${PN}/${PV}-latest/${P}-src.tar.gz"
 
 LICENSE="LGPL-2.1"
 SLOT="0"
@@ -25,6 +26,9 @@
                sed -i -e "/HAS_DOXYGEN/{N;N;d}" Makefile.am || die
        fi
 
+       epatch \
+               "${FILESDIR}"/${P}-fix-memory-stream.patch
+
        eautoreconf
 }
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2012-07-09 20:04:02 UTC
Thanks a lot for the detailed information! I bumped it straight to 6.12.27. :)