Bug 424503 – Please stabilize =app-emulation/free42-1.4.74

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Chema Alonso Josa (RETIRED) 2012-07-02 14:45:33 UTC]

For more than one month in the tree now. No bugs filed against it.

Please stabilize.

[Comment 1 Jeff (JD) Horelick (RETIRED) 2012-07-03 04:55:39 UTC]

x86 stable.

Although shouldn't this depend on x11-libs/gtk+:2 instead of just x11-libs/gtk+?

[Comment 2 Agostino Sarubbo 2012-07-03 13:45:01 UTC]

There is no presence of user CXXFLAGS, and you should drop -g:

x86_64-pc-linux-gnu-g++ -MMD -Wall -g -I/usr/X11R6/include -fno-exceptions -fno-rtti -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm   -DVERSION="\"1.4.74\"" -c -o core_phloat.o core_phloat.cc

and in the final link there isn't -O1 and --as-needed:


x86_64-pc-linux-gnu-g++ -o free42bin -L/usr/X11R6/lib -Wl,--hash-style=gnu shell_main.o shell_skin.o skins.o keymap.o shell_loadimage.o shell_spool.o core_main.o core_commands1.o core_commands2.o core_commands3.o core_commands4.o core_commands5.o core_commands6.o core_commands7.o core_display.o core_globals.o core_helpers.o core_keydown.o core_linalg1.o core_linalg2.o core_math1.o core_math2.o core_phloat.o core_sto_rcl.o core_tables.o core_variables.o -lXmu -pthread -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0  



Please also convert src_compile to emake.

[Comment 3 Chema Alonso Josa (RETIRED) 2012-07-04 17:38:22 UTC]

I think this fixes the issues reported. Thanks.

+  04 Jul 2012; Chema Alonso <[e-mail]> free42-1.4.74.ebuild:
+  Bug #424503: Depend on x11-libs/gtk+:2. Add user CXXFLAGS. Drop -g flag.
+  Add -O1 and --as-needed linker flags. Use emake in src_compile.
+

[Comment 4 Agostino Sarubbo 2012-07-04 18:38:17 UTC]

(In reply to comment #3)
> I think this fixes the issues reported. Thanks.
> 
> +  04 Jul 2012; Chema Alonso <[e-mail]> free42-1.4.74.ebuild:
> +  Bug #424503: Depend on x11-libs/gtk+:2. Add user CXXFLAGS. Drop -g flag.
> +  Add -O1 and --as-needed linker flags. Use emake in src_compile.
> +

Not at all.


The ebuild should respect LDFLAGS variable.

[Comment 5 Chema Alonso Josa (RETIRED) 2012-07-05 10:03:14 UTC]

Sorry about that. LDFLAGS fixed.

+  05 Jul 2012; Chema Alonso <[e-mail]> free42-1.4.74.ebuild:
+  Respect LDFLAGS wrt bug #424503.
+

[Comment 6 Agostino Sarubbo 2012-07-05 12:31:44 UTC]

amd64 stable. Last arch, closing

[Comment 7 Agostino Sarubbo 2012-07-05 13:03:43 UTC]

(In reply to comment #5)
> Sorry about that. LDFLAGS fixed.
> 
> +  05 Jul 2012; Chema Alonso <[e-mail]> free42-1.4.74.ebuild:
> +  Respect LDFLAGS wrt bug #424503.
> +

You need also to delete the line about --hash-style:

's/-Wl,--hash-style=both/-Wl,--hash-style=gnu/'

[Comment 8 Chema Alonso Josa (RETIRED) 2012-07-05 16:06:37 UTC]

Done, thanks.

+  05 Jul 2012; Chema Alonso <[e-mail]> free42-1.4.74.ebuild:
+  Remove --hash-style=both wrt bug #424503 comment #7.
+