424355 – kde-base/kdelibs: dangling pointer in KIO::AccessManager

Bug 424355 - kde-base/kdelibs: dangling pointer in KIO::AccessManager

Summary: kde-base/kdelibs: dangling pointer in KIO::AccessManager

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] KDE (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo KDE team

URL:	http://quickgit.kde.org/index.php?p=k...
Whiteboard:	Fixed in 4.9.0
Keywords:

Depends on:
Blocks:

Reported:	2012-07-01 10:51 UTC by Franz Trischberger
Modified:	2012-07-05 19:57 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Replace the plain pointer by QPointer (accessmanager_window_dangling_pointer.patch,722 bytes, text/plain) 2012-07-01 10:51 UTC, Franz Trischberger	Details
Patch committed upstream (fix_kio_accessmanager_crashes.patch,1004 bytes, patch) 2012-07-02 06:31 UTC, Franz Trischberger	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Franz Trischberger 2012-07-01 10:51:13 UTC

Created attachment 316847 [details]
Replace the plain pointer by QPointer

rekonq revealed this problem:
https://bugs.kde.org/show_bug.cgi?id=282052
Andrea Diamantini fixed it with a workaround in rekonq. The proper fix is in kdelibs, see the attached patch.
Upstream knows about the problem, hopefully the patch will get committed today (adawit@kde.org gave his OK)

Comment 1 Michael Palimaka (kensington) gentoo-dev

2012-07-01 17:00:44 UTC

Nice spot!

Looks like upstream has committed it now, so hopefully we'll see it in rc2.

Comment 2 Franz Trischberger 2012-07-01 20:15:21 UTC

> Looks like upstream has committed it now.

No, that's another dangling pointer in KToolbar ;) This one is about KIO::AccessManager.

Comment 3 Franz Trischberger 2012-07-02 06:31:10 UTC

Created attachment 316945 [details, diff]
Patch committed upstream

Upstream committed it, kdelibs-4.9-rc2 is fine :)

http://quickgit.kde.org/index.php?p=kdelibs.git&a=commit&h=e4c73e47a52cde8f5f73a00b60a8ae10fd2d1a4d

Should apply fine to kdelibs-4.8.3, too.

Comment 4 Franz Trischberger 2012-07-05 07:59:19 UTC

Could we get this patch applied to at least kde-4.8.*. Those will stay stable for a while (4.9.0 and possibly 4.9.1, too are no stable candidates), leaving a potential cause for crashes if not patched.
rekonq is not the only application that can crash, it just was able to reproduce it with certain websites. Windows can be destroyed at any time. If there is a reply with this window as parent it will crash.

Comment 5 Andreas K. Hüttel archtester

2012-07-05 19:57:07 UTC

In 4.8.4-r1 - thanks!