Bug 424171 – =app-i18n/enca-1.13-r2: is not multilib aware

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anthony Basile 2012-06-29 22:01:01 UTC]

I hit this on a mips64el system (the lemote yeeloong) but it probably affects all multilib systems.  The problem is in the configure.ac file, at lines 102 and 105 where

    LDFLAGS="$LDFLAGS -L$ac_default_prefix/lib"

    LDFLAGS="$LDFLAGS -L$prefix/lib"

The comment previous says it all: "dnl Dirty path hack."  I'm not sure the hack is needed at all in gentoo since our paths are very sane and I was able to get it to build without it.  

Note: if we are to keep it, then we need to sed "lib" with $(get_libdir), but I really don't think that's the way to go.

[Comment 1 Anthony Basile 2012-06-29 22:06:37 UTC]

Created attachment 316651 [details, diff]
enca-remove-dirty-path-hack.patch

[Comment 2 Anthony Basile 2012-06-29 22:13:08 UTC]

Created attachment 316653 [details, diff]
Patch against enca-1.13-r2

I would apply the above patch and revbump.

[Comment 3 Anthony Basile 2012-06-29 22:57:21 UTC]

Created attachment 316655 [details, diff]
Patch against enca-1.13-r2.ebuild

[Comment 4 Anthony Basile 2012-06-29 23:00:42 UTC]

(In reply to comment #2)
> Created attachment 316653 [details, diff] [details, diff]
> Patch against enca-1.13-r2
> 
> I would apply the above patch and revbump.

Please consider the patch in comment #2 as obsoleted by the one in comment #3.  I forgot to mark it so when uploading.

[Comment 5 Maxim Koltsov (RETIRED) 2012-07-01 11:09:46 UTC]

(In reply to comment #4)
> (In reply to comment #2)
> > Created attachment 316653 [details, diff] [details, diff] [details, diff]
> > Patch against enca-1.13-r2
> > 
> > I would apply the above patch and revbump.
> 
> Please consider the patch in comment #2 as obsoleted by the one in comment
> #3.  I forgot to mark it so when uploading.

You must set AUTOTOOLS_AUTORECONF at global scope of the ebuild, because eclass uses it to inject dependencies too, not only to run eautoreconf. Also it does not matter what walue it has: 
# @ECLASS-VARIABLE: AUTOTOOLS_AUTORECONF                                        
# @DEFAULT_UNSET                                                                
# @DESCRIPTION:                                                                 
# Set to a non-empty value in order to enable running autoreconf                
# in src_prepare() and adding autotools dependencies.  
When you fix this, you can commit and close the bug.

[Comment 6 Anthony Basile 2012-07-01 12:20:26 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Created attachment 316653 [details, diff] [details, diff] [details, diff] [details, diff]
> > > Patch against enca-1.13-r2
> > > 
> > > I would apply the above patch and revbump.
> > 
> > Please consider the patch in comment #2 as obsoleted by the one in comment
> > #3.  I forgot to mark it so when uploading.
> 
> You must set AUTOTOOLS_AUTORECONF at global scope of the ebuild, because
> eclass uses it to inject dependencies too, not only to run eautoreconf. Also
> it does not matter what walue it has: 
> # @ECLASS-VARIABLE: AUTOTOOLS_AUTORECONF                                    
> 
> # @DEFAULT_UNSET                                                            
> 
> # @DESCRIPTION:                                                             
> 
> # Set to a non-empty value in order to enable running autoreconf            
> 
> # in src_prepare() and adding autotools dependencies.  
> When you fix this, you can commit and close the bug.

Okay thanks for noting that.