Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423865 - dev-python/requests-0.13.1 version bump request
Summary: dev-python/requests-0.13.1 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 18:58 UTC by Ian Delaney (RETIRED)
Modified: 2012-07-17 19:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2012-06-27 18:58:13 UTC
Once deps emerged;

archtester requests # USE_PYTHON="2.7 3.2 2.7-pypy-1.8 2.7-pypy-1.9" ebuild requests-0.13.1.ebuild clean test

 * Testing of dev-python/requests-0.13.1 with CPython 2.7...
PYTHONPATH=build-2.7/lib nosetests --verbosity=1
...........
----------------------------------------------------------------------
Ran 11 tests in 18.907s

OK
 * Testing of dev-python/requests-0.13.1 with CPython 3.2...
PYTHONPATH=build-3.2/lib nosetests --verbosity=1
...........
----------------------------------------------------------------------
Ran 11 tests in 18.534s

OK
 * Testing of dev-python/requests-0.13.1 with PyPy 1.8 (Python 2.7)...
PYTHONPATH=build-2.7-pypy-1.8/lib nosetests --verbosity=1
...........
----------------------------------------------------------------------
Ran 11 tests in 18.219s

OK
 * Testing of dev-python/requests-0.13.1 with PyPy 1.9 (Python 2.7)...
PYTHONPATH=build-2.7-pypy-1.9/lib nosetests --verbosity=1
...........
----------------------------------------------------------------------
Ran 11 tests in 17.854s

OK

archtester requests # USE_PYTHON="2.6" ebuild requests-0.13.1.ebuild clean test
 * Testing of dev-python/requests-0.13.1 with CPython 2.6...

PYTHONPATH=build-2.6/lib nosetests --verbosity=1
...E.......
======================================================================
ERROR: Test interaction between cookie handling and redirection.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/gen2/TmpDir/portage/dev-python/requests-0.13.1/work/requests-0.13.1/tests/test_requests_ext.py", line 113, in test_cookies_on_redirects
    self.assertIn('preview', s.cookies)
AttributeError: 'RequestsTestSuite' object has no attribute 'assertIn'
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): tinyurl.com
requests.packages.urllib3.connectionpool: DEBUG: "GET /preview.php?disable=1 ('HTTP/1.1',)" 200 None
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 11 tests in 17.448s

FAILED (errors=1)
 * ERROR: dev-python/requests-0.13.1 failed (test phase):
 *   Testing failed with CPython 2.6 in python_test_function() function

The whole src_prepare content can be deleted from 0.12.1-r1; 
the test output is the same with or without it.

So; in 
PYTHON_DEPEND="*:2.6"
RESTRICT_PYTHON_ABIS="2.4 2.5"

bearing in mind python2.6 fails with a

AttributeError: 'RequestsTestSuite' object has no attribute 'assertIn

which appears a unittest feature shortcoming, so if I were to cast a vote, it warrants neither changing *:2.6 to *:2.7 nor PYTHON_TESTS_RESTRICTED_ABIS="2.6".
I would though vote for a 
RESTRICT_PYTHON_ABIS="2.5"
Comment 1 Michael Palimaka (kensington) gentoo-dev 2012-07-17 19:31:41 UTC
I have bumped 0.13.1 with permission from the Python team.

As pointed out on IRC, there are a couple of newer minor version releases available, however I experienced some issues so opted to stick with this version instead.

+*requests-0.13.1 (17 Jul 2012)
+
+  17 Jul 2012; Michael Palimaka <kensington@gentoo.org> +requests-0.13.1.ebuild:
+  Version bump, wrt bug #423865.