Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 423017 - >=media-video/vlc-2* has useless ffmpeg USE flag since it sets no configure options
Summary: >=media-video/vlc-2* has useless ffmpeg USE flag since it sets no configure o...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-22 22:51 UTC by Hans
Modified: 2012-06-30 20:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hans 2012-06-22 22:51:41 UTC
Currently, in all ebuilds of media-video/vlc-2* (and -9999), we have "+ffmpeg" in IUSE. And yet, the ebuilds do absolutely nothing useful with it.

In REQUIRED_USE, we have:
        avcodec? ( ffmpeg )
        avformat? ( ffmpeg )
        swscale? ( ffmpeg )
which is not needed, as those USE flags have DEPEND lines for themselves (depending on virtual/ffmpeg) and they have their "use_enable" lines logically separate from setting USE=ffmpeg as well.

Other than that, ffmpeg is not even mentioned anywhere in the ebuilds (except for postproc, which is a different matter).

So I propose to remove this USE flag as well as the above-mentioned REQUIRED_USE lines.

Though I don't know whether avcodec / avformat / swscale have some kind of interdependencies.

Thanks for your work!
Comment 1 Alexis Ballier gentoo-dev 2012-06-26 14:59:21 UTC
hu, i suppose i was in need of coffee when i changed this.

what i meant was having ffmpeg? ( avcodec avformat swscale ) in required_use, to match 'standard' behavior of ffmpeg useflag but letting people who know what they are doing disable parts of it.

will fix
Comment 2 Alexis Ballier gentoo-dev 2012-06-30 20:11:45 UTC
fixed