Bug 421015 – net-misc/batman-adv-2012.2.0 version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Antonio Quartulli 2012-06-13 18:17:36 UTC]

net-misc/batman-adv-2012.2.0 is available

I'm not attaching any ebuild because it is possible to use the old one with a new name

Reproducible: Always

[Comment 1 Franz Schrober 2012-06-13 18:27:25 UTC]

No, there is a new compile option for bridge loop avoidance (something like stp but with multiple active paths) called CONFIG_BATMAN_ADV_BLA

[Comment 2 Antonio Quartulli 2012-06-13 18:27:55 UTC]

Created attachment 315223 [details]
new ebuild

I added a new ebuild because in batman-adv now we have the Bridge Loop Avoidance (bla) that can be enabled/disabled at compile time.
In this ebuild I added the bla flag.

[Comment 3 Antonio Quartulli 2012-06-13 18:28:24 UTC]

(In reply to comment #1)
> No, there is a new compile option for bridge loop avoidance (something like
> stp but with multiple active paths) called CONFIG_BATMAN_ADV_BLA

Yes, I forgot about that. Sorry.
I added a new ebuild

[Comment 4 Michael Weber (RETIRED) 2012-06-13 22:08:33 UTC]

Please correct me, but the second export BUILD_PARAMS overwrites the first?

But I got the idea.

[Comment 5 Michael Weber (RETIRED) 2012-06-13 22:21:27 UTC]

+*batman-adv-2012.2.0 (13 Jun 2012)
+
+  13 Jun 2012; Michael Weber <[e-mail]> +batman-adv-2012.2.0.ebuild,
+  metadata.xml:
+  Version bump (bug 421015 by Antonio Quartulli and Franz Schrober)
+

thanks

[Comment 6 Antonio Quartulli 2012-06-14 06:43:35 UTC]

(In reply to comment #4)
> Please correct me, but the second export BUILD_PARAMS overwrites the first?
> 
> But I got the idea.

No, it does not. They are independent from this point of view.

[Comment 7 Michael Weber (RETIRED) 2012-06-14 08:02:22 UTC]

(In reply to comment #6)
> No, it does not. They are independent from this point of view.

in case of USE="debug bla", both export statements got evaluated and the second sets the BUILD_PARAMS to just CONFIG_BATMAN_ADV_BLA=y.
The CONFIG_BATMAN_ADV_DEBUG=y is lost.

michael@x ~ $ export BUILD_PARAMS="CONFIG_BATMAN_ADV_DEBUG=y"
michael@x ~ $ export BUILD_PARAMS="CONFIG_BATMAN_ADV_BLA=y"
michael@x ~ $ echo $BUILD_PARAMS
CONFIG_BATMAN_ADV_BLA=y

And I end up with build.log containing
make -j2 HOSTCC=x86_64-pc-linux-gnu-gcc CROSS_COMPILE=x86_64-pc-linux-gnu- 'LDFLAGS=-m elf_x86_64' CONFIG_BATMAN_ADV_BLA=y all


I used following lines

    BUILD_PARAMS="CONFIG_BATMAN_ADV_DEBUG=$(use debug && echo y || echo n)"
    BUILD_PARAMS+=" CONFIG_BATMAN_ADV_BLA=$(use bla && echo y || echo n)"
    export BUILD_PARAMS

[Comment 8 Antonio Quartulli 2012-06-14 08:12:56 UTC]

(In reply to comment #7)
> (In reply to comment #6)
> > No, it does not. They are independent from this point of view.
> 
> in case of USE="debug bla", both export statements got evaluated and the
> second sets the BUILD_PARAMS to just CONFIG_BATMAN_ADV_BLA=y.
> The CONFIG_BATMAN_ADV_DEBUG=y is lost.
> 

Oh sorry. I got it.

> michael@x ~ $ export BUILD_PARAMS="CONFIG_BATMAN_ADV_DEBUG=y"
> michael@x ~ $ export BUILD_PARAMS="CONFIG_BATMAN_ADV_BLA=y"
> michael@x ~ $ echo $BUILD_PARAMS
> CONFIG_BATMAN_ADV_BLA=y
> 
> And I end up with build.log containing
> make -j2 HOSTCC=x86_64-pc-linux-gnu-gcc CROSS_COMPILE=x86_64-pc-linux-gnu-
> 'LDFLAGS=-m elf_x86_64' CONFIG_BATMAN_ADV_BLA=y all
> 
> 
> I used following lines
> 
>     BUILD_PARAMS="CONFIG_BATMAN_ADV_DEBUG=$(use debug && echo y || echo n)"
>     BUILD_PARAMS+=" CONFIG_BATMAN_ADV_BLA=$(use bla && echo y || echo n)"
>     export BUILD_PARAMS


Sounds good :) Thank you!