Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 420117 - app-office/lyx-2.0.3 does not build do to doicon change
Summary: app-office/lyx-2.0.3 does not build do to doicon change
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: TeX project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 14:11 UTC by Richard Freeman
Modified: 2012-06-08 15:06 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (build.log,117.41 KB, text/plain)
2012-06-07 14:12 UTC, Richard Freeman
Details
Environment (build.env,203.16 KB, text/plain)
2012-06-07 14:12 UTC, Richard Freeman
Details
emerge --info (einfo.txt,7.60 KB, text/plain)
2012-06-07 14:13 UTC, Richard Freeman
Details
emerge -p (epretend.txt,328 bytes, text/plain)
2012-06-07 14:13 UTC, Richard Freeman
Details
patch (patch.txt,608 bytes, patch)
2012-06-07 15:13 UTC, Richard Freeman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Freeman gentoo-dev 2012-06-07 14:11:23 UTC
Based on irc conversation with hasufell the use of doicon and make_desktop_entry are not quite correct in the ebuild, and the failure is the result of more error checking.

<hasufell> rich0: it should be fixed like this: "newicon -s 32 "$S/development/Win32/packaging/icons/lyx_32x32.png" ${PN}.png"
<hasufell> make_desktop_entry ${PN} "LyX" "${PN}.png" "Office" "MimeType=application/x-lyx;"
<hasufell> and use gnome2-utils to update icon cache on top of that

Details on error itself:

 * lyx is not a valid file/directory!
 * ERROR: app-office/lyx-2.0.3 failed (install phase):
 *   (no error message)
 *
 * Call stack:
 *     ebuild.sh, line   85:  Called src_install
 *   environment, line 5374:  Called doicon 'lyx' '/var/tmp/portage/app-office/lyx-2.0.3/work/lyx-2.0.3/development/Win32/packaging/icons/lyx_32x32.png'
 *   environment, line 1316:  Called _iconins 'doicon' 'lyx' '/var/tmp/portage/app-office/lyx-2.0.3/work/lyx-2.0.3/development/Win32/packaging/icons/lyx_32x32.png'
 *   environment, line  561:  Called die
 * The specific snippet of code:
 *       fi ) || die

Logs/etc will be attached...
Comment 1 Richard Freeman gentoo-dev 2012-06-07 14:12:01 UTC
Created attachment 314581 [details]
Build log
Comment 2 Richard Freeman gentoo-dev 2012-06-07 14:12:19 UTC
Created attachment 314583 [details]
Environment
Comment 3 Richard Freeman gentoo-dev 2012-06-07 14:13:01 UTC
Created attachment 314585 [details]
emerge --info
Comment 4 Richard Freeman gentoo-dev 2012-06-07 14:13:16 UTC
Created attachment 314587 [details]
emerge -p
Comment 5 Julian Ospald 2012-06-07 14:15:04 UTC
make_desktop_entry ${PN} "LyX" "${PN}" "Office" "MimeType=application/x-lyx;"

(without the .png) :)
Comment 6 Julian Ospald 2012-06-07 14:17:46 UTC
Also, consider to update the icon cache via gnome2-utils eclass when installing into /usr/share/icons (via the "-s" switch).

However, the default behavior for doicon/newicon has not changed except the new error handling.
Comment 7 pavel sanda 2012-06-07 14:34:50 UTC
> newicon -s 32 "$S/development/Win32/packaging/icons/lyx_32x32.png" ${PN}.png
> make_desktop_entry ${PN} "LyX" "${PN}" "Office" "MimeType=application/x-lyx;"

you clearly know better than me, so feel free to commit this change to the ebuild
(otherwise it will take some time to process this with usual ping pong with alexis...)
Comment 8 Richard Freeman gentoo-dev 2012-06-07 15:07:30 UTC
FYI - I tested exactly those changes and they appear to work fine (at least on KDE).

Not sure I'd be personally comfortable with committing them without reading up on eutils a bit more - I don't deal with many packages that actually supply icons.
Comment 9 pavel sanda 2012-06-07 15:11:00 UTC
ok. it would help if you attach patch which works for you. thanks.
Comment 10 Richard Freeman gentoo-dev 2012-06-07 15:13:52 UTC
Created attachment 314595 [details, diff]
patch

Patch attached - works for me.
Comment 11 pavel sanda 2012-06-07 23:55:11 UTC
2.0.4 should be out in a few weeks and i will put it in there.
Comment 12 Richard Freeman gentoo-dev 2012-06-08 00:17:25 UTC
(In reply to comment #11)
> 2.0.4 should be out in a few weeks and i will put it in there.

Just keep in mind that the current stable version on most archs is broken, and will remain broken until 2.0.4 is stabilized if you go that route.  That basically means that it won't build for around two months...
Comment 13 Jaak Ristioja 2012-06-08 09:52:03 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > 2.0.4 should be out in a few weeks and i will put it in there.
> 
> Just keep in mind that the current stable version on most archs is broken,
> and will remain broken until 2.0.4 is stabilized if you go that route.  That
> basically means that it won't build for around two months...

Yeah! I just hit this due to a boost upgrade (1.48.0-r2 was stabilized, emerged, old versions removed, revdep-rebuild wants but fails to rebuild lyx) and Lyx is currently broken on my machine... So I'd expect more users to be =[ unless this is fixed very soon. Please fix this.
Comment 14 pavel sanda 2012-06-08 11:25:00 UTC
Ok.
Comment 15 Alexis Ballier gentoo-dev 2012-06-08 15:06:45 UTC
applied, thanks