Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 419901 - dev-db/mysql-workbench should depend on gnome-base/libgnome-keyring
Summary: dev-db/mysql-workbench should depend on gnome-base/libgnome-keyring
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Hans de Graaff
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 11:46 UTC by Niko Böckerman
Modified: 2012-06-09 08:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Niko Böckerman 2012-06-06 11:46:23 UTC
I have installed mysql-workbench-5.2.40 and I don't have gnome-keyring installed. Mysql-workbench offers the option to save passwords when connecting to databases, but doesn't actually remember those.

And when started from commandline the following warning is displayed:
$ mysql-workbench
** Message: Gnome keyring daemon seems to not be available. Stored passwords will be lost once quit

The configure.in file contains this section:
PKG_CHECK_MODULES(GNOME_KEYRING, [gnome-keyring], 
                  [PKG_CHECK_EXISTS([gnome-keyring < 1.0.0], 
                                    [AC_DEFINE_UNQUOTED(HAVE_OLD_GNOME_KEYRING, 1, "")], 
                                    [AC_DEFINE_UNQUOTED(HAVE_GNOME_KEYRING, 1, "")]
                                   )
                  ],
                  [PKG_CHECK_MODULES(GNOME_KEYRING, 
                                     [gnome-keyring-1],
                                     [PKG_CHECK_EXISTS([gnome-keyring-1 < 1.0.0], 
                                                                       [AC_DEFINE_UNQUOTED(HAVE_OLD_GNOME_KEYRING, 1, "")], 
                                                                       [AC_DEFINE_UNQUOTED(HAVE_GNOME_KEYRING, 1, "")]
                                                      )
                                     ],
                                     [GNOME_KEYRING_CFLAGS=""
                                      GNOME_KEYRING_LIBS=""
                                     ]
                                    )
                  ]
                 )
AC_SUBST(GNOME_KEYRING_CFLAGS)
AC_SUBST(GNOME_KEYRING_LIBS)


Therefore it seems to me that mysql-workbench should depend on gnome-keyring in order to enable the saving of passwords. It should probably be an optional dependency behind a use flag but at least it should be a dependency of some sort to have the functionality of saving passwords.
Comment 1 Niko Böckerman 2012-06-06 12:06:04 UTC
The package to depend on should probably be libgnome-keyring instead of gnome-keyring.
Comment 2 Hans de Graaff gentoo-dev Security 2012-06-09 08:03:16 UTC
(In reply to comment #1)
> The package to depend on should probably be libgnome-keyring instead of
> gnome-keyring.

I've added a dependency on libgnome-keyring with USE=gnome-keyring in mysql-workbench-5.2.40. Thanks for the report.