Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 419531 - net-misc/rabbitmq-server rabbitmq.service remove extra su calling
Summary: net-misc/rabbitmq-server rabbitmq.service remove extra su calling
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ultrabug
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-03 20:12 UTC by Maksim 'max_posedon' Melnikau
Modified: 2012-09-03 16:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
rabbitmq.service patch (rabbitmq.service.patch,424 bytes, patch)
2012-06-03 20:18 UTC, Maksim 'max_posedon' Melnikau
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maksim 'max_posedon' Melnikau 2012-06-03 20:12:53 UTC
Calling /usr/sbin/rabbitmq-server useless step in starting rabbitmq with systemd.
Systemd has his own way to change user, group, working directory.
CMDLINE also unused.

So, I propose fix, which removes this step (also removes "strange" su calls).

Reproducible: Always

Steps to Reproduce:
1. systemctl start rabbitmq.service
2. sleep 5
3. systemctl stop rabbitmq.service
4. systemctl status rabbitmq.service -n 100

(Not any su expected)
Actual Results:  
03 22:44:58 localhost su[10769]: Successful su for rabbitmq by root
Jun 03 22:44:58 localhost su[10769]: + ??? root:rabbitmq
Jun 03 22:44:58 localhost su[10769]: pam_unix(su:session): session opened for user rabbitmq by (uid=0)
Jun 03 22:44:59 localhost rabbitmq-server[10766]: Activating RabbitMQ plugins ...
Jun 03 22:45:01 localhost rabbitmq-server[10766]: broker running
..........
Jun 03 22:46:55 localhost su[10899]: Successful su for rabbitmq by root
Jun 03 22:46:55 localhost su[10899]: + ??? root:rabbitmq
Jun 03 22:46:55 localhost su[10899]: pam_unix(su:session): session opened for user rabbitmq by (uid=0)
Jun 03 22:46:56 localhost rabbitmqctl[10892]: Stopping and halting node rabbit@localhost ...

Expected Results:  
localhost max_posedon # systemctl status rabbitmq.service -n 1000  
rabbitmq.service - RabbitMQ daemon
          Loaded: loaded (/usr/lib64/systemd/system/rabbitmq.service; enabled)
          Active: inactive (dead) since Sun, 03 Jun 2012 22:55:30 +0300; 15min ago
         Process: 19114 ExecStop=/usr/libexec/rabbitmq/rabbitmqctl stop (code=exited, status=0/SUCCESS)
         Process: 19032 ExecStart=/usr/libexec/rabbitmq/rabbitmq-server (code=killed, signal=TERM)
          CGroup: name=systemd:/system/rabbitmq.service

Jun 03 22:55:06 localhost rabbitmq-server[19032]: Activating RabbitMQ plugins ...
Jun 03 22:55:07 localhost rabbitmq-server[19032]: 0 plugins activated:
Jun 03 22:55:08 localhost rabbitmq-server[19032]: +---+   +---+
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |   |   |   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |   |   |   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |   |   |   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |   +---+   +-------+
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |                   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: | RabbitMQ  +---+   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |           |   |   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |   v2.8.1  +---+   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: |                   |
Jun 03 22:55:08 localhost rabbitmq-server[19032]: +-------------------+
Jun 03 22:55:08 localhost rabbitmq-server[19032]: AMQP 0-9-1 / 0-9 / 0-8
Jun 03 22:55:08 localhost rabbitmq-server[19032]: Copyright (C) 2007-2012 VMware, Inc.
Jun 03 22:55:08 localhost rabbitmq-server[19032]: Licensed under the MPL.  See http://www.rabbitmq.com/
Jun 03 22:55:08 localhost rabbitmq-server[19032]: node           : rabbit@localhost
Jun 03 22:55:08 localhost rabbitmq-server[19032]: app descriptor : /usr/lib64/rabbitmq/ebin/rabbit.app
Jun 03 22:55:08 localhost rabbitmq-server[19032]: home dir       : /var/lib/rabbitmq
Jun 03 22:55:08 localhost rabbitmq-server[19032]: config file(s) : (none)
Jun 03 22:55:08 localhost rabbitmq-server[19032]: cookie hash    : kyI4LdGBxBkon0Mdfi4kQA==
Jun 03 22:55:08 localhost rabbitmq-server[19032]: log            : /var/log/rabbitmq/rabbit@localhost.log
Jun 03 22:55:08 localhost rabbitmq-server[19032]: sasl log       : /var/log/rabbitmq/rabbit@localhost-sasl.log
Jun 03 22:55:08 localhost rabbitmq-server[19032]: database dir   : /var/lib/rabbitmq/mnesia/rabbit@localhost
Jun 03 22:55:08 localhost rabbitmq-server[19032]: erlang version : 5.9.1
Jun 03 22:55:08 localhost rabbitmq-server[19032]: -- rabbit boot start
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting file handle cache server                                     ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting worker pool                                                  ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting database                                                     ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting database sync                                                ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting codec correctness check                                      ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: -- external infrastructure ready
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting plugin registry                                              ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting auth mechanism cr-demo                                       ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting auth mechanism amqplain                                      ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting auth mechanism plain                                         ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting statistics event manager                                     ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting logging server                                               ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting exchange type direct                                         ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting exchange type fanout                                         ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting exchange type headers                                        ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting exchange type topic                                          ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: -- kernel ready
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting alarm handler                                                ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting node monitor                                                 ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting cluster delegate                                             ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting guid generator                                               ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting memory monitor                                               ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: -- core initialized
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting empty DB check                                               ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting exchange, queue and binding recovery                         ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting mirror queue slave sup                                       ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting adding mirrors to queues                                     ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: -- message delivery logic ready
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting error log relay                                              ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting networking                                                   ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting direct client                                                ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: starting notify cluster nodes                                         ...done
Jun 03 22:55:08 localhost rabbitmq-server[19032]: broker running
Jun 03 22:55:29 localhost rabbitmqctl[19114]: Stopping and halting node rabbit@localhost ...
Jun 03 22:55:30 localhost rabbitmqctl[19114]: ...done.


localhost max_posedon # emerge --info 
Portage 2.1.10.63 (default/linux/amd64/10.0/desktop/kde, gcc-4.6.3, glibc-2.15-r2, 3.4.0-gentoo x86_64)
=================================================================
System uname: Linux-3.4.0-gentoo-x86_64-Intel-R-_Core-TM-_i7-2617M_CPU_@_1.50GHz-with-gentoo-2.1
Timestamp of tree: Sun, 03 Jun 2012 14:00:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          4.2_p28
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.6.7-r2, 2.7.3-r2, 3.1.4-r3, 3.2.3-r1
dev-util/cmake:           2.8.8-r2
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10.2
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.5
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.6.3
sys-devel/gcc-config:     1.7.1
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4 (virtual/os-headers)
sys-libs/glibc:           2.15-r2
Repositories: gentoo systemd qt enlightenment x-openstack sunrise local
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=corei7 -Os -g -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /usr/share/themes/oxygen-gtk/gtk-2.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=corei7 -Os -g -pipe"
DISTDIR="/home/gentoo/distfiles"
FEATURES="assume-digests binpkg-logs compressdebug config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en ru"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/systemd /var/lib/layman/qt /var/lib/layman/enlightenment /var/lib/layman/openstack /var/lib/layman/sunrise /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac aalib acpi alsa amd64 avahi berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups curl cxx dbus declarative djvu dri dts dv dvd dvdr emboss encode exif fam ffmpeg firefox flac ftp gdbm gif gnutls gpm gps gsm gstreamer iconv icu imagemagick ios ipod ipv6 jingle jpeg jpeg2k kde kipi lame latex lcms ldap libcaca libnotify lm_sensors lzma lzo mad mmx mng modules mp3 mp4 mpeg mplayer mtp mudflap multilib musicbrainz ncurses netboot networkmanager nls nptl ogg openal opengl openmp oscar pam pango pcre pdf phonon plasma png policykit portaudio postgres ppds pppd pulseaudio qt3support qt4 rdesktop readline ruby samba sdl semantic-desktop session smp speex spell sqlite sqlite3 sse sse2 ssl startup-notification subversion svg systemd taglib tcpd theora tiff truetype udev udisks unicode upower usb v4l v4l2 vaapi vim-syntax vnc vorbis wifi wxwidgets x264 xcb xcomposite xine xinerama xml xorg xscreensaver xulrunner xv xvid zeroconf zlib zsh-completion" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev mouse keyboard synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en ru" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" QEMU_SOFTMMU_TARGETS="x86_64 i386 arm" QEMU_USER_TARGETS="x86_64 i386 arm" RUBY_TARGETS="ruby19" USERLAND="GNU" VIDEO_CARDS="dummy fbdev intel nouveau qxl" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Maksim 'max_posedon' Melnikau 2012-06-03 20:14:09 UTC
More info about first version could be found in bug #391347
Comment 2 Maksim 'max_posedon' Melnikau 2012-06-03 20:18:05 UTC
Created attachment 314091 [details, diff]
rabbitmq.service patch

Remove using /usr/sbin/rabbitmq-server
Add correct ExecStop command (via /usr/libexec/rabbitmq/rabbitmqctl)
Specify WorkingDirectory, User and Group
Comment 3 Ultrabug gentoo-dev 2012-09-03 16:03:27 UTC
Thanks Maksim, fixed in tree !

+*rabbitmq-server-2.8.6 (03 Sep 2012)
+
+  03 Sep 2012; Ultrabug <ultrabug@gentoo.org> -rabbitmq-server-2.8.1-r1.ebuild,
+  rabbitmq-server-2.8.4.ebuild, rabbitmq-server-2.8.5.ebuild,
+  +rabbitmq-server-2.8.6.ebuild, files/rabbitmq.service,
+  files/rabbitmq-script-wrapper:
+  Drop old. Add GPL-2 LICENSE fix #426092. Enhanced systemd service file fix
+  #419531 and init script fix #416345 thx to Maksim Melnikau. Fix #430510 VCS
+  fetching in compilation. Fix #430508 parallel building. Version bump.
+