Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 419339 - net-p2p/tribler should depend on python version <3.0
Summary: net-p2p/tribler should depend on python version <3.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-02 11:34 UTC by PM
Modified: 2012-06-05 12:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description PM 2012-06-02 11:34:49 UTC
net-p2p/tribler currently depends on ">=dev-lang/python-2.5[sqlite]" which resolves to python-3.2.3-r1, while it really needs python2.

Reproducible: Always
Comment 1 Anthony Basile gentoo-dev 2012-06-04 11:46:46 UTC
I thought the PYTHON_DEPEND="2:2.7" limited that.  Anyhow, I've made the change in the latest ebuild tribler-5.9.12.ebuild and will push forward with that.  Can you test to make sure its okay at your end.
Comment 2 PM 2012-06-04 12:08:54 UTC
>I thought the PYTHON_DEPEND="2:2.7" limited that.

Well, I had python installed without sqlite flag and emerging tribler with --autounmask-write re-merged python 3 with this flag enabled instead of python 2.
Comment 3 Guillaume Castagnino 2012-06-04 13:14:26 UTC
Hi,

A better fix would be to use the PYTHON_USE_WITH="sqlite" variable instead of pulling a python dependency in RDEPEND. This may probably avoid future issue with the python depend. But I'm not very familiar with the python eclass:

# diff -u tribler-5.9.12.ebuild.old tribler-5.9.12.ebuild
--- tribler-5.9.12.ebuild.old   2012-06-04 15:08:49.466917211 +0200
+++ tribler-5.9.12.ebuild       2012-06-04 15:09:32.582744610 +0200
@@ -4,6 +4,7 @@
 
 EAPI="4"
 PYTHON_DEPEND="2:2.7"
+PYTHON_USE_WITH="sqlite"
 
 inherit eutils python
 
@@ -18,8 +19,7 @@
 KEYWORDS="~amd64 ~x86"
 IUSE="vlc"
 
-RDEPEND="<dev-lang/python-3[sqlite]
-       >=dev-python/m2crypto-0.16
+RDEPEND=">=dev-python/m2crypto-0.16
        >=dev-python/wxpython-2.8
        >=dev-python/apsw-3.6
        >=dev-libs/openssl-0.9.8
Comment 4 Anthony Basile gentoo-dev 2012-06-04 18:54:14 UTC
(In reply to comment #3)

> But I'm not very familiar with the python eclass:

Its messy.  Let me bounce this question off of some python gurus and see what they say.  But after I pushed the change in comment #1, I in fact verified that the PYTHON_DEPEND range is not enough.
Comment 5 Anthony Basile gentoo-dev 2012-06-04 20:04:14 UTC
Okay the gurus tell me:

    PYTHON_DEPEND="2"
    PYTHON_USE_WITH="sqlite"

I'll commit that now without rev bump.  Please test (again) and let me know.
Comment 6 Mike Gilbert gentoo-dev 2012-06-04 20:19:13 UTC
FYI: Setting those variables causes python.eclass to emit the following dependency atom:

=dev-lang/python-2*[sqlite]

It also enables a pkg_setup check to ensure that the currently eselect-ed python2 is built with the sqlite use flag.
Comment 7 Guillaume Castagnino 2012-06-05 09:19:08 UTC
Seems fine to me, thanks !!