Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 418231 - app-office/libreoffice-3.5.4.2-r1 does not build against libexttextcat-3.3.0
Summary: app-office/libreoffice-3.5.4.2-r1 does not build against libexttextcat-3.3.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 10:25 UTC by Marien Zwart (RETIRED)
Modified: 2012-05-30 16:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marien Zwart (RETIRED) gentoo-dev 2012-05-30 10:25:54 UTC
libreoffice-3.5.4.2-r1 fails against the libexttextcat-3.3.0, which was just added to the tree:

/var/tmp/portage/app-office/libreoffice-3.5.4.2-r1/work/libreoffice-core-3.5.4.2/lingucomponent/source/languageguessing/simpleguesser.cxx: In member function 'std::vector<Guess> SimpleGuesser::GuessLanguage(const char*)':
/var/tmp/portage/app-office/libreoffice-3.5.4.2-r1/work/libreoffice-core-3.5.4.2/lingucomponent/source/languageguessing/simpleguesser.cxx:121:29: error: 'utfstrlen' was not declared in this scope

Diffing libexttextcat-3.2.0 and 3.3.0 shows that utfstrlen was renamed to utf8_strlen, but the upstream fix for this actually seems to be a switch to plain old strlen, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=25a605f36544582bd454d4bc0e71e684749a0b80

I'll start a build with the above commit applied later today and see if it at least compiles.
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2012-05-30 10:50:29 UTC
Thanks for the report and the patchid. The patch was added to 3.5.4.2-r1 ebuild.

I am working on 3.6alpha1 release so I didn't see it break and expected it to work with 3.5 fine.

I cherry-picked the named commit to 3.5 branch so with next version it will be resolved upstream.
Comment 2 Marien Zwart (RETIRED) gentoo-dev 2012-05-30 12:08:19 UTC
Now it fails with:

Making:    libguesslanglo.so
/usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lexttextcat

Which is because the library is now libexttextcat-1.0.so, not libexttextcat.so. I hoped applying the RepositoryExternal.mk part of http://cgit.freedesktop.org/libreoffice/core/commit/?id=578b7df37638cf9afad327900d2140aabd0c3556 would get me past that, but that's apparently not how this build system works.

Looking a little closer I think this part is a libexttextcat bug: pkg-config --libs libexttextcat gives me -lexttextcat. I'll go look at their upstream, but it'd be nice if you could confirm the libreoffice build system picks up the library name via pkg-config (there's a PKG_CHECK_MODULES call and AC_SUBST(LIBEXTTEXTCAT_LIBS) in configure.in so this seems plausible).
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2012-05-30 12:54:02 UTC
Fuuu.

It is a bug in the .pc file.

If you take look on it:
Version: 3.3.0
Requires:
Libs: -L${libdir} -lexttextcat
Cflags: -I${includedir}/libexttextcat/

And it should say something like:
Version: 3.3.0
Requires:
Libs: -L${libdir} -lexttextcat-1.0
Cflags: -I${includedir}/libexttextcat/

So could you please to try to patch (just sed it) it and revision bump it if it builds for you?

I can test it no sooner than in the evening (CEST)
Comment 4 Marien Zwart (RETIRED) gentoo-dev 2012-05-30 14:02:39 UTC
I'd found the same problem, and libreoffice does build with it fixed. I've committed libexttextcat-3.3.0-r1 with a patch for the .pc.in file. Can you get this upstreamed, since IIUC you're already in contact with or part of them?