Bug 416517 – dev-python/python-openid-2.2.5 fails tests

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Paweł Hajdan, Jr. (RETIRED) 2012-05-18 16:43:27 UTC]

Created attachment 312211 [details]
build.log.gz

======================================================================
FAIL: unittest.case.FunctionTestCase (test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./openid/test/test_fetchers.py", line 213, in test
    run_fetcher_tests(server)
  File "./openid/test/test_fetchers.py", line 113, in run_fetcher_tests
    test_fetcher(f, True, server)
  File "./openid/test/test_fetchers.py", line 83, in test_fetcher
    assert False, 'An exception was expected for %r (%r)' % (fetcher, result)
AssertionError: An exception was expected for <openid.fetchers.Urllib2Fetcher object at 0x889730c> (<HTTPResponse status 404 for http://invalid.janrain
.com/>)

======================================================================
FAIL: test_notWrapped (openid.test.test_fetchers.DefaultFetcherTest)
Make sure that if we set a non-wrapped fetcher as default,
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./openid/test/test_fetchers.py", line 281, in test_notWrapped
    self.fail('Should have raised an exception')
AssertionError: Should have raised an exception

======================================================================
FAIL: test_wrappedByDefault (openid.test.test_fetchers.DefaultFetcherTest)
Make sure that the default fetcher instance wraps
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./openid/test/test_fetchers.py", line 259, in test_wrappedByDefault
    fetchers.fetch, 'http://invalid.janrain.com/')
AssertionError: HTTPFetchingError not raised

======================================================================
FAIL: runTest (openid.test.test_parsehtml._TestCase)
29 (openid.test.test_parsehtml<test1-parsehtml.txt>)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./openid/test/test_parsehtml.py", line 36, in runTest
    self.failUnless(self.expected == 'EOF', (self.case, self.expected))
AssertionError: ('<!bad processing instruction!>\n', 'None')

----------------------------------------------------------------------
Ran 1359 tests in 4.722s

FAILED (failures=4)
 * ERROR: dev-python/python-openid-2.2.5 failed (test phase):
 *   Testing failed with CPython 2.7 in testing() function

Portage 2.1.10.49 (default/linux/x86/10.0/developer, gcc-4.5.3, glibc-2.14.1-r3, 3.1.6-gentoo i686)
=================================================================
System uname: Linux-3.1.6-gentoo-i686-Intel-R-_Core-TM-2_Duo_CPU_P8700_@_2.53GHz-with-gentoo-2.0.3
Timestamp of tree: Thu, 17 May 2012 10:05:01 +0000
app-shells/bash:          4.2_p20
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r1, 3.2.3
dev-util/cmake:           2.8.6-r4
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.11.1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.4.6-r1, 4.5.3-r2
sys-devel/gcc-config:     1.5-r2
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 3.1 (virtual/os-headers)
sys-libs/glibc:           2.14.1-r3
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs collision-protect compress-build-logs distlocks ebuild-locks fixlafiles multilib-strict news parallel-fetch protect-owned sandbox sfperms sign splitdebug strict test test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox"
FFLAGS=""
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,--hash-style=gnu -Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa berkdb bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus device-mapper dri dts dvd dvdr emacs emboss encode exif fam firefox flac fortran gdbm gif git gnutls gtk iconv icu jpeg lcms libkms libnotify mad mbox mercurial mng modules mp3 mp4 mpeg mudflap ncurses nls nptl nss objc ogg opengl openmp pam pango pcre pdf perl png policykit ppds pppd python qt3support readline sdl secure-delete session snmp spell sqlite ssl startup-notification subversion svg tcpd threads tiff tk toolkit-scroll-bars truetype udev udisks unicode upower usb vorbis wxwidgets x264 x86 xcb xft xinerama xml xorg xulrunner xv xvfb xvid zlib" ALSA_CARDS="ens1371" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev keyboard vmmouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="vmware vesa vga" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Ian Delaney (RETIRED) 2012-05-24 20:37:19 UTC]

Created attachment 312997 [details, diff]
files/eof-test.patch

archtester python-openid # USE_PYTHON="2.5 2.6" ebuild python-openid-2.2.5.ebuild clean test

yields

.................................................................................................................../openid/test/test_fetchers.py:101: UserWarning: Skipping tests for 'httplib2' fetcher because the library did not import.
  'the library did not import.' % (library_name,))

Ran 1361 tests in 3.174s            OK

for both Python2.5 2.6. It still registered a pass for the tests.  

openid/test/test_fetchers.py is the file that suffers the first three. Since mine actually pass I can't determine a root cause.

The fourth however did fail here.

    self.failUnless(self.expected == 'EOF', (self.case, self.expected))
AssertionError: ('<!bad processing instruction!>\n', 'None')

The value of self.expected is tested against 'EOF' but its value is 'None' and self.case has acquired '<!bad processing instruction!> . Clearly self.expected need have the value 'EOF' and not None.  
The test will pass with values of both are 'EOF'.

'<!bad processing instruction!>\n' is the last line of the file that is being read, openid/test/data/test1-parsehtml.txt.  This appears to be data that can never pass.  The second last line is None which is acquired by self.expected.


archtester python-openid # USE_PYTHON="2.7" ebuild python-openid-2.2.5.ebuild clean test

----------------------------------------------------------------------
Ran 1361 tests in 3.064s           OK

The patch that returns a pass to this test sets the second last line to 'EOF' and also the last line.  Importantly the \n at the end of file also needs to be taken out.  i.e. <!bad processing instruction!>\n -> 'EOF'
self.failUnless(self.expected == 'EOF', (self.case, self.expected))
then returns ('EOF','EOF')  and the test passes.  It doesn't interfere with any other test results.

I also used ('None','None') but it didn't register a pass unless I missed something.  To me it appears the last 2 lines are at fault. But I'm not a python guru.

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2012-05-24 21:30:44 UTC]

Test suite passes with CPython 2.6 and probably older versions of CPython 2.7...

[Comment 3 Patrice Clement 2016-01-01 03:36:47 UTC]

commit f052ebd (HEAD, master)
Author: Patrice Clement <[e-mail]>
Date:   Fri Jan 1 03:35:35 2016 +0000

    dev-python/python-openid: Remove a failing test. Fixes bug 416517.
    
    Package-Manager: portage-2.2.20.1
    Signed-off-by: Patrice Clement <[e-mail]>

 create mode 100644 dev-python/python-openid/files/python-openid-2.2.5-tests.patch