Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 416367 - Prefix support for dev-java/gcj-jdk
Summary: Prefix support for dev-java/gcj-jdk
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-05-17 11:15 UTC by Benda Xu
Modified: 2012-09-29 02:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gcj-jdk.patch (gcj-jdk.patch,2.25 KB, patch)
2012-05-17 11:23 UTC, Benda Xu
Details | Diff
gcj-jdk.patch (gcj-jdk.patch,2.12 KB, patch)
2012-05-17 15:07 UTC, Benda Xu
Details | Diff
gcj-jdk.pach (gcj-jdk.patch,2.18 KB, patch)
2012-05-17 15:14 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2012-05-17 11:15:26 UTC
Hi, please review the attach patch for Prefix support for dev-java/gcj-jdk.

PS: the original dosym with wildcard does not work. 

Reproducible: Always
Comment 1 Benda Xu gentoo-dev 2012-05-17 11:23:59 UTC
Created attachment 312103 [details, diff]
gcj-jdk.patch

The gcc[gtk] dep comes from libjawt.so.
Comment 2 Benda Xu gentoo-dev 2012-05-17 11:26:01 UTC
please ignore the cvs header and keyword change. and S="${WORKDIR}" is because EAPI4 issues "cd ${S}" (S=${WORKDIR}/${P}) by default.
Comment 3 Ralph Sennhauser (RETIRED) gentoo-dev 2012-05-17 14:28:15 UTC
> local gcj_ver=$(cut -d. -f3 <<< $(readlink $(gcc-config -L)/libgcj.so))

won't work as gcc-config -L returns a semicolon separated list of paths and so readlink will fail on for example a default amd64 setup.
I suggest you just do the expansion in the Prefix and strip EPREFIX before feeding it to dosym.

The other changes look good.
Comment 4 Benda Xu gentoo-dev 2012-05-17 15:07:54 UTC
Created attachment 312115 [details, diff]
gcj-jdk.patch

use the trick as sera suggested.
Comment 5 Benda Xu gentoo-dev 2012-05-17 15:14:53 UTC
Created attachment 312117 [details, diff]
gcj-jdk.pach
Comment 6 Ralph Sennhauser (RETIRED) gentoo-dev 2012-09-28 17:56:59 UTC
Thanks, was fixed a while back ;)

*gcj-jdk-4.6.3 (05 Jun 2012)
*gcj-jdk-4.6.2-r1 (05 Jun 2012)
*gcj-jdk-4.6.1 (05 Jun 2012)
*gcj-jdk-4.6.0 (05 Jun 2012)

  05 Jun 2012; Ralph Sennhauser <sera@gentoo.org> +gcj-jdk-4.6.0.ebuild,
  +gcj-jdk-4.6.1.ebuild, +gcj-jdk-4.6.2-r1.ebuild, +gcj-jdk-4.6.3.ebuild:
  Import from java-overlay.
  Adds Prefix support and missing use dep, thanks to XU Benda
  <heroxbd@gentoo.org>. #416367
  Remove JAVA_PROVIDE, old style virtuals are dead.
Comment 7 Benda Xu gentoo-dev 2012-09-29 02:06:41 UTC
Thanks sera, as always ;)