Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 415895 - baselayout-prefix proposed update
Summary: baselayout-prefix proposed update
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 09:56 UTC by Benda Xu
Modified: 2012-08-08 01:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
baselayout-prefix.patch (baselayout-prefix.patch,2.09 KB, patch)
2012-05-14 09:58 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2012-05-14 09:56:25 UTC
To clean up unused apps in baselayout-prefix and give support for openrc, I propose the update to be reviewed. 


Reproducible: Always
Comment 1 Benda Xu gentoo-dev 2012-05-14 09:58:54 UTC
Created attachment 311721 [details, diff]
baselayout-prefix.patch

We donot need /sbin/{*.sh,runscript,start-stop-daemon}, or /etc/init.d/functions.sh. consoletype seems to be of no big use and linux only and is not provided by baselayout-2.
Comment 2 Benda Xu gentoo-dev 2012-05-14 11:38:02 UTC
Hmm... it seems that I need to keep functions.sh or further patch functions.sh from openrc. bug 373219
Comment 3 Benda Xu gentoo-dev 2012-05-16 17:34:32 UTC
confirmed functions.sh from openrc breaks gcc-config.
Comment 4 Benda Xu gentoo-dev 2012-08-07 10:27:41 UTC
Hi, if there is no objections, I will commit this change into CVS, and use functions.sh from baselayout-prefix before bug 373219 is resolved.
Comment 5 Fabian Groffen gentoo-dev 2012-08-07 10:38:58 UTC
Can you explain why you remove ~80% of the ebuild?  removing start-stop-daemon is fine, misc-functions of course is not.  Please keep in mind the upgrade path.  I wouldn't hesitate to create a new revision, and to mask it in the Prefix profiles, stating that it is experimental.

Your work with OpenRC support would then be testable without being forced upon all Prefix users.

So, I ack iff you do a revbump and mask that one.
Comment 6 Benda Xu gentoo-dev 2012-08-07 12:07:17 UTC
(In reply to comment #5)
> Can you explain why you remove ~80% of the ebuild?

Lines 37-55 consoletype.patch, we don't need any C programs here.
Lines 76-88 make -C "${S}"/src..., same as above

runscript.sh, not used anywhere AFAIK and openrc provides it.
runscript.c, depscan.sh, rc-daemon.sh, rc-services.sh, same as above.

Lines 125-161, same as the two points.

> I wouldn't hesitate to create a new revision, and to mask it in the Prefix profiles, stating that it is experimental.

OK, I'll do it.
Comment 7 Benda Xu gentoo-dev 2012-08-07 13:32:49 UTC
masked and commited. Thanks grobian.
Comment 8 Fabian Groffen gentoo-dev 2012-08-07 13:58:50 UTC
                                              
--- Invalid atom in                                                             
/export/gentoo/clean/prefix-overlay-rsync-master/profiles/prefix/package.mask:  
>=baselayout-prefix-1.12.14-r1                 


you have to use full cat/pkg !!!!!

please fix
Comment 9 Benda Xu gentoo-dev 2012-08-08 01:50:11 UTC
(In reply to comment #8)
>                                               
> --- Invalid atom in                                                         
> 
> /export/gentoo/clean/prefix-overlay-rsync-master/profiles/prefix/package.
> mask:  
> >=baselayout-prefix-1.12.14-r1                 
> 
> 
> you have to use full cat/pkg !!!!!
> 
> please fix

Oh. I am really sorry about that. I won't make this kind of mistake again.