abcde-2.5.2 version bump. Long time since an upgrade ebuild has been submitted for abcde! One new file is added on install: /usr/bin/abcde-musicbrainz-tool Cheers! Reproducible: Always
Created attachment 311307 [details] abcde-2.5.2.ebuild Version bump.
Comment on attachment 311307 [details] abcde-2.5.2.ebuild Please post patches to ebuilds or when those turn out to be nill, just explain that the old ebuild works when simply copied over. There's no difference between this ebuild and the 2.4.2-r1 currently in the tree. There's no point in attaching files with code we already have.
$ diff /usr/portage/media-sound/abcde/abcde-2.4.2-r1.ebuild /usr/local/portage/media-sound/abcde/abcde-2.5.2.ebuild 0 ;-) ($?=0 ;-) Yes, I just copied over the ebuild. And I'm using abcde-2.5.2 here on x86 right now and everything appears to be working just fine.
The package has a file called "changelog". When doing a version bump, it's good idea to see what has changed, no? For example, * Several patches for improved Musicbrainz support from Martin Michlmayr: + add musicbrainz support for FLAC files with embedded cue files. Closes: #669139 + Don't submit to CDDB server when using musicbrainz Closes: #669140 + Don't tag CDDB string with musicbrainz id Closes: #669141 Which involves adding dev-perl/WebService-MusicBrainz and dev-perl/MusicBrainz-DiscID to portage as new packages... Then sorting the deps for it in abcde... Anyway, committed changed ebuild to Portage. Give it a try and in the future, please do some research when filing version bump requests.
(In reply to comment #0) > One new file is added on install: > /usr/bin/abcde-musicbrainz-tool ^ Missed that in your comment when writing the last comment, sorry about that. But, but but... should have still added/checked the missing dependencies it uses. :/
Comment #4: Version bumps and upgrades usually have never required a ChangeLog submission, as it's merrily a entry containing the change in version. (Especially since the ebuilds have been clearly marked as "copied over" here.) Any source related changes are documented at the source code level, or on the developer's website obviously. Else, us volunteers would be spending all day simply copying developer's changes log notes to our own package ChangeLog. Hence, only customizations performed by us are usually noted within our ChangeLog ebuilds. However, if you are talking about the customizations on this ebuild were never submitted into a ChangeLog, then you likely have a right to be upset. I advocate good documentation here, and likely not responsible for any of the previous customizations on this ebuild, else they're in a Changelog and/or well documented inline with my name. Comment #5: I have no idea what the muzicbrainz stuff as I'm too old to keep up with the stuff and any patches in addition to the vanilla sources. (Or patches added by the ebuild.) They were submitted prior to this ebuild. As such, I merrily made FYI notice here there's an additional file installed here on the boards. Thanks for taking your time incorporating the version bump. Many CLI users will worship you for it. Hopefully, I've answered the questions you were pondering.