Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 414465 - sys-apps/iproute2-3.3.0 prefix support
Summary: sys-apps/iproute2-3.3.0 prefix support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-03 10:02 UTC by Michael Weber (RETIRED)
Modified: 2012-05-22 21:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
prefix support (plain,684 bytes, patch)
2012-05-03 10:02 UTC, Michael Weber (RETIRED)
Details | Diff
build log for comment 3. (homemichaelgentoo-prefixvartmpportagesys-appsiproute2-3.3.0tempbuild.log.txt,48.17 KB, text/plain)
2012-05-03 19:11 UTC, Michael Weber (RETIRED)
Details
correct build log, some files still out of prefix. (homemichaelgentoo-prefixvartmpportagesys-appsiproute2-3.3.0tempbuild.log.txt,44.40 KB, text/plain)
2012-05-03 19:15 UTC, Michael Weber (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weber (RETIRED) gentoo-dev 2012-05-03 10:02:42 UTC
Created attachment 310681 [details, diff]
prefix support

ecopy ( DESTDIR D -> ED )


Portage 2.2.01.20430-prefix (prefix/linux/amd64, gcc-4.5.3, unavailable, 3.2.2-1-ARCH x86_64)
=================================================================
System uname: Linux-3.2.2-1-ARCH-x86_64-AMD_FX-tm-4100_Quad-Core_Processor-with-glibc2.2.5
Timestamp of tree: Thu, 03 May 2012 08:20:06 +0000
app-shells/bash:          4.2_p20::gentoo_prefix
dev-lang/python:          2.7.2-r3::gentoo_prefix
dev-util/pkgconfig:       0.26::gentoo_prefix
sys-devel/autoconf:       2.68::gentoo_prefix
sys-devel/automake:       1.11.5::gentoo_prefix
sys-devel/binutils:       2.22-r1::gentoo_prefix
sys-devel/gcc:            4.2.4-r01.4::gentoo_prefix, 4.5.3-r1::gentoo_prefix
sys-devel/gcc-config:     1.5-r2::gentoo_prefix
sys-devel/libtool:        2.4.2::gentoo_prefix
sys-devel/make:           3.82::gentoo_prefix
sys-kernel/linux-headers: 3.3::gentoo_prefix (virtual/os-headers)
Repositories: gentoo_prefix local xmw
Installed sets: 
ACCEPT_KEYWORDS="~amd64-linux"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/portage /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/home/michael/gentoo-prefix/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs collision-protect distlocks ebuild-locks fixlafiles force-prefix news parallel-fetch preserve-libs protect-owned sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://lore.xmw.de/gentoo/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j4"
PKGDIR="/home/michael/gentoo-prefix/usr/portage/packages"
PORTAGE_CONFIGROOT="/home/michael/gentoo-prefix/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/home/michael/gentoo-prefix/var/tmp"
PORTDIR="/home/michael/gentoo-prefix/usr/portage"
PORTDIR_OVERLAY="/home/michael/gentoo-prefix/usr/local/portage /home/michael/gentoo-prefix/var/lib/layman/xmw"
SYNC="rsync://rsync.prefix.freens.org/gentoo-portage-prefix"
USE="amd64 berkdb bzip2 cli cracklib crypt cxx dri fortran gdbm git iconv ipv6 mmx modules mudflap ncurses nls nptl nptlonly openmp pcre pppd prefix readline session sse sse2 ssl sysfs tcpd unicode xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga neomagic nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 SpanKY gentoo-dev 2012-05-03 15:56:16 UTC
Comment on attachment 310681 [details, diff]
prefix support

KEYWORDS change: obviously wrong

DESTDIR change: obviously correct
Comment 2 Fabian Groffen gentoo-dev 2012-05-03 16:02:51 UTC
I'd say...

DESTDIR change: obviously wrong :(
Comment 3 Fabian Groffen gentoo-dev 2012-05-03 16:21:57 UTC
I think you'll need at least:

--- iproute2-3.3.0.ebuild       30 Mar 2012 21:00:59 -0000      1.1
+++ iproute2-3.3.0.ebuild       3 May 2012 16:21:05 -0000
@@ -78,9 +78,9 @@
 
        emake \
                DESTDIR="${D}" \
-               SBINDIR=/sbin \
-               DOCDIR=/usr/share/doc/${PF} \
-               MANDIR=/usr/share/man \
+               SBINDIR="${EPREFIX}"/sbin \
+               DOCDIR="${EPREFIX}"/usr/share/doc/${PF} \
+               MANDIR="${EPREFIX}"/usr/share/man \
                install
 
        dolib.a lib/libnetlink.a
Comment 4 SpanKY gentoo-dev 2012-05-03 16:28:40 UTC
(In reply to comment #3)

you're the expert, but that looks fine to me ... feel free to commit w/out a revbump
Comment 5 Michael Weber (RETIRED) gentoo-dev 2012-05-03 19:11:01 UTC
Created attachment 310697 [details]
build log for comment 3.

Close, but no. I tried the initial patch.
Comment 6 Michael Weber (RETIRED) gentoo-dev 2012-05-03 19:15:34 UTC
Created attachment 310699 [details]
correct build log, some files still out of prefix.

please see the error for /var/run /lib/ /etc/iproute2.

DESTDIR="${ED}" still works.
Comment 7 Fabian Groffen gentoo-dev 2012-05-03 19:18:36 UTC
have you considered looking inside the Makefile to see that there are more variables there that are not overridden by the ebuild?

Prefix is not supposed to be about quick 'n' dirty.
Comment 8 Fabian Groffen gentoo-dev 2012-05-13 15:31:20 UTC
I think this does it, can't test it


diff -u -r1.7 iproute2-3.3.0.ebuild
--- iproute2-3.3.0.ebuild       12 May 2012 13:39:28 -0000      1.7
+++ iproute2-3.3.0.ebuild       13 May 2012 15:30:48 -0000
@@ -4,7 +4,7 @@
 
 EAPI="4"
 
-inherit eutils toolchain-funcs flag-o-matic
+inherit eutils toolchain-funcs flag-o-matic multilib
 
 if [[ ${PV} == "9999" ]] ; then
        EGIT_REPO_URI="git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git"
@@ -84,9 +84,12 @@
 
        emake \
                DESTDIR="${D}" \
-               SBINDIR=/sbin \
-               DOCDIR=/usr/share/doc/${PF} \
-               MANDIR=/usr/share/man \
+               LIBDIR="${EPREFIX}"/$(get_libdir) \
+               SBINDIR="${EPREFIX}"/sbin \
+               CONFDIR="${EPREFIX}"/etc/iproute2 \
+               DOCDIR="${EPREFIX}"/usr/share/doc/${PF} \
+               MANDIR="${EPREFIX}"/usr/share/man \
+               ARPDIR="${EPREFIX}"/var/lib/arpd \
                install
 
        dolib.a lib/libnetlink.a
cvs diff: Diffing files
Comment 9 Michael Weber (RETIRED) gentoo-dev 2012-05-22 21:02:50 UTC
good to go, but it has to be ARPDDIR, not ARPDIR.
Comment 10 Michael Weber (RETIRED) gentoo-dev 2012-05-22 21:14:37 UTC
+  22 May 2012; Michael Weber <xmw@gentoo.org> iproute2-3.3.0.ebuild:
+  Finally fix prefix support (bug 414465)
+