Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 413711 - Please stabilize net-print/gtklp-1.2.8a
Summary: Please stabilize net-print/gtklp-1.2.8a
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard: was: net-print/gtklp-1.2.8 fails to c...
Keywords: STABLEREQ
Depends on:
Blocks: cups-stable
  Show dependency tree
 
Reported: 2012-04-27 10:43 UTC by Paweł Hajdan, Jr. (RETIRED)
Modified: 2012-05-21 09:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.gz (net-print:gtklp-1.2.8:20120426-183819.log.gz,9.28 KB, application/x-gzip)
2012-04-27 10:43 UTC, Paweł Hajdan, Jr. (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-04-27 10:43:04 UTC
Created attachment 310249 [details]
build.log.gz

This is with cups-1.5.2-r3:


i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..   -I../include -I../libgtklp -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-
1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-
1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm    -DHAVE_LIBSSL -DLOCALEDIR=\"/usr/share/locale\" -DHAVE_GTK2 -DMAX_PRT=150    -
O2 -march=i686 -pipe -MT gtklp.o -MD -MP -MF .deps/gtklp.Tpo -c -o gtklp.o gtklp.c
In file included from gtklp.c:26:0:
gtklp.h:99:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
gtklp.c: In function 'main':
gtklp.c:305:6: warning: format not a string literal and no format arguments
In file included from file.c:36:0:
gtklp.h:99:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
gtklp.c:627:15: warning: ignoring return value of 'getcwd', declared with attribute warn_unused_result
make[2]: *** [gtklp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [file.o] Error 1
general.c: In function 'callGtkLPQFunc':
general.c:558:8: warning: ignoring return value of 'system', declared with attribute warn_unused_result
mv -f .deps/general.Tpo .deps/general.Po
make[2]: Leaving directory `/var/tmp/portage/net-print/gtklp-1.2.8/work/gtklp-1.2.8/gtklp'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/net-print/gtklp-1.2.8/work/gtklp-1.2.8'
make: *** [all] Error 2
emake failed
 * ERROR: net-print/gtklp-1.2.8 failed (compile phase):
 *   emake failed

Portage 2.1.10.49 (default/linux/x86/10.0/developer, gcc-4.5.3, glibc-2.14.1-r3, 3.1.6-gentoo i686)
=================================================================
System uname: Linux-3.1.6-gentoo-i686-Intel-R-_Core-TM-2_Duo_CPU_P8700_@_2.53GHz-with-gentoo-2.0.3
Timestamp of tree: Tue, 24 Apr 2012 07:30:01 +0000
app-shells/bash:          4.2_p20
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.2-r3, 3.2.2
dev-util/cmake:           2.8.6-r4
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.11.1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.5.3-r2
sys-devel/gcc-config:     1.5-r2
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 3.1 (virtual/os-headers)
sys-libs/glibc:           2.14.1-r3
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs collision-protect compress-build-logs distlocks ebuild-locks fixlafiles multilib-strict news parallel-fetch protect-owned sandbox sfperms sign splitdebug strict test test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox"
FFLAGS=""
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,--hash-style=gnu -Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa berkdb bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus device-mapper dri dts dvd dvdr emacs emboss encode exif fam firefox flac fortran gdbm gdu gif git gnutls gtk iconv icu jpeg lcms libkms libnotify mad mbox mercurial mng modules mp3 mp4 mpeg mudflap ncurses nls nptl nptlonly nss objc ogg opengl openmp pam pango pcre pdf perl png policykit ppds pppd python qt3support readline sdl secure-delete session snmp spell sqlite ssl startup-notification subversion svg sysfs tcpd threads tiff tk toolkit-scroll-bars truetype udev unicode usb vorbis wxwidgets x264 x86 xcb xft xinerama xml xorg xulrunner xv xvfb xvid zlib" ALSA_CARDS="ens1371" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev keyboard vmmouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="vmware vesa vga" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Juergen Rose 2012-04-27 11:36:22 UTC
I have the same error.
Comment 2 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-04-27 19:49:53 UTC
This only happens with cups-1.5 and works fine with cups-1.4.
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2012-04-27 21:22:54 UTC
Fixed upstream in net-print/gtklp-1.2.8a. The code difference between 1.2.8 and 1.2.8a is a one-line patch (see below), which is why I think we can skip the usual 30days for stabilization. 

Please stabilize net-print/gtklp-1.2.8a
Target: amd64 ppc x86

This blocks cups-1.5 stabilization.


huettel@pinacolada ~/tmp $ diff -ruN gtklp-1.2.8 gtklp-1.2.8a
diff -ruN gtklp-1.2.8/ChangeLog gtklp-1.2.8a/ChangeLog
--- gtklp-1.2.8/ChangeLog       2010-02-11 20:38:17.000000000 +0100
+++ gtklp-1.2.8a/ChangeLog      2012-03-12 20:09:16.000000000 +0100
@@ -1,3 +1,7 @@
+* Mon Mar 12 2012 Tobias Mueller <gtklp@sirtobi.com>
+- version 1.2.8a
+- patch to compile with cups 1.5, thanks to Bengt Ahlgren 
+
 * Thu Feb 11 2010 Tobias Mueller <sirtobi@stud.uni-hannover.de>
 - version 1.2.8
 - remove "waiting" window
diff -ruN gtklp-1.2.8/gtklp/gtklp.h gtklp-1.2.8a/gtklp/gtklp.h
--- gtklp-1.2.8/gtklp/gtklp.h   2010-02-11 20:38:17.000000000 +0100
+++ gtklp-1.2.8a/gtklp/gtklp.h  2012-03-12 20:10:00.000000000 +0100
@@ -26,6 +26,7 @@
 
 #include <gtk/gtk.h>
 #include <cups/cups.h>
+#include <cups/ppd.h>
 #include <cups/http.h>
 
 #include <defaults.h>
Comment 4 Agostino Sarubbo gentoo-dev 2012-04-28 12:17:55 UTC
amd64 stable
Comment 5 Brent Baude (RETIRED) gentoo-dev 2012-05-06 20:32:10 UTC
ppc done
Comment 6 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-05-21 09:31:22 UTC
x86 stable, closing