Bug 413287 – x11-libs/gdk-pixbuf: GNU mktemp usage makes it uninstallable on BSD

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexis Ballier 2012-04-23 19:18:08 UTC]

currently it depends on coreutils, for the sole functionality of:
tmp_file=$(mktemp --suffix=gdk_pixbuf_ebuild)

what about changing it to the more portable:

Index: gdk-pixbuf-2.26.1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/x11-libs/gdk-pixbuf/gdk-pixbuf-2.26.1.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 gdk-pixbuf-2.26.1.ebuild
--- gdk-pixbuf-2.26.1.ebuild	14 Apr 2012 20:52:57 -0000	1.1
+++ gdk-pixbuf-2.26.1.ebuild	23 Apr 2012 19:15:39 -0000
@@ -75,7 +75,7 @@
 	# causes segfault if set, see bug 375615
 	unset __GL_NO_DSO_FINALIZER
 
-	tmp_file=$(mktemp --suffix=gdk_pixbuf_ebuild)
+	tmp_file=$(mktemp -t tmp.XXXXXXXXXXgdk_pixbuf_ebuild)
 	# be atomic!
 	gdk-pixbuf-query-loaders > "${tmp_file}"
 	if [ "${?}" = "0" ]; then


and dropping the coreutils dep?

(linux)
$ mktemp --suffix=gdk_pixbuf_ebuild
/tmp/tmp.omZb1tmAG1gdk_pixbuf_ebuild
$ mktemp -t tmp.XXXXXXXXXXgdk_pixbuf_ebuild
/tmp/tmp.vDr82MK2ahgdk_pixbuf_ebuild

(freebsd)
$ mktemp --suffix=gdk_pixbuf_ebuild
mktemp: illegal option -- -
$ mktemp -t tmp.XXXXXXXXXXgdk_pixbuf_ebuild
/tmp/tmp.XXXXXXXXXXgdk_pixbuf_ebuild.YfF0k1vm


not exactly 100% equivalent, but for a temp file it souldnt matter.

will apply the patch and drop coreutils dep within one week if nobody rants.

[Comment 1 Alexandre Rostovtsev (RETIRED) 2012-04-24 04:06:54 UTC]

Thanks, fixed in gdk-pixbuf and librsvg ebuilds.

>  24 Apr 2012; Alexandre Rostovtsev <[e-mail]>
>  gdk-pixbuf-2.24.0-r1.ebuild, gdk-pixbuf-2.24.1.ebuild,
>  gdk-pixbuf-2.24.1-r1.ebuild, gdk-pixbuf-2.26.1.ebuild:
>  Change "mktemp --suffix" to "mktemp -t" and drop coreutils dep to fix
>  building on bsd (bug #413287, thanks to Alexis Ballier).

>  24 Apr 2012; Alexandre Rostovtsev <[e-mail]>
>  librsvg-2.34.1-r1.ebuild, librsvg-2.34.2.ebuild, librsvg-2.36.0.ebuild,
>  librsvg-2.36.1.ebuild:
>  Change "mktemp --suffix" to "mktemp -t" to fix building on bsd (bug #413287,
>  thanks to Alexis Ballier).