Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 411937 - www-servers/nginx-1.3.0 version bump (package.mask due to development branch)
Summary: www-servers/nginx-1.3.0 version bump (package.mask due to development branch)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Benedikt Böhm (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-14 10:22 UTC by Agostino Sarubbo
Modified: 2013-04-26 10:54 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2012-04-14 10:22:37 UTC
As per comment #4 in bug 411751:

> With multiple release trains in the same package, a ~arch version of the
> "stable train" will never get tested by ~arch users. Therefore, I feel like
> supporting multiple release trains for nginx in Gentoo is the wrong approach.

Fair enough.

> 
> I added myself to metadata.xml and will contribute to the dev't releases. It
> is my opinion that we should just stabilize 1.1.19.

Ok, in my opinion the best choise could be make a slot(stable and dev).

So, Jeremy you can take care only of development release and if an user would use always ~arch version of stable slot, there is a way.

Obvious the the slot should have a block for the other slot, www-client/google-chrome can be an example.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-04-14 11:42:12 UTC
Oh dear, if upstream doesn't support slotting then downstream shouldn't. It is a maintenance nightmare.
Comment 2 Tiziano Müller (RETIRED) gentoo-dev 2012-04-15 10:58:10 UTC
Blocking slots are non-sense. If slotting, then permit parallel install.

For nginx this would probably be easier than for other packages as it requires "only" to slot the following (in increasing order of complexity for slotting)
* executable
* init.d-scripts, {configuration,log}-dirs
* perl-module

But I'd like to second Hollow's idea: p.masking the unstable version is probably the easiest and most effective way.
Comment 3 Benedikt Böhm (RETIRED) gentoo-dev 2012-04-15 18:24:39 UTC
i'm also in favor of p.masking the development branch. supporting slots would definitely be possible, but the nginx ebuild was always fairly simple (at least with regard to its number of modules) and i'd rather not introduce the complexity of supporting slots, just to keep people from accidentally upgrading to a different branch.

Jeremy also asked about the differences between stable and development. This, of course, changes from time to time, and i also rarely follow the single diffs between the branches. But for an important package like nginx, i'd rather trust upstreams decision on stable and development than pushing the development version onto users just because we don't want to have untested ~arch ebuilds ...

Jeremy, if you're ok with this, feel free to mask the 1.1 branch, otherwise i'll do it soonish, if nobody objects.
Comment 4 Agostino Sarubbo gentoo-dev 2012-04-15 18:35:01 UTC
fine for me
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-04-16 14:25:44 UTC
Ok, I thought it over and I guess it makes sense.

FTR, a diff of 1.0.15 and 1.1.19 is 7000 lines but mostly for debug, keepalive, pcre-jit, and spelling/syntax at 60 second glance

Before 1.1 gets masked, what is the upgrade path / announcement for current ~arch users?
Comment 6 Agostino Sarubbo gentoo-dev 2012-04-16 14:36:00 UTC
(In reply to comment #5)
> Before 1.1 gets masked, what is the upgrade path / announcement for current
> ~arch users?

A post on planet and link it in a package.mask could be an idea?
Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-05-18 14:04:59 UTC
This bug kind of solved itself. nginx-1.2.0 stable version has been released, incorporating many new features developed in the 1.1.x branch.

So, moving forward, we can mask 1.3.0 (uncommitted at the moment) as it is the new development branch and we don't need to announce it.
Comment 8 Benedikt Böhm (RETIRED) gentoo-dev 2012-05-18 14:15:08 UTC
indeed, very nice timing :-)
Comment 9 Johan Bergström 2012-05-22 23:08:57 UTC
(my 2c) We didn't mask for previous uneven versions if I recall correctly (not since 0.7 anyway), and its not like its anything major. I would prefer unstable since I consider nginx 1.3.x being just as "unstable" as anything else we put in tree. We should just refrain from STABLEREQ:ing the 1.3.x branch.
Comment 10 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-05-23 04:11:18 UTC
(In reply to comment #9)
> (my 2c) We didn't mask for previous uneven versions if I recall correctly
> (not since 0.7 anyway), and its not like its anything major. I would prefer
> unstable since I consider nginx 1.3.x being just as "unstable" as anything
> else we put in tree. We should just refrain from STABLEREQ:ing the 1.3.x
> branch.

If you never want to stable the 1.3 line, then the 1.2 line will never get tested in ~arch (it is overshadowed) and that would be a poor scenerio for a stablereq.
Comment 11 Manuel Rüger (RETIRED) gentoo-dev 2012-06-05 03:30:30 UTC
Why not p.mask nginx until 1.2.0 gets a stablereq and after that move 1.3.x into ~arch?

btw. app-emulation/wine has got the same problem. 1.4 is upstream's stable candidate and 1.5.x gets added to ~arch bi-weekly.
Comment 12 Patrick Lauer gentoo-dev 2012-06-06 08:48:07 UTC
+  06 Jun 2012; Patrick Lauer <patrick@gentoo.org> +nginx-1.3.1.ebuild:
+  Bump for #411937, temporarily masked

I see no reason to leave it masked, but you figure out what's best ;)
Comment 13 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-06-11 17:51:30 UTC
(In reply to comment #12)
> +  06 Jun 2012; Patrick Lauer <patrick@gentoo.org> +nginx-1.3.1.ebuild:
> +  Bump for #411937, temporarily masked
> 
> I see no reason to leave it masked, but you figure out what's best ;)

thx
Comment 14 Johan Bergström 2013-03-26 22:27:13 UTC
1.2.x has had stable candidates for a while now. Can we please unmask 1.3.x? Upstream considers it being production ready: http://mailman.nginx.org/pipermail/nginx/2013-February/037552.html
Comment 15 Anthony Ryan 2013-04-25 21:05:16 UTC
The 1.4.x stable branch has been released and is in the tree but is masked as a result of this issue still.
Comment 16 Benedikt Böhm (RETIRED) gentoo-dev 2013-04-26 10:54:13 UTC
(In reply to comment #15)
> The 1.4.x stable branch has been released and is in the tree but is masked
> as a result of this issue still.

nginx-1.4 is not p.masked