Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 411573 - dev-python/mako-0.7.0 version bump request
Summary: dev-python/mako-0.7.0 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Python Gentoo Team
URL: http://www.makotemplates.org/trac/tic...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 10:44 UTC by Ian Delaney (RETIRED)
Modified: 2012-04-15 04:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
files/mako-test.patch (mako-test.patch,526 bytes, patch)
2012-04-11 13:06 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2012-04-11 10:44:34 UTC
FEATURES="userpriv test usersandbox ... (in make.conf)

archtester mako #  USE_PYTHON="2.6 2.7 3.1 3.2" emerge mako
>>> Emerging (1 of 1) dev-python/mako-0.7.0
>>> Installing (1 of 1) dev-python/mako-0.7.0

archtester mako #  USE_PYTHON="2.5 2.6" emerge mako
-----------------------------------------------------------------
  File "/mnt/gen2/TmpDir/portage/dev-python/mako-0.7.0/work/Mako-0.7.0-2.5/test/test_template.py", line 923
    with open(outputpath, 'wb') as f:
            ^
SyntaxError: invalid syntax

----------------------------------------------------------------------
Ran 271 tests in 1.106s

FAILED (SKIP=2, errors=1)
---------------------------------------------------------
Unset test.

archtester mako #  USE_PYTHON="2.5 2.6 2.7 3.1 3.2" emerge mako
>>> Emerging (1 of 1) dev-python/mako-0.7.0
>>> Installing (1 of 1) dev-python/mako-0.7.0

I'm not sure how to adjust this.  Python2.5 only misfires on a test or two.  It compiles without running the test suite.  I still think distutils eclass doesn't allow for pypy.  Can you restrict python2.5 only for FEATURES=test?
Is the var DISTUTILS_DISABLE_TEST_DEPENDENCY appropriate??

otherwise, good to go.
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2012-04-11 11:14:22 UTC
Patch to do a from __future__ import with_statement? And report upstream...
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2012-04-11 13:05:37 UTC
done;

archtester mako # USE_PYTHON="2.5 2.6 2.7 3.2" ebuild mako-0.7.0.ebuild clean prepare test

 * Testing of dev-python/mako-0.7.0 with CPython 2.5...
PYTHONPATH=build/lib nosetests --verbosity=1 -P -w test
Ran 337 tests in 1.428s
OK (SKIP=2)

 * Testing of dev-python/mako-0.7.0 with CPython 2.6...
PYTHONPATH=build/lib nosetests --verbosity=1 -P -w test
Ran 337 tests in 1.384s
OK (SKIP=2)

 * Testing of dev-python/mako-0.7.0 with CPython 3.2...
PYTHONPATH=build/lib nosetests --verbosity=1 -P -w test
Ran 337 tests in 1.715s
OK (SKIP=4)
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2012-04-11 13:06:47 UTC
Created attachment 308517 [details, diff]
files/mako-test.patch
Comment 4 Patrick Lauer gentoo-dev 2012-04-15 04:47:33 UTC
+  15 Apr 2012; Patrick Lauer <patrick@gentoo.org> +files/test-fix.patch,
+  +mako-0.7.0.ebuild:
+  Bump for #411573