Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410991 - app-text/mupdf : add prefix support
Summary: app-text/mupdf : add prefix support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-06 04:15 UTC by Palmer Dabbelt
Modified: 2012-04-07 18:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Allows mupdf to be built in a prefix (mupdf-0.9.ebuild.patch,612 bytes, patch)
2012-04-06 04:18 UTC, Palmer Dabbelt
Details | Diff
Allows mupdf to be built in a prefix (and sets EAPI=3) (mupdf.patch,863 bytes, patch)
2012-04-07 15:16 UTC, Palmer Dabbelt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Palmer Dabbelt 2012-04-06 04:15:29 UTC
I'm unable to install app-text/mupdf on my prefix beacuse it installs files outside the prefix.

Reproducible: Always

Steps to Reproduce:
1.  Setup a gentoo prefix
2.  "emerge app-text/mupdf"

Actual Results:  
The install phase fails with an error about attempting to install files outside of the prefix.  I can reproduce the exact error if necessary, but I think it's a pretty common -- I've seen the same error a few times before.

Expected Results:  
The emerge succeeds.

I believe the correct fix is to use ED instead of D inside src_install().  I've changed the ebuild in my personal overlay and it seems to work OK for me.

I'll attach a patch for the ebuild.  If I understand correctly this shouldn't be specific to the prefix tree, as ED should just be D outside of prefix installs.
Comment 1 Palmer Dabbelt 2012-04-06 04:18:03 UTC
Created attachment 307955 [details, diff]
Allows mupdf to be built in a prefix
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-04-06 12:29:41 UTC
FYI: If an ebuild doesn't have any prefix keywords it has never been tested on Gentoo Prefix and probably needs mods to work. Patch looks good but you didn't add your own keyword that you tested on.
Comment 3 Palmer Dabbelt 2012-04-06 14:17:47 UTC
(In reply to comment #2)
> FYI: If an ebuild doesn't have any prefix keywords it has never been tested
> on Gentoo Prefix and probably needs mods to work.

OK, that would make sense.  I've been adding a few packages to my package.keywords with

dir-name/package-name **

and many of them seem to be working for me (some with a little bit of hackery).  Should I be filing bugs to say these packgaes work?

> Patch looks good but you
> didn't add your own keyword that you tested on.

$ emerge --info | grep KEYWORD
ACCEPT_KEYWORDS="~amd64-linux"

If it matters my prefix is hosted on a RHEL 5 box with a Core i7 in it.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-04-06 14:20:15 UTC
> Should I be filing bugs to say these packgaes work?

Yes.
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-04-06 14:21:13 UTC
Michael, this patch looks good to me. Please commit or I can too, let me know.
Comment 6 Michael Weber (RETIRED) gentoo-dev 2012-04-06 17:18:28 UTC
+  06 Apr 2012; Michael Weber <xmw@gentoo.org> mupdf-0.9.ebuild,
+  mupdf-0.9_p20120221.ebuild, mupdf-9999.ebuild:
+  Add prefix support (thanks Palmer Dabbelt, bug 410991)
+
Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-04-07 12:28:31 UTC
Hi. You need to revert your change to mupdf-0.9 (or change it to EAPI>=3)
Comment 8 Palmer Dabbelt 2012-04-07 15:16:36 UTC
Created attachment 308095 [details, diff]
Allows mupdf to be built in a prefix (and sets EAPI=3)

(In reply to comment #7)
> Hi. You need to revert your change to mupdf-0.9 (or change it to EAPI>=3)

I'm not sure if this was aimed at me or not (I definately don't actually have commit access, so I can't revert anything), but I've attached a new patch that changes the EAPI to 3.
Comment 9 Michael Weber (RETIRED) gentoo-dev 2012-04-07 18:12:12 UTC
(In reply to comment #7)
> Hi. You need to revert your change to mupdf-0.9 (or change it to EAPI>=3)

+  07 Apr 2012; Michael Weber <xmw@gentoo.org> mupdf-0.9.ebuild,
+  mupdf-0.9_p20120221.ebuild, mupdf-9999.ebuild:
+  Fix prefix support (EAPI-4), thanks Jeremy for pointing me on the error.
+  

(In reply to comment #8)
> Created attachment 308095 [details, diff] [details, diff]
> Allows mupdf to be built in a prefix (and sets EAPI=3)
thanks, did it myself.

> I'm not sure if this was aimed at me or not (I definately don't actually
> have commit access, so I can't revert anything), but I've attached a new
> patch that changes the EAPI to 3.
That was meant for me, I've borked the ebuild.
Comment 10 Michael Weber (RETIRED) gentoo-dev 2012-04-07 18:13:40 UTC
Yes, I'm aware of editing a stabled ebuild which is needed by llpp (maint by me), it's all my fault.