Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410739 - sys-kernel/module-rebuild should be tree cleaned
Summary: sys-kernel/module-rebuild should be tree cleaned
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Kernel Miscellaneous
URL:
Whiteboard: Removal at Sat 1 Feb 2014
Keywords: PMASKED
Depends on: 440852 471820
Blocks: 112423 130127 186486 310325 359151 392247 410923
  Show dependency tree
 
Reported: 2012-04-04 01:51 UTC by Richard Yao (RETIRED)
Modified: 2014-02-03 11:19 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Yao (RETIRED) gentoo-dev 2012-04-04 01:51:23 UTC
Following a kernel upgrade, I ran `module-rebuild rebuild`, which attempted to merge modules in the sequence stated:

# module-rebuild rebuild
** Preparing to merge modules:
** Packages which I will emerge are:
        =sys-fs/zfs-9999
        =sys-block/iscsitarget-1.4.20.2_p20120401
        =net-misc/r8168-8.028.00
        =sys-kernel/spl-9999

sys-fs/zfs depends on sys-kernel/spl, which caused the sys-fs/zfs build to fail.
Comment 1 Richard Yao (RETIRED) gentoo-dev 2012-04-23 00:30:34 UTC
In some situations, I am finding that modules fail to load at boot because they do not agree on the symbol versions. I assume that is caused by module-rebuild compiling things in the wrong order. I am increasing the importance of this to Major.
Comment 2 Richard Yao (RETIRED) gentoo-dev 2012-11-28 06:49:07 UTC
sys-kernel/module-rebuild does not do dependency calculations. This causes symbol version issues for ZFS users when sys-kernel/spl and sys-fs/zfs are rebuilt out-of-order. We have `emerge @module-rebuild` in Gentoo stable as of 2.1.11.31, which resolves this issue.

A few architectures have yet to stabilize it. When they do, I believe that sys-kernel/module-rebuild should be masked for tree cleaning.
Comment 3 Pacho Ramos gentoo-dev 2013-02-14 20:27:44 UTC
Probably:
http://www.gentoo.org/doc/en/kernel-upgrade.xml#doc_chap6

Needs to be changed, I am also unsure about how pkgcore/paludis users will handle this situation is module-rebuild goes away (apart of that, I don't have any problem on treecleaning it, I am also using now portage set ;))
Comment 4 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-02-27 17:11:48 UTC
It looks like that version of portage is stable (for stable arches).  tree clean?
Comment 5 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-05-23 20:30:41 UTC
(In reply to comment #3)
> Probably http://www.gentoo.org/doc/en/kernel-upgrade.xml#doc_chap6 needs to be changed

Can do that, but I'm not sure if I'm allowed to touch this document. I'll ask around, stay tuned...

> I am also unsure about how pkgcore

pkgcore appears to be dead, snippet of #pkgcore IRC log on 2013-05-16:

> devurandom | Hello!
> devurandom | Any recent advances regarding EAPI5 and a new pkgcore release?
> Philantrop | devurandom: http://bpaste.net/raw/98158/ <-- IOW: That's it.
> devurandom | Philantrop: So it's dead?
> Philantrop | devurandom: Yes, that's how I understand what was said here.
> @ferringb  | heh
> @ferringb  | Philantrop: that quote isn't quite the whole story; more, I'm just done, doing other things with my time now 

Quite unfortunate, I'm not sure if someone will pick it up.

> paludis users will handle this situation is module-rebuild goes away

CC-ed such that they are given at least a heads-up.

> (apart of that I don't have any problem on treecleaning it, I am also using now portage set ;))

Is anything holding it back from being treecleaned besides the doc change?
Comment 6 Ciaran McCreesh 2013-05-23 21:02:05 UTC
Someone produced a set for Paludis that does the same thing. Dunno if anyone uses it...
Comment 7 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-11-16 23:56:23 UTC
Above documentation change has since happened.

Is there any other usage case or documentation still blocking this?

If not, I think we can start with a package.mask just to be on the safe side and have people report back if there are still such cases.
Comment 8 Harris Landgarten 2013-12-28 17:59:24 UTC
I use module-rebuild with paludis as part of my kernel upgrade script. I only need to rebuild nvidia-modules and vmeare-modules so not a big loss but it is useful.
Comment 9 ahudson.news 2014-01-03 00:51:15 UTC
I always had trouble with module-rebuild forgetting certain packages, notably x11-drivers/xf86-video-virtualbox, so any improvement is good. emerge @module-rebuild doesn't appear to have that problem.

*However* the old module-rebuild has the distinct advantage of rebuilding exactly the same version (unless told otherwise), while "emerge @module-rebuild" updates to the newest version fulfilling all the other dependencies. This sounds like it will cause trouble (at the very least, it throwing warnings "WARNING: One or more updates have been skipped due to a dependency conflict: [...]").
Comment 10 Nikolaj Šujskij 2014-01-31 11:48:36 UTC
(In reply to ahudson.news from comment #9)
> *However* the old module-rebuild has the distinct advantage of rebuilding
> exactly the same version (unless told otherwise), while "emerge
> @module-rebuild" updates to the newest version fulfilling all the other
> dependencies. This sounds like it will cause trouble (at the very least, it
> throwing warnings "WARNING: One or more updates have been skipped due to a
> dependency conflict: [...]").
Easily fixable by masking versions above needed, ain't it?
Comment 11 ahudson.news 2014-02-03 10:54:02 UTC
(In reply to Nikolaj Sjujskij from comment #10)
> Easily fixable by masking versions above needed, ain't it?

Well, sort of. But masking/unmasking just for this is painful enough that even in the best case it will lead to:

# emerge -pv @module-rebuild
# emerge -av1 =module-1 =module-2 [...]

being used instead. I guess it is just a question of different expectations, with regard to what "rebuild" means as opposed to "upgrade".

It is not like we don't want to upgrade (consciously & safely) at a later point in time, but letting @module-rebuild upgrade the entire VirtualBox dependency hierarchy while there are running instances is actually kind of dangerous.

But again, it's not a blocker for removing this dead package; it's just a usability issue with the replacement functionality ;)
Comment 12 Nikolaj Šujskij 2014-02-03 11:02:58 UTC
(In reply to ahudson.news from comment #11)
> It is not like we don't want to upgrade (consciously & safely) at a later
> point in time, but letting @module-rebuild upgrade the entire VirtualBox
> dependency hierarchy while there are running instances is actually kind of
> dangerous.
Ah, I see the point (never used VB, really).
In that case you can report that issue of @module-rebuild.