Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410501 - app-cdr/cdrtools-3.01_alpha07: gettext dependency should be split into libintl/gettext
Summary: app-cdr/cdrtools-3.01_alpha07: gettext dependency should be split into libint...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 03:39 UTC by Maxim Kammerer
Modified: 2013-04-28 01:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Kammerer 2012-04-02 03:39:11 UTC 
gettext dependency should probably be split into libintl/gettext in
RDEPEND/DEPEND, like in many other packages.
Comment 1 Maxim Kammerer 2012-04-02 03:42:44 UTC 
PS. Perhaps a tracker should be created for this issue? Similar bugs that were not fixed yet: bug #398983, bug #398975, bug #398977.
Comment 2 Maxim Kammerer 2013-01-01 22:50:29 UTC 
Ping?
Comment 3 Daniel Pielmeier gentoo-dev 2013-01-02 17:02:50 UTC 
+  02 Jan 2013; Daniel Pielmeier <billie@gentoo.org>
+  cdrtools-3.01_alpha10.ebuild:
+  Split gettext and libintl dependency according to bug #410501. Thanks to
+  Maxim Kammerer for the report.
Comment 4 Maxim Kammerer 2013-01-02 17:14:07 UTC 
Thank you!
Comment 5 Maxim Kammerer 2013-01-03 09:09:57 UTC 
Sorry, the fix is incorrect:

DEPEND="acl? ( virtual/acl )
    nls? ( >=sys-devel/gettext-0.18.1.1 )
    !app-cdr/cdrkit"
RDEPEND="${DEPEND}
    nls? ( virtual/libintl )"

Note the ${DEPEND} reference -- RDEPEND and DEPEND were the same previously.

Maybe use something like the following instead:

RDEPEND="acl? ( virtual/acl )
    nls? ( virtual/libintl )
    !app-cdr/cdrkit"
DEPEND="${RDEPEND}
    nls? ( >=sys-devel/gettext-0.18.1.1 )"
Comment 6 Daniel Pielmeier gentoo-dev 2013-01-03 10:42:02 UTC 
(In reply to comment #5)
> Sorry, the fix is incorrect:
> 
> DEPEND="acl? ( virtual/acl )
>     nls? ( >=sys-devel/gettext-0.18.1.1 )
>     !app-cdr/cdrkit"
> RDEPEND="${DEPEND}
>     nls? ( virtual/libintl )"
> 
> Note the ${DEPEND} reference -- RDEPEND and DEPEND were the same previously.
> 
> Maybe use something like the following instead:
> 
> RDEPEND="acl? ( virtual/acl )
>     nls? ( virtual/libintl )
>     !app-cdr/cdrkit"
> DEPEND="${RDEPEND}
>     nls? ( >=sys-devel/gettext-0.18.1.1 )"

You are right! My commit does not change anything at all. gettext is in still both DEPEND and RDEPEND. I will fix this as soon as possible.
Comment 7 Daniel Pielmeier gentoo-dev 2013-01-03 16:06:49 UTC 
+  03 Jan 2013; Daniel Pielmeier <billie@gentoo.org>
+  cdrtools-3.01_alpha10.ebuild:
+  Correct fix for Bug #410501.

I hope I got it right this time.
Comment 8 Maxim Kammerer 2013-01-03 21:00:31 UTC 
Seems so, thanks! I will test later and reopen in case of a problem.