Next list of ebuilds has duplication in use flags app-emulation/libguestfs/libguestfs-1.8.16.ebuild net-firewall/ipsec-tools/ipsec-tools-0.7.3.ebuild net-firewall/ipsec-tools/ipsec-tools-0.7.3-r1.ebuild net-print/pykota/pykota-1.25_p2437-r1.ebuild net-print/pykota/pykota-1.26.ebuild net-proxy/c-icap/c-icap-0.1.7.ebuild sci-libs/vtk/vtk-5.8.0.ebuild Next one has invald? iuse line dev-python/pyprof2calltree/pyprof2calltree-1.1.0.ebuild Reproducible: Always
(In reply to comment #0) > Next list of ebuilds has duplication in use flags > > app-emulation/libguestfs/libguestfs-1.8.16.ebuild Lists nls twice. Fixed. > net-firewall/ipsec-tools/ipsec-tools-0.7.3.ebuild > net-firewall/ipsec-tools/ipsec-tools-0.7.3-r1.ebuild List selinux twice. Fixed. > net-print/pykota/pykota-1.25_p2437-r1.ebuild > net-print/pykota/pykota-1.26.ebuild Lists snmp twice. Fixed. > net-proxy/c-icap/c-icap-0.1.7.ebuild Lists ldap twice. Fixed. > sci-libs/vtk/vtk-5.8.0.ebuild Lists tk twice. Fixed. > Next one has invald? iuse line > > dev-python/pyprof2calltree/pyprof2calltree-1.1.0.ebuild No, that's merely empty. Is this causing a problem for you? If so, please state how.
> > Next one has invald? iuse line > > > > dev-python/pyprof2calltree/pyprof2calltree-1.1.0.ebuild > > No, that's merely empty. Is this causing a problem for you? If so, please > state how. No, it does not cause issues for me. I do not running gentoo right now but playing a bit with portage I supposed it should be like this IUSE='' I saw lots of ebuilds with '' (empty quotes), but only that one is 'empty'. if its not hard and does not break anything - please fix (it will allow to drop one more workaround in my code :) ) Thanks
jer@astrid /newaches/gentoo/cvs/gentoo-x86 $ grep '^IUSE=$' */*/*.ebuild dev-python/pyprof2calltree/pyprof2calltree-1.1.0.ebuild:IUSE= That's the single ebuild in the tree that does this.
I'm not sure what sort of program you've written, but it should probably handle this case.
Ebuilds are bash. Is there a difference to bash between |IUSE=|, |IUSE=""| and/or |IUSE=''|? If there is, or there is some other QA-related reason for preferring one over the other, please add a repoman check. Without such a check I see very little point in "fixing" this ebuild, as without any clear reason not to the same "mistake" may be made in the future. (what are you needing to "work around" in your code? If you use a package manager to get at IUSE, which you will have to do anyway to get any of them doing something nontrivial to generate IUSE right, IUSE= should work just fine. If you are parsing ebuilds directly without using bash: stop doing that.)
(In reply to comment #5) > Ebuilds are bash. Is there a difference to bash between |IUSE=|, |IUSE=""| > and/or |IUSE=''|? If there is, or there is some other QA-related reason for > preferring one over the other, please add a repoman check. Without such a > check I see very little point in "fixing" this ebuild, as without any clear > reason not to the same "mistake" may be made in the future. I am not a gentoo team member. You do not have any strong reason to replace |IUSE=| with |IUSE=""| or |IUSE=''|. As for me I see couple of reasons (but still they are minor) to do that: * all other ebuilds use quotes * I did not check it myself but I read somewhere that vim on creation ebuild stub uses form with quotes As for point of "fixing" this ebuild. We have couple thousands of ebuilds with quotes and one(!) without. Does that make big difference if it will be added to group where there thousands? I think no. Besides having them all in single format will help to do a batch processing in case it will be required. > (what are you needing to "work around" in your code? If you use a package > manager to get at IUSE, which you will have to do anyway to get any of them > doing something nontrivial to generate IUSE right, IUSE= should work just > fine. If you are parsing ebuilds directly without using bash: stop doing > that.) Yes, I am trying to do a partial parse of ebuilds without bash (actually its a part of work that I am doing.) I know that gentoo devs are not supporting that things. I will not stop until I face with issues that _really can not be solved_ or reach the target. In any case while I am doing my work I help you make tree cleaner (I hope it looks same from your POV). As for workaround I was wrong. I turns out that I had a bug as for this in my code. Thanks ps: sorry for a bit offtop
I now aware what type of checks repoman has, but can we have a if use flags are not duplicated in IUSE var?
(In reply to comment #7) > I now aware Means "I do not aware"
If you're parsing ebuilds with bash, this is not a problem. If you're parsing ebuilds without bash, it should be easy enough to work around. This is not a useful topic to have gentoo devs spend time on. I'm closing it.
(In reply to comment #9) > If you're parsing ebuilds with bash, this is not a problem. If you're > parsing ebuilds without bash, it should be easy enough to work around. This > is not a useful topic to have gentoo devs spend time on. I'm closing it. I am ok with it but what about my question: > I am not aware what type of checks repoman has, but can we have a check if use flags > are not duplicated in IUSE var?
I don't think it's worth spending time on. But if you write a patch for repoman and attach it to a new bug, maybe it will be considered.
