408145 – dev-python/ply: suspicious src_test

Bug 408145 - dev-python/ply: suspicious src_test

Summary: dev-python/ply: suspicious src_test

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Development (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Python Gentoo Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-03-14 10:26 UTC by Paweł Hajdan, Jr. (RETIRED)
Modified:	2012-04-04 10:16 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paweł Hajdan, Jr. (RETIRED) gentoo-dev

2012-03-14 10:26:35 UTC

I noted following snippet in ply ebuild:

  for test in testlex.py testyacc.py; do
      einfo "Running ${test}..."
      if ! "$(PYTHON)" testlex.py; then
          ewarn "${test} failed with $(python_get_implementation) $(python_get_version)"
          exit_status="1"
      fi 
  done

Shouldn't

  if ! "$(PYTHON)" testlex.py; then

rather be

  if ! "$(PYTHON)" "${test}"; then

?

Comment 1 Patrick Lauer gentoo-dev

2012-03-16 07:29:46 UTC

+  16 Mar 2012; Patrick Lauer <patrick@gentoo.org> ply-3.4.ebuild:
+  Test fix for #408145


Fair enough :)