Bugzilla Bug 40711

2.4.4.6 was a bug fix release
2.4.4.7 only change is the infamous intltool 0.28 bug fix

Wed Dec 31 10:09:23 2003  George Lebl <jirka@5z.com>

	* Release 2.4.4.7

Wed Dec 31 09:57:18 2003  George Lebl <jirka@5z.com>

	* Makefile.am: add the damn OrigTree.pm file here to make intltool
	  happy

Mon Dec 29 16:03:06 2003  George Lebl <jirka@5z.com>

	* Release 2.4.4.6

Thu Dec 04 17:01:21 2003  Leena Gunda <leena.gunda@wipro.com>

	* daemon/verify-pam.c:
	  pass the time in microseconds to pam_fail_delay().
	  Fixes bug #128507

Fri Dec 19 16:40:23 2003  George Lebl <jirka@5z.com>

	* daemon/gdm.c: move the setegid to before the seteuid to fix an
	  assert failure.  Fixes #127780

Fri Dec 12 09:36:34 2003  George Lebl <jirka@5z.com>

	* gui/gdmcomm.c: check ownership of /tmp/.gdm_socket before using

Wed Dec 10 15:33:09 2003  George Lebl <jirka@5z.com>

	* daemon/display.c: Fix #126465 where xdmcp_sessions would not
	  get decremented on normal logout.  Doh!  Just do a recount of
	  all the limits on display dispose that is just a lot more robust.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Created an attachment (id=25446) [edit]
updated ebuild from gdm-2.4.4.5, restore gentoo-emergence theme back.

I modify the 2.4.4.5 ebuild from portage with some lines taken from previous
2.4.1.7 ebuild, and restoring back the gentoo-emergence theme.

While found the SELinux compile option, do not add it, since I do not see a
standard SELinux USE FLAG, so that was not included, but can be modified with
the info found here:  http://bugs.gentoo.org/show_bug.cgi?id=41022

Test it, but at lest it worked for me

Created an attachment (id=25447) [edit]
revised ebuild, remove a line not need

I actually intended to add another theme (the cow one) as default from now on.
selinux support was requested somewhere else and there is a USE flag or FEATURE
(?). Can you provide a 'diff -u' version of your changes so i can check them
out more easily ?

Created an attachment (id=25491) [edit]
gdm-2.4.4.5.ebuild to gdm-2.4.4.7.ebuild diff

This is a diff against gdm-2.4.4.5.ebuild found on portage.  Lines added were
taken from gdm-2.4.1.7-r1.ebuild also on portage.

for selinux there is a config option, but since ufed do not show me a local or
global selinux flag I just ignore it for the time being.

selinux flag got added on request of the selinux team in bug #41022 . Did
recheck the patch, but it introduces a lot of stuff that i meant to clean out
in the initial 2.4.4 ebuild, part of it has no function at all anymore. So i
did some smallish fixes based on it and added a new theme (gentoo-cow), please
feedback on that.

In general i'm not too happy about the way we provide a gentoo theme now, it's
not easily updated with improved translations. Best would be to create small
auto* generated theme and work with that, keep it in our own hands and not just
copy without a clue from other distros. I'm afraid we're going to get
regressions this way.

Adding other WMs on CC : the gdm session scheme has changed. Session .desktop's
now go into /usr/share/xsession . Please adapt your ebuilds to follow this
scheme for the benefit of your users (as i understand it, gdm is a favorite
login manager). You can contact me on why & how (not that i'm an expert) or
check the homepage, which has some good docs. As far as i understand it kdm is
set to follow a similar scheme, so in the end it will be used by more than gdm
alone. Of course leave current session schemes for gdm in place for
compatability with older gdm releases. This release of GDM will stay in
package.mask for another week or so for the WMs to add support.

ps. CC wm/de's i forgot as pleases.

ok last notice, i'm removing this from p.mask later tonight.

Openbox and Fluxbox are updated, others will follow.

Not sure what has to be done for KDE, especially since I don't use kdm, but I'm
sure someone will figure it out or start screaming eventually :)

Created an attachment (id=27277) [edit]
add kde.desktop or a varient of it to  /usr/share/xsessions

this is file is needed to add a selection for kde to the desktop menu ..

this one is fixed to use kde 3.2  .. adapt to suit one will be required for
each version of kde installed

it works 

by the way that's to add a kde item to the gdm session menu selections

Looks like the changes are now in for XFCE4, cross off another popular one.

*** Bug 45050 has been marked as a duplicate of this bug. ***

This is on someone else's shoulders - I don't use kdm.

Created an attachment (id=27566) [edit]
Updated kde.desktop

Updated kde.desktop to run the session from /etc/X11/Sessions as some people
(like me) put extra commands in the session file before startkde.

caleb, your comment doesn't make much sense (?)

My gdm still hapilly gives the sessions that exist in /etc/X11/gdm/sessions
which is just a symlink to /etc/X11/sessions

so whats the deal here kde ? is it done or not ?

Quote from gdm download directory: "LATEST-IS-2.6.0.1"

we know

It seems that the latest kdm and gdm versions have finally found some common
ground. Both use desktop files for starting and describing sessions. Further
both use a (their own) Xsession script for starting the sessions. These scripts
include functions that source /etc/xprofile and ~/.xprofile, which is the place
to put things that should start before a session.

and HEY!!!!!!! KDE 3.2.2 STILL doesn't do it with latest gdm

You need a kde 3.2.2 .desktop for /usr/share/xsessions .
I'd attatch mine, but you've got some workable stuff here.  I've been
having this problem since 3.2.2 came out.  All you need is to version
bump the kde.desktop up to 3.2.2 and drop it into the files directory
of kde-base/kde-base, then fix the kde-base ebuild to install it.

It may be wise to have a default kde xsession that just runs whatever
startkde is in your path as well.

*** Bug 52523 has been marked as a duplicate of this bug. ***

The gdm ebuild dropping an entry in /usr/share/xsessions for each wm
is not the way to go IMO.

kdm fills /usr/kde/3.2/share/config/kdm/sessions/ with .desktop entry
by itself, reading the content of /etc/X11/Sessions/. It does that
through /usr/kde/3.2/share/config/kdm/Xsetup:
http://www.gentoo.org/cgi-bin/viewcvs.cgi/kde-base/kdebase/files/3.2.3/Xsetup?rev=1.1&content-type=text/vnd.viewcvs-markup

maybe gdm should do something similar, not ignoring what's
in /etc/X11/Sessions/?

or (long term solution)

we can start patching the wm ebuilds to drop .desktop entry 
in /etc/X11/Sessions/ instead of the executable files they install now.
In this way kdm and gdm could just point there.

see also bug 45050, bug 47074

I researched all this for myself before I became aware of this bug :-/
This is what I'm going to do to kdm, as posted to kde@g.o this morning,
unless someone complains within a few days:
- Install .desktop into /usr/share/xsessions
- Use .desktop files from there, not from $KDEDIR/share/config/kdm/sessions
- Drop the custom Xsession that generates files in
$KDEDIR/share/config/kdm/sessions based on /etc/X11/Sessions, because we
shouldn't be writing to /usr anyway (bug 15315)
This means /etc/X11/Sessions will be completely disregarded. Ditto for 
/etc/X11/dm/sessions - only e16 seems to use that dir for .desktop files.
- One day when we get rid of old kde versions (<3.3.0), the kdm-specific code
in /etc/X11/xdm/Xsetup_0 (installed by any xfree/xorg-x11 ebuild) should be 
dropped.

---

Re: comment #24: I don't see why we should use /etc/X11/Sessions
if /usr/share/xsessions is ineded more standard.