Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 407089 - app-admin/conky[lua] + lua-5.2.0: Failes to link
Summary: app-admin/conky[lua] + lua-5.2.0: Failes to link
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lua-5.2
  Show dependency tree
 
Reported: 2012-03-06 10:39 UTC by Amadeusz Żołnowski (RETIRED)
Modified: 2012-03-10 07:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
conky-build.log (build.log,37.36 KB, text/plain)
2012-03-06 10:40 UTC, Amadeusz Żołnowski (RETIRED) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amadeusz Żołnowski (RETIRED) gentoo-dev 2012-03-06 10:39:14 UTC 
conky fails to link with lua-5.2.0:

llua.c:(.text+0x633): undefined reference to `lua_open'

Reproducible: Always
Comment 1 Amadeusz Żołnowski (RETIRED) gentoo-dev 2012-03-06 10:40:32 UTC 
Created attachment 304383 [details]
conky-build.log
Comment 3 Daniel Pielmeier gentoo-dev 2012-03-07 19:32:11 UTC 
@Brenden. Wow that was quick. From reading the code of lua-5.1 and 5.2 this patch should be backward compatible. lua_open was a compatibility function which called luaL_newstate which had been removed in lua-5.2.
Comment 4 Daniel Pielmeier gentoo-dev 2012-03-07 20:01:21 UTC 
@Brenden. Shouldn't this be fixed in master as well?
Comment 5 Brenden Matthews 2012-03-07 20:02:52 UTC 
(In reply to comment #4)
> @Brenden. Shouldn't this be fixed in master as well?

Nope, the code in master uses the new API.

See: http://git.omp.am/?p=conky.git;a=blob;f=src/luamm.cc;h=ffc68b03f9c422f1ab29f315cf3ebc2d49e68a68;hb=HEAD#l217
Comment 6 Daniel Pielmeier gentoo-dev 2012-03-07 20:29:40 UTC 
IC but there is a reference to lua_open in src/llua.cc [1]. Don't know if this matters.

[1] http://git.omp.am/?p=conky.git&a=search&h=HEAD&st=grep&s=lua_open
Comment 7 Brenden Matthews 2012-03-07 21:43:51 UTC 
(In reply to comment #6)
> IC but there is a reference to lua_open in src/llua.cc [1]. Don't know if
> this matters.
> 
> [1] http://git.omp.am/?p=conky.git&a=search&h=HEAD&st=grep&s=lua_open

You're right, my bad.

Cherry picked: http://git.omp.am/?p=conky.git;a=commit;h=19fc6e1a75ad9cb2c2f61e411a975e5beb89e88b
Comment 8 Daniel Pielmeier gentoo-dev 2012-03-10 07:21:23 UTC 
+  10 Mar 2012; Daniel Pielmeier <billie@gentoo.org> conky-1.8.1-r6.ebuild,
+  +files/conky-1.8.1-lua-5.2.patch:
+  Fix building against lua-5.2 (bug #407089). Thanks to Amadeusz Żołnowski
+  for the report and Brenden Matthews for the fix.