Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 406517 - dev-ml/menhir (new package)
Summary: dev-ml/menhir (new package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Default Assignee for New Packages
URL: http://cristal.inria.fr/~fpottier/men...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2012-03-02 05:25 UTC by Guillaume Horel
Modified: 2013-02-07 20:36 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
menhir-20120123.ebuild (menhir-20120123.ebuild,589 bytes, text/plain)
2012-03-02 05:26 UTC, Guillaume Horel
Details
menhir-20120123.ebuild (menhir-20120123.ebuild,772 bytes, text/plain)
2012-11-07 17:43 UTC, Jacques-Pascal Deplaix
Details
menhir-20130116.ebuild (menhir-20130116.ebuild,724 bytes, text/plain)
2013-01-25 02:57 UTC, Guillaume Horel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Horel 2012-03-02 05:25:24 UTC
Menhir is an LR(1) parser generator for the Ocaml language. It is mostly compatiable with ocamlyacc, which is part of the ocaml standard distribution, but contains many enhancements.
Comment 1 Guillaume Horel 2012-03-02 05:26:24 UTC
Created attachment 303919 [details]
menhir-20120123.ebuild
Comment 2 Jacques-Pascal Deplaix 2012-11-07 17:43:31 UTC
Created attachment 328724 [details]
menhir-20120123.ebuild

without some various bugs
Comment 3 Guillaume Horel 2012-11-07 23:41:19 UTC
Why do you install standard.mly into /usr/share/menhir?
Comment 4 Jacques-Pascal Deplaix 2012-11-11 18:37:58 UTC
(In reply to comment #3)
> Why do you install standard.mly into /usr/share/menhir?

Because without that, menhir will search for this file in /var/tmp/portage/dev-ml/…
Comment 5 Alexis Ballier gentoo-dev 2013-01-18 18:34:14 UTC
src_prepare() {
	export PREFIX="${D}/usr"
	sed -i 's,echo "let libdir = \\"${libdir}\\"" > src/installation.ml,echo "let libdir = \\"/usr/share/menhir\\"" > src/installation.ml,' Makefile
	if ! use ocamlopt ; then
		export TARGET=byte
	fi
}

-> All these are not prefix-friendly, but I'd prefer leaving this to some prefix people

and I don't like the sed: Can't you do emake PREFIX=${EPREFIX}/usr  in src_compile and then emake PREFIX=${ED}/usr install in src_install ?
(or just set the PREFIX variable)

setting the TARGET variable probably belongs to src_configure also

you should probably override the docdir variable too: so far its /usr/share/doc/menhir and we want /usr/share/doc/$PF

you should dodoc the AUTHORS and CHANGES files too.

and btw there's version 20130116 on the website
Comment 6 Guillaume Horel 2013-01-25 02:57:17 UTC
Created attachment 336792 [details]
menhir-20130116.ebuild

Update version. I tried to use all your suggestions, ebuild should be cleaner now.
Comment 7 Alexis Ballier gentoo-dev 2013-02-07 20:36:44 UTC
(In reply to comment #6)
> Created attachment 336792 [details]
> menhir-20130116.ebuild
> 
> Update version. I tried to use all your suggestions, ebuild should be
> cleaner now.

added with some improvements, thanks