Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 406053 - elisp-common.eclass and xemacs-elisp-common.eclass namespace collision (was: app-admin/puppet installs xemacs files instead of emacs files)
Summary: elisp-common.eclass and xemacs-elisp-common.eclass namespace collision (was: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XEmacs team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 17:29 UTC by Tom Prince
Modified: 2012-05-19 16:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge --info (emerge.info,15.22 KB, text/plain)
2012-02-27 17:29 UTC, Tom Prince 		Details
build.log (build.log,261.44 KB, text/plain)
2012-02-27 17:34 UTC, Tom Prince 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Prince 2012-02-27 17:29:33 UTC 
Created attachment 303517 [details]
emerge --info

/usr/share/xemacs is created and populated, while nothing is put in /usr/share/emacs
Comment 1 Tom Prince 2012-02-27 17:34:44 UTC 
Created attachment 303519 [details]
build.log
Comment 2 MATSUU Takuto (RETIRED) gentoo-dev 2012-03-14 17:55:11 UTC 
Fixed in cvs.
Comment 3 Ulrich Müller gentoo-dev 2012-04-05 14:09:58 UTC 
Why has nobody CCed the emacs and xemacs teams here?

The problem lies deeper, elisp-common.eclass and xemacs-elisp-common.eclass both assign the SITELISP variable. Probably one of them (at least) should rename it.

AFAICS, xemacs-common.eclass is inherit by the following packages only:
   app-admin/puppet
   app-xemacs/gentoo-syntax
   sci-mathematics/octave
Out of these, only puppet-2.7.12.ebuild uses the SITELISP variable directly.

@graaff: Would it be possible for you to rename the variable in xemacs-elisp-common.eclass? (And maybe rename SITEPACKAGE too, for consistency?) Renaming it in elisp-common.eclass would require many times more effort, because it is inherited by some 500 ebuilds.
Comment 4 Hans de Graaff gentoo-dev Security 2012-04-07 08:48:08 UTC 
(In reply to comment #3)

> @graaff: Would it be possible for you to rename the variable in
> xemacs-elisp-common.eclass? (And maybe rename SITEPACKAGE too, for
> consistency?) Renaming it in elisp-common.eclass would require many times
> more effort, because it is inherited by some 500 ebuilds.

Sure, that sounds like the best solution. I'll see if I can find some time for that this weekend.
Comment 5 Ulrich Müller gentoo-dev 2012-05-19 16:30:04 UTC 
Fixed in xemacs-elisp-common.eclass, as discussed in IRC:
SITELISP is now XEMACS_SITELISP,
SITEPACKAGES is now XEMACS_SITEPACKAGES.

I've also changed the app-admin/puppet-2.7.{12,13} ebuilds accordingly.
Comment 6 Ulrich Müller gentoo-dev 2012-05-19 16:31:30 UTC 
(In reply to comment #5)
> SITEPACKAGES is now XEMACS_SITEPACKAGES.

This should read "SITEPACKAGE" and "XEMACS_SITEPACKAGE".