Created attachment 302701 [details, diff] 2mandvd-1.7.3.ebuild.patch 2mandvd-1.7.3 is now available. The attached patch: - Bumps EAPI - Adds new language - Removes manual unpack as the noisy issue no longer exists - Makes ffmpeg a build dep, as it is linked against - Converted mad and xine use flags into elog messages, as they do not affect the installed files in any way
This looks good. I have a couple of questions though. The first one is more of an upstream issue: why optional use of xine-lib and sox[mad] if it already depends on ffmpeg? Doesn't that provide pretty much the same functionality? Also, can we use virtual/ffmpeg instead of media-video/ffmpeg? (I'm a libav user myself) And does it really need media-fonts/dejavu or can we use virtual/ttf-fonts instead (which defaults to dejavu)?
Created attachment 302915 [details, diff] 2mandvd-1.7.3.ebuild.patch (In reply to comment #1) > why optional use of xine-lib and sox[mad] if it already > depends on ffmpeg? Doesn't that provide pretty much the same functionality? I am not sure, but both those binaries are called directly. > Also, can we use virtual/ffmpeg instead of media-video/ffmpeg? (I'm a libav > user myself) It fails to compile with libav, but a small patch fixes that. > And does it really need media-fonts/dejavu or can we use virtual/ttf-fonts > instead (which defaults to dejavu)? Dejavu fonts are called explicitly, eg. myfont.setFamily("DejaVu Sans Condensed");
Created attachment 302917 [details, diff] 2mandvd-1.7.3-libav.patch
Committed. Thanks a lot Michael!
