Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 403003 - x11-drivers/xf86-input-joystick should install /usr/share/X11/xorg.conf.d/50-joystick-all.conf
Summary: x11-drivers/xf86-input-joystick should install /usr/share/X11/xorg.conf.d/50-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL: http://cgit.freedesktop.org/xorg/driv...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-02-10 16:42 UTC by Maxim Kammerer
Modified: 2013-01-03 20:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xf86-input-joystick-1.6.1.diff (xf86-input-joystick-1.6.1.diff,615 bytes, text/plain)
2013-01-02 00:02 UTC, Maxim Kammerer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Kammerer 2012-02-10 16:42:32 UTC
Any reason 50-joystick-all.conf is not installed by the ebuild? It seems that this file can be installed as-is after

    # UNCOMMENT TO ENABLE HOTPLUGGING OF JOYSTICKS
Comment 1 Maxim Kammerer 2013-01-01 23:09:36 UTC
Ping?
Comment 2 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-01-01 23:28:33 UTC
Maybe if you submit a patch for the ebuild it will go faster.
Comment 3 Maxim Kammerer 2013-01-02 00:02:06 UTC
Created attachment 334000 [details]
xf86-input-joystick-1.6.1.diff

Ebuild patch attached.
Comment 4 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-01-02 11:06:51 UTC
Ok for the src_install() part, but not for patching 50-joystick-all.conf.
If you want the latter changed, take it to upstream.
Comment 5 Maxim Kammerer 2013-01-02 12:25:19 UTC
The patch uncomments the lines marked with

# UNCOMMENT TO ENABLE HOTPLUGGING OF JOYSTICKS
#   Driver "joystick"
#   MatchIsJoystick "on"
#   MatchDevicePath "/dev/input/event*"

I don't see what this has to do with upstream. If you want xf86-input-joystick installed with hotplugging by default, uncomment the lines. If not, don't. Other packages have hotplugging enabled by default. E.g.: xf86-input-synaptics, xf86-input-vmmouse. Since users in Gentoo usually install packages on their own, I don't see how hotplugging can hurt.
Comment 6 Maxim Kammerer 2013-01-02 12:27:50 UTC
I.e., hotplugging in this context means not having to fiddle with xorg.conf to enable support for the device. Since Xorg moves to not having xorg.conf at all, that's the only reasonable choice.
Comment 7 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-01-02 13:12:27 UTC
1.6.1-r1 now installs the configuration snippet to /usr/share/X11/xorg.conf.d

Regarding the modifications of 50-joystick-all.conf, we are not keen on carrying patches that have not been accepted upstream, so you will have to get it merged there first.
Comment 8 Sascha Hlusiak 2013-01-03 17:20:14 UTC
As maintainer of xf86-input-joystick I recommend not enabling it without explicit user consent because most users have the input module installed "accidentially" (by default, all input modules, global joystick useflag or whatever pulls that in) without knowing what it is good for or even that they have it installed.

Because the module is usually installed by default, I decided it to not harm the usual usecase of a joystick: playing games. Disabling a feature when you don't know what provides it, is not fun. E.g. Ubuntu has it enabled by default and when you enter the right keywords in google, all resources are about uninstalling the module.

Besides that, the default configuration probably doesn't suit most people anyway, so they  already need to edit the configuration file.

Better provide the relevant documentation to the user after installing the ebuild.
Comment 9 Maxim Kammerer 2013-01-03 20:54:53 UTC
(In reply to comment #8)
> Because the module is usually installed by default, I decided it to not harm
> the usual usecase of a joystick: playing games. Disabling a feature when you
> don't know what provides it, is not fun. E.g. Ubuntu has it enabled by
> default and when you enter the right keywords in google, all resources are
> about uninstalling the module.

I had no idea that's the case -- agreeing with you then. Thanks for replying on this bug.