Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 402275 - Silence denyhosts restart in logrotate script
Summary: Silence denyhosts restart in logrotate script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeremy Olexa (darkside) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-05 19:04 UTC by Dirkjan Ochtman (RETIRED)
Modified: 2012-02-27 08:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirkjan Ochtman (RETIRED) gentoo-dev 2012-02-05 19:04:42 UTC
denyhosts is stopped prior to rotating the logs, then started again after rotating the logs. When cronjob output is emailed, this means email about the restarting. IMO the start/stop should be silent, and the logrotate should be updated to add the -q option to the init.d script command-line. Do you agree? I'm happy to patch it myself.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-02-06 03:30:55 UTC
Please post your patch here and feel free to commit with revbump.
Comment 2 Dirkjan Ochtman (RETIRED) gentoo-dev 2012-02-06 13:38:21 UTC
Pretty much just this:

Index: files/denyhosts.logrotate
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/denyhosts/files/denyhosts.logrotate,v
retrieving revision 1.2
diff -u -B -r1.2 denyhosts.logrotate
--- files/denyhosts.logrotate   1 Jun 2010 18:06:38 -0000       1.2
+++ files/denyhosts.logrotate   6 Feb 2012 13:37:30 -0000
@@ -4,9 +4,9 @@
        create 0640 root root
        sharedscripts
        prerotate
-               /etc/init.d/denyhosts stop
+               /etc/init.d/denyhosts stop -q
        endscript
        postrotate
-               /etc/init.d/denyhosts start
+               /etc/init.d/denyhosts start -q
        endscript
 }

Please confirm, and I'll commit it with revbump to -r6.
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-02-06 13:45:10 UTC
wfm
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-02-26 23:23:21 UTC
+  26 Feb 2012; Jeremy Olexa <darkside@gentoo.org> files/denyhosts.logrotate:
+  silence logrotate script, bug 402275 by Dirkjan Ochtman
Comment 5 Dirkjan Ochtman (RETIRED) gentoo-dev 2012-02-27 08:16:33 UTC
Heh, sorry I didn't follow through. Was about to do it today...