Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 401683 - media-gfx/rawtherapee 4.0.7 version bump
Summary: media-gfx/rawtherapee 4.0.7 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal enhancement (vote)
Assignee: Tim Harder
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-31 19:32 UTC by DrSlony
Modified: 2012-05-01 21:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2012-01-31 19:32:30 UTC
RawTherapee 4.0.7 has been tagged today, please update.

Reproducible: Always
Comment 1 DrSlony 2012-01-31 19:35:02 UTC
DESCRIPTION="Digital photo editing tool focused on RAW image file manipulation and conversion"
Please do not capitalize "raw", it's not an acronym.

Secondly, looking at the ebuild, it looks like it skips the AboutThisBuild file. This file is very important and must be included.
4.0.7 also ships with a RELEASE_NOTES.txt which must be included.

The manual has also been updated, doc/built/pdf/en/RawTherapeeManual_4.0.7.pdf
Comment 2 DrSlony 2012-01-31 20:10:23 UTC
I suggest
DESCRIPTION="A powerful cross-platform raw image processing program."
"Powerful" should set it aside from "simple" converters, such as showFoto's raw import, which target a different audience.
Comment 3 Tim Harder gentoo-dev 2012-02-06 00:47:55 UTC
(In reply to comment #1)
> Secondly, looking at the ebuild, it looks like it skips the AboutThisBuild
> file. This file is very important and must be included.

When upstream starts making actual tarball releases I'll consider doing so. Currently generating the AboutThisBuild file requires bundling the entire mercurial source tree with the tarball which is a poor practice.

Otherwise, upstream could look into allowing the file to be properly generated without requiring the source tree or we'll have to patch it to do that if we want it included.
Comment 4 Tim Harder gentoo-dev 2012-02-06 00:55:10 UTC
I should also note that I asked upstream to make actual tarball releases a while ago and they declined [1].

[1]: http://code.google.com/p/rawtherapee/issues/detail?id=901
Comment 5 DrSlony 2012-02-07 15:51:06 UTC
If a tarball was available, how would that help generate that file?
Comment 6 DrSlony 2012-02-07 15:54:01 UTC
Nevermind that, I see what you mean.
Comment 7 Paweł Rumian 2012-04-07 12:49:09 UTC
Are these not good?
http://code.google.com/p/rawtherapee/downloads/list
Comment 8 Tim Harder gentoo-dev 2012-04-07 21:49:26 UTC
(In reply to comment #7)
> Are these not good?
> http://code.google.com/p/rawtherapee/downloads/list

Not entirely. They still require the hg repository to be bundled in order to build properly without patching.
Comment 9 DrSlony 2012-04-10 16:00:59 UTC
What can we do about it?
Comment 10 Tim Harder gentoo-dev 2012-04-10 20:41:37 UTC
(In reply to comment #9)
> What can we do about it?

If the tarballs are generated using a script, that script should also generate the files that are currently created using the hg repo info when cmake is run.

Basically, building rawtherapee from the release tarballs shouldn't require mercurial or the hg repo to be present in order to generate a complete and proper build.
Comment 11 Tim Harder gentoo-dev 2012-05-01 14:11:51 UTC
4.0.8 added to the tree with the same no hg repo workarounds until upstream removes the requirement for it.
Comment 12 DrSlony 2012-05-01 21:02:16 UTC
Thank you Tim.

The AboutThisBuild issue is on the TODO list:
http://code.google.com/p/rawtherapee/issues/detail?id=1342