Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 401381 - [PATCH] dev-lang/spidermonkey-1.8.5-r1: fix armv7 compilation
Summary: [PATCH] dev-lang/spidermonkey-1.8.5-r1: fix armv7 compilation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2012-01-29 18:01 UTC by Fabio Erculiani (RETIRED)
Modified: 2012-01-30 19:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
armv7 compilation patch (spidermonkey-1.8.5-fix-arm-crap.patch,2.49 KB, patch)
2012-01-29 18:01 UTC, Fabio Erculiani (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2012-01-29 18:01:12 UTC
Hi,
I've been able to fix the spidermonkey build system in order to properly build on ARMv7. The following patch is suitable for all the ARM arches.
Moreover, it requires to run eautoreconf before being applied, it patches Makefile.in and configure.in but the current ones in the tarball seem to be out of date as well.

Reproducible: Always
Comment 1 Fabio Erculiani (RETIRED) gentoo-dev 2012-01-29 18:01:32 UTC
Created attachment 300301 [details, diff]
armv7 compilation patch
Comment 2 Fabio Erculiani (RETIRED) gentoo-dev 2012-01-30 19:10:26 UTC
Some clarifications:
First of all armv7 has hardware floating point unit and forcing -float-abi=softfp would make gcc fail miserably on a hardfp (hardware floating point) system.
Secondly, at least for armv7 (but i also guess it's the same for other arm arches), TARGET_CPU is something like "armv7" and not just "arm", so we really need to use findstring rather than doing exact matching.
Failing to do so has the consequence of some source files not being included for compilation, resulting in linking failure (undefined symbols).
Comment 3 Jory A. Pratt gentoo-dev 2012-01-30 19:37:26 UTC
Thanks for reporting and clarifing all fixed in cvs.