Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 401329 - media-libs/libmikmod-3.2.0_beta2-r2 compile fails at libtool command when /bin/sh is dash
Summary: media-libs/libmikmod-3.2.0_beta2-r2 compile fails at libtool command when /bi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-29 14:56 UTC by Enne Eziarc
Modified: 2012-02-09 23:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
/var/log/paludis/1327848069-install-media-libs_libmikmod-3.2.0_beta2-r2:0::gentoo.out (1327848069-install-media-libs_libmikmod-3.2.0_beta2-r2:0::gentoo.out,15.70 KB, text/plain)
2012-01-29 14:56 UTC, Enne Eziarc
Details
libmikmod-and-dash.patch (libmikmod-and-dash.patch,650 bytes, patch)
2012-02-07 19:46 UTC, Sergei Trofimovich (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enne Eziarc 2012-01-29 14:56:24 UTC
Created attachment 300267 [details]
/var/log/paludis/1327848069-install-media-libs_libmikmod-3.2.0_beta2-r2:0::gentoo.out

As it says on the tin. Every other ebuild installed on my system seems to get it right. Compile output attached.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2012-02-07 18:33:56 UTC
Interesting. I can easily reproduce it.

Out of curiosity: how many packages fail for you that way? I guess it
can be "fixed" by calling libtool directly in not via 'sh'.

    LIBTOOL='$(SHELL) $(top_builddir)/libtool'

(though libtool has #bash shebang and we have the same thing in /usr/bin/libtool)
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2012-02-07 19:46:57 UTC
Created attachment 301181 [details, diff]
libmikmod-and-dash.patch

Now I see. A fun thing:

   Upstream forgot to provide empty libmikmod/Makefile.am so automake didn't
   regen Makefile.in files (and old one knows nothing about SHELL variable).

Creating empty file helped.

@sound: what do you think of attached hack? Worth committing w/o revbump?
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2012-02-08 06:53:25 UTC
> @sound: what do you think of attached hack? Worth committing w/o revbump?

Was too impatient and committed:

>  08 Feb 2012; Sergei Trofimovich <slyfox@gentoo.org>
>  libmikmod-3.2.0_beta2-r4.ebuild:
>  Fix build failure when default shell is dash (bug #401329 by Anthony Parsons).

I'll try to run 'sh -> dash' on my box for a while to see what will break.

Thanks for report, Anthony!
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-02-08 10:01:43 UTC
(In reply to comment #3)
> > @sound: what do you think of attached hack? Worth committing w/o revbump?
> 
> Was too impatient and committed:
> 
> >  08 Feb 2012; Sergei Trofimovich <slyfox@gentoo.org>
> >  libmikmod-3.2.0_beta2-r4.ebuild:
> >  Fix build failure when default shell is dash (bug #401329 by Anthony Parsons).
> 
> I'll try to run 'sh -> dash' on my box for a while to see what will break.
> 
> Thanks for report, Anthony!

Notice that the -autotools.patch in files/ directory is patching the libmikmod/Makefile.in which this commit now overwrites
If that is an issue or not, I have not checked
Comment 5 Enne Eziarc 2012-02-09 23:14:13 UTC
(In reply to comment #1)
> Interesting. I can easily reproduce it.
> 
> Out of curiosity: how many packages fail for you that way?

(sorry for slow reply, my email's been wedged for a few days)

Just this one. I'd been doing some spring cleaning and ended up doing an -e world, I had about 950 packages in all.