Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 40100 - dev-lang/R-1.8.1 needs a patch for new xfree
Summary: dev-lang/R-1.8.1 needs a patch for new xfree
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-01 10:55 UTC by Fredrik Karlsson
Modified: 2004-03-22 03:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild file (R-1.8.1.ebuild,2.64 KB, text/plain)
2004-02-01 10:56 UTC, Fredrik Karlsson
Details
Digest file (digest-R-1.8.1,57 bytes, text/plain)
2004-02-01 10:57 UTC, Fredrik Karlsson
Details
Corrected Ebuild file (R-1.8.1.ebuild,2.64 KB, application/octet-stream)
2004-02-01 11:00 UTC, Fredrik Karlsson
Details
my ebuild (R-1.8.1.ebuild,2.86 KB, text/plain)
2004-02-25 08:47 UTC, Anders Biehl Norgaard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fredrik Karlsson 2004-02-01 10:55:47 UTC
There is a new version og the R language. The attached files is all that is required in order to install + build

Reproducible: Always
Steps to Reproduce:
1. emerge dev-lang/R
2.
3.

Actual Results:  
R is installed in the newest version

Expected Results:  
R is installed in the newest version

R is installed in the newest version
Comment 1 Fredrik Karlsson 2004-02-01 10:56:21 UTC
Created attachment 24762 [details]
Ebuild file

Ebuild file
Comment 2 Fredrik Karlsson 2004-02-01 10:57:26 UTC
Created attachment 24763 [details]
Digest file
Comment 3 Fredrik Karlsson 2004-02-01 10:58:20 UTC
Comment on attachment 24762 [details]
Ebuild file

># Copyright 1999-2003 Gentoo Technologies, Inc.
># Distributed under the terms of the GNU General Public License v2
># $Header: /home/cvsroot/gentoo-x86/dev-lang/R/R-1.8.0.ebuild,v 1.1 2003/10/11:41:00 george Exp $
>
>IUSE="atlas X tcltk gnome"
>
>S=${WORKDIR}/${P}
>
>DESCRIPTION="R is GNU S - A language and environment for statistical computing and graphics."
>
>SRC_URI="http://cran.r-project.org/src/base/${P}.tgz"
>
>	#There are daily release patches, don't know how to utilize these
>	#"ftp://ftp.stat.math.ethz.ch/Software/${PN}/${PN}-release.diff.gz"
>
>HOMEPAGE="http://www.r-project.org/"
>
>DEPEND="virtual/glibc
>		>=dev-lang/perl-5.6.1-r3
>		>=sys-libs/readline-4.1-r3
>		>=sys-libs/zlib-1.1.3-r2
>		>=media-libs/jpeg-6b-r2
>		>=media-libs/libpng-1.2.1
>		atlas? ( dev-libs/atlas )
>		X? ( virtual/x11 )
>		tcltk? ( dev-lang/tk )
>		gnome? ( >=gnome-base/gnome-libs-1.4.1.4 )"
>SLOT="0"
>LICENSE="GPL-2 LGPL-2.1"
>KEYWORDS="~x86 ~sparc ~ppc"
>
>src_compile() {
>
>	local myconf="--enable-R-profiling --enable-R-shlib --with-readline"
>
>	#Eventually, we will want to take into account that a user may have
>	#an alternate or additional blas libraries,
>	#i.e. USE variable blas and and virtual/blas
>	use atlas || myconf="${myconf} --without-blas" #default enabled
>
>	use X || myconf="${myconf} --without-x" #default enabled
>
>	if use tcltk; then
>		#configure needs to find the files tclConfig.sh and tkConfig.sh
>		myconf="${myconf} --with-tcltk --with-tcl-config=/usr/lib/tclConfig.sh --with-tk-config=/usr/lib/tkConfig.sh"
>	else
>		myconf="${myconf} --without-tcltk"
>	fi
>
>	use gnome && myconf="${myconf} --with-gnome" #default disabled
>
>	./configure \
>		--host=${CHOST} \
>		--prefix=/usr \
>		--infodir=/usr/share/info \
>		--mandir=/usr/share/man \
>		${myconf} || die "./configure failed"
>
>	make || die
>
>}
>
>src_install () {
>
>	make \
>		prefix=${D}/usr \
>		mandir=${D}/usr/share/man \
>		infodir=${D}/usr/share/info \
>		install || die "Installation Failed"
>
>	#fix the R wrapper script to have the correct R_HOME_DIR
>	#sed regexp borrowed from included debian rules
>	cp ${D}/usr/lib/R/bin/R ${S}/bin/R.orig
>	sed -e '/^R_HOME_DIR=.*/s::R_HOME_DIR=/usr/lib/R:' \
>		${S}/bin/R.orig > ${D}/usr/lib/R/bin/R
>
>	#R installs two identical wrappers under /usr/bin and /usr/lib/R/bin/
>	#the 2nd one is corrected by above sed, for the 1st
>	#I'll just symlink it into /usr/bin
>	cd ${D}/usr/bin/
>	rm R
>	dosym ../lib/R/bin/R /usr/bin/R
>	cd ${S}
>
>	dodoc AUTHORS BUGS COPYING* ChangeLog FAQ INSTALL *NEWS README \
>		RESOURCES THANKS VERSION Y2K
>
>	#Add rudimentary menu entry if gnome
>	if use gnome; then
>		insinto /usr/share/gnome/apps/Applications
>		doins ${FILESDIR}/R.desktop
>		insinto /usr/share/pixmaps
>		doins ${FILESDIR}/R-logo.png
>	fi
>
>}
Comment 4 Fredrik Karlsson 2004-02-01 11:00:50 UTC
Created attachment 24764 [details]
Corrected Ebuild file
Comment 5 Anders Biehl Norgaard 2004-02-25 08:47:36 UTC
Created attachment 26332 [details]
my ebuild
Comment 6 Anders Biehl Norgaard 2004-02-25 08:49:32 UTC
Hi, I just corrected my renamed my ebuild file to 1.8.1 and apparently everything goes fine (I also updated the name in line 3 of the .ebuild)

I would like to see this ebuild in portage STABLE!!

R-1.8.x is the STABLE branc and 1.8.1 is REQUIRED for the important BioConductor package in R

-Anders
Comment 7 Patrick Kursawe (RETIRED) gentoo-dev 2004-02-25 08:51:22 UTC
Uhm, sorry, but R 1.8.1 is in portage since tuesday last week. If you think your ebuild is better for some reason, please re-open the bug and add some comment what's different and why. Thanks and sorry for not closing this bug in time.

It will be stable in portage if it has been testing for about a month without bug report. Please note that portage stable is not the same as upstream stable.
Comment 8 Anders Biehl Norgaard 2004-02-25 10:00:22 UTC
Ok, I really must sync some more...if your ebuild works, mine is no better.

I still think that, as 1.8.0 has been in the tree for some time, and the changes to 1.8.1 are _trivial_ there should be less of a wait before it is moved into stable.

Thanks
Anders
Comment 9 Michal Maruska 2004-03-07 16:56:01 UTC
i had to patch  
R-1.8.1/src/modules/X11/dataentry.c
this way:

- #define NeedFunctionPrototypes 0
+ #define NeedFunctionPrototypes 1

I use xfree86 4.3.99.x
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2004-03-21 23:04:25 UTC
Patrick could you check out whether the change suggested breaks 4.3.0? It is needed on newer X.
Comment 11 Patrick Kursawe (RETIRED) gentoo-dev 2004-03-22 03:21:22 UTC
Works fine for me, putting into CVS.
Comment 12 Patrick Kursawe (RETIRED) gentoo-dev 2004-03-22 03:22:00 UTC
Oh, and closing, of course :-)