Thermal plugin from lxpanel don't work with sys-fs acpi interface. Reproducible: Always Steps to Reproduce: 1. Disable creation deprecated /proc/acpi files in kernel configuration 2. Reboot with new kernel 3. Thermal plugin show n/a
Created attachment 299903 [details, diff] Patch for thermal plugin
In upstream this problem fixed. Patch work for me.
This is now fixed in 0.5.8-r2. Thanks
Please reopen the bug. This patch alone is useless - lxpanel just segfaults when the /proc/acpi interface is unavailable (maybe even when it *is* available, I didn't check). SYSFS_THERMAL_DIRECTORY is not even used anywhere in the code. Dmitry, did you actually apply this patch alone? The patch is commit 266c072 in git (git://lxde.git.sourceforge.net/gitroot/lxde/lxpanel). Note the full history of thermal.c (new to old): * commit c763b20 | Author: Henry Gebhardt <hsggebhardt@googlemail.com> | Date: Mon Jan 23 23:29:23 2012 +0100 | | thermal: Don't print useless info on startup, fix compile warning | | src/plugins/thermal/thermal.c | 6 ++---- | 1 files changed, 2 insertions(+), 4 deletions(-) | * commit 176a000 | Author: Henry Gebhardt <hsggebhardt@googlemail.com> | Date: Fri Dec 30 20:14:39 2011 +0100 | | thermal: use applyConfig() in the constructor | | The constructor needs to do the same work as applyConfig(), and doing it | twice has been a constant source of bugs. | | src/plugins/thermal/thermal.c | 67 +++++++++++++++------------------------- | 1 files changed, 25 insertions(+), 42 deletions(-) | * commit 15992b6 | Author: Henry Gebhardt <hsggebhardt@googlemail.com> | Date: Fri Dec 30 19:44:38 2011 +0100 | | thermal: be more careful in case th->sensor is NULL | | th->sensor will be NULL when no sensor is found. | | src/plugins/thermal/thermal.c | 2 +- | 1 files changed, 1 insertions(+), 1 deletions(-) | * commit 83af5ca | Author: Henry Gebhardt <hsggebhardt@googlemail.com> | Date: Fri Dec 30 01:38:26 2011 +0100 | | thermal: fix using custom or automatic warning levels, and set the get_functions | | The constructor and applyConfig functions were using different semantics | for th->custom_levels. The dialog says "Automatic Warnings Levels", | which has the same meaning as "Not custom", hence rename the variable to | avoid future confusion, and use the same semantics in the two functions. | One could have used "auto_levels" instead, but since the configuration | uses the variable "CustomLevels", don't change that for a nice update | path. | | Also, if automatic detection is used, the critical temperature as read | from the sensor needs to be updated. At the same time, the get_functions | may need updating, too, so do that as well. | | src/plugins/thermal/thermal.c | 16 ++++++++++------ | 1 files changed, 10 insertions(+), 6 deletions(-) | * commit f990fee | Author: Henry Gebhardt <hsggebhardt@googlemail.com> | Date: Fri Dec 30 00:40:27 2011 +0100 | | thermal: Automatic sensor location also works for sysfs interface | | src/plugins/thermal/thermal.c | 47 ++++++++++++++++++++++++++++++++-------- | 1 files changed, 37 insertions(+), 10 deletions(-) | * commit 266c072 | Author: Henry Gebhardt <hsggebhardt@googlemail.com> | Date: Fri Dec 23 21:02:53 2011 +0100 | | plugins/thermal: support both /proc and sysfs interfaces | | src/plugins/thermal/thermal.c | 108 +++++++++++++++++++++++++++++++++++------ | 1 files changed, 93 insertions(+), 15 deletions(-)
reopening per user request
*** Bug 409231 has been marked as a duplicate of this bug. ***
> Dmitry, did you actually apply this patch alone? Yep. It seems that this is not the only problem with this plugin. After enabling this plugin is no longer updated information on the temperature.
This should be fixed in -r3 which is now masked. Please test and report back here. Thanks a lot
Hi, is the test request for 0.5.8-r3 still active? 0.5.9 is already in the tree -- should it be tested instead? Or are -r3 patches disjoint from 0.5.9?
Nope it should be ok now
