Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 399575 - app-portage/gentoolkit-dev - ekeyword should remove duplicates in KEYWORDS
Summary: app-portage/gentoolkit-dev - ekeyword should remove duplicates in KEYWORDS
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Portage Tools Team
URL: http://sources.gentoo.org/cgi-bin/vie...
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 411301
  Show dependency tree
 
Reported: 2012-01-21 03:04 UTC by zvasylvv
Modified: 2013-05-10 20:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description zvasylvv 2012-01-21 03:04:55 UTC
"~x86-fbsd" keyword present twice in ebuild's keyword 

Reproducible: Always
Comment 1 zvasylvv 2012-01-21 03:29:26 UTC
~x86-fbsd * 2 at x11-libs/gtksourceview-3.2.3
~x86-fbsd * 2 at x11-libs/libXext-1.2.0.ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2012-01-22 14:43:40 UTC
jer@wieneke /newaches/gentoo/cvs/gentoo-x86/x11-libs/libXext $ ebuildvar KEYWORDS
libXext-1.2.0.ebuild : KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x86-fbsd ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
libXext-1.3.0.ebuild : KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
jer@wieneke /newaches/gentoo/cvs/gentoo-x86/x11-libs/libXext $ ekeyword ^x86-fbsd libXext-1.2.0.ebuild
libXext-1.2.0.ebuild
--- libXext-1.2.0.ebuild        2011-02-21 10:37:46.000000000 +0100
+++ libXext-1.2.0.ebuild.new    2012-01-22 15:40:25.000000000 +0100
@@ -10 +10 @@
-KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x86-fbsd ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
+KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
jer@wieneke /newaches/gentoo/cvs/gentoo-x86/x11-libs/libXext $ ekeyword ^x86-fbsd libXext-1.2.0.ebuild
libXext-1.2.0.ebuild
--- libXext-1.2.0.ebuild        2012-01-22 15:40:25.000000000 +0100
+++ libXext-1.2.0.ebuild.new    2012-01-22 15:40:38.000000000 +0100
@@ -10 +10 @@
-KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
+KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
jer@wieneke /newaches/gentoo/cvs/gentoo-x86/x11-libs/libXext $ ekeyword ~x86-fbsd libXext-1.2.0.ebuild
libXext-1.2.0.ebuild
--- libXext-1.2.0.ebuild        2012-01-22 15:40:38.000000000 +0100
+++ libXext-1.2.0.ebuild.new    2012-01-22 15:40:44.000000000 +0100
@@ -10 +10 @@
-KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
+KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86 ~ppc-aix ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
jer@wieneke /newaches/gentoo/cvs/gentoo-x86/x11-libs/libXext $ ekeyword ~x86-fbsd libXext-1.2.0.ebuild
libXext-1.2.0.ebuild

I can't tell whether ekeyword is to blame here, but it probably should remove both entries on the first go. :)
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2012-01-22 15:04:08 UTC
The basic problem is solved, but I think ekeyword needs reviewing.

1) ekeyword ^ARCH does not remove /every/ ARCH.
2) ekeyword does sort entries, but should probably do a `sort -u' equivalent.
Comment 4 zvasylvv 2012-01-30 21:45:10 UTC
Hi there!

Sorry for a bit offtop but I found one more package with duplicated keywors

perl-core/Scalar-List-Utils/Scalar-List-Utils-1.230.0.ebuild - ~ppc-aix *2

I do not know how I missed it for the first time
Comment 5 Christian Ruppert (idl0r) gentoo-dev 2012-04-23 03:02:25 UTC
A duplicate filter has been added.

ekeyword '^x86-fbsd' foo.ebuild works fine as well as ekeyword '^all' foo.ebuild. (Note the quotes..)
Comment 6 Christian Ruppert (idl0r) gentoo-dev 2013-05-10 20:37:43 UTC
This should be fixed in app-portage/gentoolkit-dev-0.2.8.2. Please test.