Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398495 - =dev-lang/php-5.3.9 is missing suhosin patch
Summary: =dev-lang/php-5.3.9 is missing suhosin patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 09:04 UTC by Yoan Blanc
Modified: 2012-02-07 16:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output of the patch command (suhosin-patch-5.3.7-0.9.10.patch.out,81.23 KB, text/plain)
2012-01-11 09:05 UTC, Yoan Blanc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yoan Blanc 2012-01-11 09:04:38 UTC
PHP 5.3.9 cannot be installed with suhosin

Reproducible: Always

Steps to Reproduce:
1. upgrade php-5.3.9 from php-5.3.9_rc4
2. USE="suhosin" emerge =dev-lang/php-5.3.9
Actual Results:  
Installing the latest php-5.3.9 (was the rc4 before)

* Applying suhosin-patch-5.3.7-0.9.10.patch ...

 * Failed Patch: suhosin-patch-5.3.7-0.9.10.patch !
 *  ( /var/tmp/portage/dev-lang/php-5.3.9/work/suhosin-patch-5.3.7-0.9.10.patch )
Comment 1 Yoan Blanc 2012-01-11 09:05:42 UTC
Created attachment 298619 [details]
output of the patch command
Comment 2 krieng_2 2012-01-11 18:02:32 UTC
PHP 5.3.9 cannot be installed with suhosin

Reproducible: Always

Steps to Reproduce:
1. upgrade php-5.3.9 from php-5.3.8
2. emerge =dev-lang/php-5.3.9
Actual Results:  
Installing the latest php-5.3.9


 * Failed Patch: suhosin-patch-5.3.7-0.9.10.patch !
 *  ( /var/tmp/portage/dev-lang/php-5.3.9/work/suhosin-patch-5.3.7-0.9.10.patch )
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/dev-lang/php-5.3.9/temp/suhosin-patch-5.3.7-0.9.10.patch.out

 * ERROR: dev-lang/php-5.3.9 failed (prepare phase):
 *   Failed Patch: suhosin-patch-5.3.7-0.9.10.patch!
 *
 * Call stack:
 *              ebuild.sh, line   85:  Called src_prepare
 *            environment, line 3790:  Called eblit-run 'src_prepare' 'v3'
 *            environment, line 1448:  Called eblit-php-src_prepare
 *   src_prepare-v3.eblit, line   48:  Called epatch '/var/tmp/portage/dev-lang/php-5.3.9/work/suhosin-patch-5.3.7-0.9.10.patch'
 *            environment, line 2255:  Called die
 * The specific snippet of code:
 *               die "Failed Patch: ${patchname}!";
 *
 * If you need support, post the output of 'emerge --info =dev-lang/php-5.3.9',
 * the complete build log and the output of 'emerge -pqv =dev-lang/php-5.3.9'.
 * The complete build log is located at '/var/tmp/portage/dev-lang/php-5.3.9/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/dev-lang/php-5.3.9/temp/environment'.
 * S: '/var/tmp/portage/dev-lang/php-5.3.9/work/php-5.3.9'
Comment 3 Ole Markus With (RETIRED) gentoo-dev 2012-01-11 18:11:56 UTC
Thanks for reporting this.

suhosin USE flag has been disabled.

Cheers,
Ole Markus
Comment 4 Hanno Böck gentoo-dev 2012-01-11 19:45:44 UTC
Looking at the rejects of the latest suhosin patch, they're all more or less trivial. They just change the php identification string.

I'd suggest we try to avoid disabling suhosin with every new php version.
Comment 5 Yoan Blanc 2012-01-11 19:50:05 UTC
+1

the patch was working with the rc4.
Comment 6 Hanno Böck gentoo-dev 2012-01-11 20:07:06 UTC
Patch fixing the rejects:
http://files.hboeck.de/suhosin-patch-5.3.9-0.9.10-inofficial.patch.bz2
Comment 7 Ole Markus With (RETIRED) gentoo-dev 2012-01-11 20:33:02 UTC
# php --version
PHP 5.3.9-pl0-gentoo with Suhosin-Patch (cli) (built: Jan 11 2012 21:30:00) 
Copyright (c) 1997-2011 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2012 Zend Technologies
    with Xdebug v2.1.0, Copyright (c) 2002-2010, by Derick Rethans
    with Suhosin v0.9.32.1, Copyright (c) 2007-2010, by SektionEins GmbH

Happy? :)

Thanks a bunch for the fix.
Comment 8 Hanno Böck gentoo-dev 2012-01-11 22:16:43 UTC
suhosin now has an official patch:
http://www.hardened-php.net/suhosin/download.html
Comment 9 Attila Tóth 2012-01-11 23:19:25 UTC
(In reply to comment #6)
> Patch fixing the rejects:
> http://files.hboeck.de/suhosin-patch-5.3.9-0.9.10-inofficial.patch.bz2

Thumbs up for the patch. I like the fix!
Comment 10 Attila Tóth 2012-01-11 23:20:07 UTC
(In reply to comment #8)
> suhosin now has an official patch:
> http://www.hardened-php.net/suhosin/download.html

Let's hope it'll be soon included.
Comment 11 Ole Markus With (RETIRED) gentoo-dev 2012-01-12 06:08:15 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > suhosin now has an official patch:
> > http://www.hardened-php.net/suhosin/download.html
> 
> Let's hope it'll be soon included.

Ah the timing ... :)

The stabilisation of 5.3.9 has already started, so it will not be included unless we do a revbump. I see the version number did not change for suhosin, so the difference between the two versions cannot be that large.
Comment 12 Matti Bickel (RETIRED) gentoo-dev 2012-02-07 16:56:28 UTC
PHP-5.3.10 uses the upstream suhosin patch. Guess the issue can be considered fixed.