Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398417 - media-video/devede should depend on dev-python/dbus-python
Summary: media-video/devede should depend on dev-python/dbus-python
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-10 18:16 UTC by andrew swartz
Modified: 2012-01-20 16:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andrew swartz 2012-01-10 18:16:39 UTC
devede needs dbus-python to run, but it is not required by the ebuild.

media-video/devede-3.20.0
Comment 1 andrew swartz 2012-01-12 12:19:06 UTC
I should amend this to say that the transmission gtk UI needs dbus-python, 

The qt4 version works as expected without it.
Comment 2 andrew swartz 2012-01-12 12:22:02 UTC
(In reply to comment #1)
> I should amend this to say that the transmission gtk UI needs dbus-python, 
> 
> The qt4 version works as expected without it.

Oops, disregard that second comment, wrong bug.
Comment 3 casell 2012-01-20 16:30:44 UTC
I can confirm this bug.
devede tries to import dbus in devede_convert.py

It seems it's needed only to shutdown the computer when finished, but it's imported at module level so the devede_convert.py module (which is the most important module afaik) fails at startup.

The easiest way to fix could be to just throw in this dependency, but in my opinion another option could be to ask the developer to surround that import with a try...except and handle the lack of dbus when needed (I mean disable the checkbox explaining that dbus support is needed and/or check if dbus is there when the shutdown is really needed)

Looking at the git code it should be a matter of some lines to implement this "runtime dependency check".

If/after this has been implemented in DeVeDe, the ebuild could provide a 'dbus' USE flag.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-01-20 16:49:17 UTC
+*devede-3.21.0 (20 Jan 2012)
+
+  20 Jan 2012; Samuli Suominen <ssuominen@gentoo.org> +devede-3.21.0.ebuild:
+  Version bump. Missing dev-python/dbus-python dependency wrt #398417 by
+  "andrewthomas"